From: "Maciej W. Rozycki" <macro@embecosm.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] GDB: Permit a lone version of Guile with `--with-guile='
Date: Mon, 28 Nov 2022 13:00:38 +0000 (GMT) [thread overview]
Message-ID: <alpine.DEB.2.20.2211271204460.19931@tpp.orcam.me.uk> (raw)
In-Reply-To: <Y4KjgjCQmA/Dhqha@vapier>
On Sun, 27 Nov 2022, Mike Frysinger wrote:
> On 24 Nov 2022 23:51, Maciej W. Rozycki wrote:
> > --- src.orig/gdb/configure.ac
> > +++ src/gdb/configure.ac
> > + case "${guile_version}" in
> > + *[[^.0-9]]*)
>
> in POSIX shell, don't you need to use ! instead of ^ ?
> https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_09_04_05
> https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_13
I guess you are right, although I have never come across it in my 25+
years' shell programming experience. Bash manual says either character is
accepted, which is I suppose why I have never had an issue with using `^'.
I'll send v2.
Well-spotted, thank you!
Maciej
next prev parent reply other threads:[~2022-11-28 13:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 23:50 [PATCH 0/3] GDB: Fix `pkg-config' issues with configuring for Guile Maciej W. Rozycki
2022-11-24 23:51 ` [PATCH 1/3] GDB: Run `pkg-config' with `--static' to pull libguile dependencies Maciej W. Rozycki
2022-11-25 7:56 ` Eli Zaretskii
2022-11-28 12:59 ` Maciej W. Rozycki
2022-11-28 13:35 ` Eli Zaretskii
2022-11-24 23:51 ` [PATCH 2/3] GDB: Permit a lone version of Guile with `--with-guile=' Maciej W. Rozycki
2022-11-26 23:38 ` Mike Frysinger
2022-11-28 13:00 ` Maciej W. Rozycki [this message]
2022-11-24 23:51 ` [PATCH 3/3] GDB: Use standard autoconf macros for `pkg-config' Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.2211271204460.19931@tpp.orcam.me.uk \
--to=macro@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).