Re: [PATCH v2 5/5] GDB: Introduce limited array lengths while printing values

["Maciej W. Rozycki" <macro@embecosm.com>]

On Thu, 12 Jan 2023, Eli Zaretskii wrote:

> > --- src.orig/gdb/NEWS
> > +++ src/gdb/NEWS
> > @@ -354,6 +354,12 @@ GDB now supports floating-point on Loong
> >    Disabling this can cause a performance penalty when there are a lot of
> >    symbols to load, but is useful for debugging purposes.
> >  
> > +* The 'set print elements' setting now helps when printing large arrays.
> > +  If an array would otherwise exceed max-value-size, but 'print elements'
> > +  is set such that the number of elements to print is less than or equal
> > +  to 'max-value-size', GDB will now still print the array, however only
> > +  'max-value-size' worth of data will be added into the value history.
> 
> The wording here needs to be changed, because max-value-size is not
> about the number of elements, it's about the amount of memory needed
> for those elements.  So this part:
> 
>                                                        but 'print elements'
>      is set such that the number of elements to print is less than or equal
>      to 'max-value-size'
> 
> should be reworded.

 Thank you for your review, and thanks for catching this subtlety.  I'll 
replace "number" with "size" above just as in the manual, whether in the 
final version committed or in the next iteration (as appropriate).

  Maciej