From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=uMXC=5P=embecosm.com=macro@sourceware.org>
Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134])
	by sourceware.org (Postfix) with ESMTPS id 18C5D3858D28
	for <gdb-patches@sourceware.org>; Wed, 18 Jan 2023 23:24:28 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 18C5D3858D28
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com
Received: by mail-lf1-x134.google.com with SMTP id f34so645152lfv.10
        for <gdb-patches@sourceware.org>; Wed, 18 Jan 2023 15:24:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=embecosm.com; s=google;
        h=mime-version:user-agent:references:message-id:in-reply-to:subject
         :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=P6KecYAXR3LhV7c0z130XSN+3S/Yc6Vc7vGUnQr7TBY=;
        b=ZgZhHax9ozKRhJShpSCP2T3CPXcwOWrujRbXunsiHIaBS5cMGISsm72OTnWgwDq8Eq
         OaWC3NT2bUYrN7AoaOS7KLHb6SxtouXccG0Htdf5/qEyxobVJ+e6nJZEZFf0Z3WvV0mi
         GL2+K2oFjescMNF4BHlkMSb9f1Aj4JvbUR5wS1eqpgO/cLHAlkCQZ6jhqh7QjFr5W1Wg
         32VOA6dmUttc0Z31oSxahBKsiiKKr+MsVxMWxGmT1yRNoAmw4emO5VPCaBBBiBLii3TQ
         vRHS84s4JEP2jfygBSIT5Bc3T92W/cW2sHSuI7+DdfAKq3RqWCPZ8n86N0PeHfOzHrbj
         MsMg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=mime-version:user-agent:references:message-id:in-reply-to:subject
         :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=P6KecYAXR3LhV7c0z130XSN+3S/Yc6Vc7vGUnQr7TBY=;
        b=4SR+mLmfNMGVu0Lhcy29zXzPJCvcudjWhFN7n9wTnhPH+N5Sbt+teOt1wInM23X48o
         oD7+j5O0UTk3Q/Bc4QjpwkHJKVZv5/M2ug5GR/EF69uMux6+UrFNuEceSK1zfKxRYL2A
         z+OJqGjjbWkP0DJYC3knf+In9OtMx87nu+GAf9mPXeVrmbSZqYqfA7Yz3dlpmKaNqahk
         oGjHkb6VbrKbwHT65/ZmfOb3dwdFyMAyuQWrLyK4LzHANlxi6aNiW+UJ9U5d37e6Dkun
         NDDhFlt0GvrkrfEwccsGRogGPXxz6wn93EyLXCgWPXL3FesIJK3nNuWKX5trdmHyqgQq
         OOjw==
X-Gm-Message-State: AFqh2kr5CjyTXYWaSZuqoN9rtZ9zLKzhTjzJ8JZVqRw7IEWWO2clJCxk
	SCkfrhC0xcC22671bpRpf4kPJQ==
X-Google-Smtp-Source: AMrXdXsNmQZPGnUoj4BsUwcyyuFNuAaQ+KhCe6CJorHDgOvLD5DBY+ol8z9vD1dWiMBg/Eyq5VhzYw==
X-Received: by 2002:ac2:5209:0:b0:4cc:586b:1834 with SMTP id a9-20020ac25209000000b004cc586b1834mr2521776lfl.45.1674084266508;
        Wed, 18 Jan 2023 15:24:26 -0800 (PST)
Received: from [192.168.219.3] ([78.8.192.131])
        by smtp.gmail.com with ESMTPSA id f16-20020a056512361000b004cb27d8edd1sm5743389lfs.85.2023.01.18.15.24.24
        (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
        Wed, 18 Jan 2023 15:24:25 -0800 (PST)
Date: Wed, 18 Jan 2023 23:24:20 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@embecosm.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
cc: gdb-patches@sourceware.org, Andrew Burgess <aburgess@redhat.com>, 
    Tom Tromey <tom@tromey.com>, Simon Sobisch <simonsobisch@web.de>
Subject: [COMMITTED PATCH v9 2.0/6] GDB: Add missing inline documentation
 for `add_setshow_cmd_full'
In-Reply-To: <e9a97f08-2e48-5110-12f5-ad16f9fa5694@polymtl.ca>
Message-ID: <alpine.DEB.2.20.2301182157350.7841@tpp.orcam.me.uk>
References: <alpine.DEB.2.20.2211240256210.19931@tpp.orcam.me.uk> <alpine.DEB.2.20.2211240457530.19931@tpp.orcam.me.uk> <e9a97f08-2e48-5110-12f5-ad16f9fa5694@polymtl.ca>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

On Thu, 12 Jan 2023, Simon Marchi wrote:

> > Index: src/gdb/cli/cli-decode.c
> > ===================================================================
> > --- src.orig/gdb/cli/cli-decode.c
> > +++ src/gdb/cli/cli-decode.c
> > @@ -580,6 +580,18 @@ add_setshow_cmd_full_erased (const char
> >    return {set, show};
> >  }
> >  
> > +/* Add element named NAME to both the command SET_LIST and SHOW_LIST.
> 
> "to both the command" doesn't really make sense.  I'd say "to both
> command lists SET_LIST and SHOW_LIST", or "to both lists SET_LIST and
> SHOW_LIST".
> 
> I see that this text comes from add_setshow_cmd_full_erased, it can be
> fixed there too.  Also, it would be fine to just document the duplicated
> parameters in one function and refer to that in the other function.

 Fair enough.  Indeed I have copied the sentence verbatim from the other 
place.  I have fixed this and applied as in this mini sub-series.  Thank 
you for your review.

  Maciej