From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by sourceware.org (Postfix) with ESMTPS id E57FB3858D28 for ; Wed, 18 Jan 2023 23:41:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E57FB3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-lf1-x12c.google.com with SMTP id b3so749373lfv.2 for ; Wed, 18 Jan 2023 15:41:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=v9wsTES/1fm6nCd8ZG92BmfGEszGhBmqYNAx3LZDMcw=; b=HJZvsfVR+pTc0uJDX7vnQ7mCS2vK+TuZHQGBM7hgKcYnonLx4EmTtem4YVtb0lXNS/ o1tVnWXDpnG70tWmKKiLO8F9cR2TQMhb2n+87m7mBW40WeRpxFf/QnPNtdQcoteU8L0u iKS/kdH7ESeoR1F1FC7BnbcQQfQXKV27XpDDSQD+wuA6NRLOsrZOWlq5XNqeby5n5KeR AevExcco30xLrSFYICxS6DmL4XYCEGuxjgm1HaXpRyjIggZ7jU7B2FM5ING+ttIRdpXd AiffC0c6o4y0tDgIObkWmIP6NxqQdQSikr20wfD4BMOibu/SaSaBhh+Ao6KBO/umw1Gz N8sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v9wsTES/1fm6nCd8ZG92BmfGEszGhBmqYNAx3LZDMcw=; b=XQxRxaVQmGvqguFmT2+jl3ebuWIgv06XsDB0HEg2XJm2cztE3HJHo1ecT2WhJQ6khr TQDfdAXYkHC9ECe2O6IcRdxjU+/9UNq4GzC8PZE4lrS6T1eoEFy9AJUrSriJKoHfjknx rQcmzXS+HuqHcEGYqvhNoPtmQG2kprKudMsFbHTYENCxd+yhYYNCbjBp4G85rSJBi4x1 KdHDt9h2s2W90m8oNrNhnNRpW2ZqvXw/C1CmmOx+WrjkUta0oHNF7ukExumRn2iptHfe 4n+69dhhVKn/A3GJBViV8RO0ARCVtpjFYtg6JnppOTiqo5ti0TBGbLuf+PC5E/pV2GRc kX1g== X-Gm-Message-State: AFqh2krN/flkcg8z+sGGCdAzU9YMUh9NliwK89eyv0+e9a+iVCxFzSL0 Uzfcgq7H1Z0Ch8Bw94qsUlT+xFRjq71AzeVV X-Google-Smtp-Source: AMrXdXu2CFs3CMbxbiKbom5eX9lEVx9Toh5RLig5QY8PsytGnuA+mqRjfB8PNoIgSKEfUDuNHLsAAw== X-Received: by 2002:a05:6512:1047:b0:4d2:72bf:7382 with SMTP id c7-20020a056512104700b004d272bf7382mr3492199lfb.37.1674085269476; Wed, 18 Jan 2023 15:41:09 -0800 (PST) Received: from [192.168.219.3] ([78.8.192.131]) by smtp.gmail.com with ESMTPSA id p7-20020a2e9a87000000b00285d9411c80sm3628089lji.38.2023.01.18.15.41.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Jan 2023 15:41:08 -0800 (PST) Date: Wed, 18 Jan 2023 23:41:06 +0000 (GMT) From: "Maciej W. Rozycki" To: Simon Marchi cc: gdb-patches@sourceware.org, Andrew Burgess , Tom Tromey , Simon Sobisch Subject: Re: [PATCH v8 3/6] GDB: Add references to erased args in cli-decode.c In-Reply-To: <0f5e6a68-5927-8cfe-24b2-6b91c07578b2@polymtl.ca> Message-ID: References: <0f5e6a68-5927-8cfe-24b2-6b91c07578b2@polymtl.ca> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 12 Jan 2023, Simon Marchi wrote: > > Complement commit 1d7fe7f01b93 ("gdb: Introduce setting construct within > > cmd_list_element") and commit 702991711a91 ("gdb: Have setter and getter > > callbacks for settings") and update inline documentation accordingly for > > `add_set_or_show_cmd' and `add_setshow_cmd_full_erased', documenting the > > `args' parameter and removing references to `var', `set_setting_func' > > and `get_setting_func'. > > If you want to change them so they cross-reference a single place where > these parameters are documented, it would be fine too. But in any case: This is good enough however, so I have applied it unchanged. Thank you for your review. Maciej