From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by sourceware.org (Postfix) with ESMTPS id EE8BC38582A1 for ; Thu, 19 Jan 2023 21:17:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EE8BC38582A1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-lf1-x136.google.com with SMTP id d30so5093447lfv.8 for ; Thu, 19 Jan 2023 13:17:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MfK/EQvItaB+Y/KG7C8h5IFpnv3LQnWWH6rnnpcWcTA=; b=QtdRMJYc2MJe9EWMqT6pOEsBcEGEbrUQXJ7gzizfKMf9zM2KM120OzkzbDHNAhDkA2 AYlUiufl8/iKKywqoG/Nu3hDog1xxis/9ZnbZmyvwaBHDjZtgxeKdhExnwp+F643gPUO 8JofzPc/doLG+aqPJ+gjEipA6Yl5TJuezdcFkf1wtHPU57qC3A+teVTPbwyRWq62uLce Of27hfQUJdTQTrExRJ/ZjoMvzdtGYZHBoM/ReB66Ve/IWG8bubKYFy0BFpxz9Xqe3i0D 0dP69pieUiFOatK7lMdLZYo+C5MYxMy0BREJjN2l4E+bkYgKUtAQq0oahE8d7nqh4RFU xDwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MfK/EQvItaB+Y/KG7C8h5IFpnv3LQnWWH6rnnpcWcTA=; b=0R6LNmufhWGSADTOZpOXvmTzlSpdWMqHS6lH1DpgT8g8wyXtHgxRldMNiTtu7I+UDl pMqnjAZ7SI+g6B9W5bmck18wmj2S36ZNxl+hspsDi28aiGztmVRnDeY6kBl08Jf8yHxD sl/UiFQJ0YcF0w844R0boLINqVMyHJk3SPJGxUZYKz2zNcnQ7zMFZtqIYAZw+FD5jojO sR0jxQ6+7m304AfojoTu/mDk7zOUw2HZxA9/anqNXqyXWCNnfoH1cfW6J+silMXGBOOF Fo7KcngTqPweJPAvqUhoRtENKNmLIW9r5z2PV5XN6RdXttjA/6Y+Cb4gtmOYYXUUSm1R JFbw== X-Gm-Message-State: AFqh2kqDsXYVt5R5aUWYHMjkI3/slWSKN33pdmv9jyap1zER28/ODzn4 F6aVPWsjenifCcKzE1h4YhehwQ== X-Google-Smtp-Source: AMrXdXs/pLlJJ0T+CyNHKcfABkdPi3OD8ZlWbkQ8irmE8wMFbSx8+0CLEj3QTBPFSHo5Bi5yCVcTnA== X-Received: by 2002:a05:6512:158e:b0:4cc:93e9:df8e with SMTP id bp14-20020a056512158e00b004cc93e9df8emr4039388lfb.33.1674163073598; Thu, 19 Jan 2023 13:17:53 -0800 (PST) Received: from [192.168.219.3] ([78.8.192.131]) by smtp.gmail.com with ESMTPSA id s6-20020ac25fe6000000b004b50b4f63b7sm5970032lfg.170.2023.01.19.13.17.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Jan 2023 13:17:48 -0800 (PST) Date: Thu, 19 Jan 2023 21:17:46 +0000 (GMT) From: "Maciej W. Rozycki" To: Simon Marchi cc: gdb-patches@sourceware.org, Andrew Burgess , Tom Tromey , Simon Sobisch Subject: Re: [PATCH v8 5/6] GDB: Add a character string limiting option In-Reply-To: <50d5003a-b5ff-aba0-24db-c0c2048e96d7@polymtl.ca> Message-ID: References: <50d5003a-b5ff-aba0-24db-c0c2048e96d7@polymtl.ca> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 16 Jan 2023, Simon Marchi wrote: > > which keeps it the same as it used to be, although in other contexts the > > setting is described as applying to array elements only, e.g.: > > > > (gdb) help set print elements > > Set limit on array elements to print. > > "unlimited" causes there to be no limit. > > I think it would be helpful to say here that if this value influences > "set print characters", if "set print characters" is set to "elements". I have added this clarification: This setting also applies to string chars when "print characters" is set to "elements". and updated the commit description accordingly. I'm sending the final version of the patch applied, in a reply to this message. Thank you for your review. Maciej