From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by sourceware.org (Postfix) with ESMTPS id F06193858D33 for ; Mon, 23 Jan 2023 23:13:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F06193858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-lf1-x135.google.com with SMTP id b3so20627447lfv.2 for ; Mon, 23 Jan 2023 15:13:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KJVkCNaeZVHNu5eiVB4S5twoaK8RIGWZ2RTPj3WWfxo=; b=OiJUsBMylFSZtw/IS78CaErCgL9X4s5xlsIBukpwd6cWab5Xy7U7tZts9pXdsZyA8r 80Rgp63yJAS70oJQfCQkWUP8YujAP1S9O545bPIswl18g8j1Nu6mw1oyDuHg7Fu9y+5f jc/f/PDA5ExsnQQ7A0BDGb1++4m/8bHd07yASSbayulMZwUO4dNBPfiVOZ5X0duYpae6 34Xgs06LU1MbBgzPX6TDlm33+A+WQ4ww6XIAm2f9puFmnMWE8ZqW0EMF9Wqh71UZQidn /cXd7TPj4rhdGn4ooAbQYIwl5NaSMLT8fDKqry0IOf0rEthIv7cx+xSs4gH4M23deTsf fTHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KJVkCNaeZVHNu5eiVB4S5twoaK8RIGWZ2RTPj3WWfxo=; b=sX5LPGIQlcdsvcjaVwNLS/pKXt/NfAQxfoZ2+NIN7xiIBplp7xdEUDDuvkKDLWvO/C V/FCrHeRjzdTck7hi58C8MJCAMUnQAM3JW2HEzfZ0+kuhRU04fCm3y4VFgn6/4vbON5y h+yICyTWgSe1+rDr4JukAHm6DvVGphZkFpP3Cl+md8pNPC649iQuQA1CV1nWYIH7VQGz tlssRJIPkwp1LMWeNqkMn7v62Icvqm+1pGOJetoOyYN4KH6CCExh7om8EjVf5XdKayZV 1pif7N0VSejFifNeVqnudKTZkArIZKGNDOrELBbA9+m8GQNLLj8VngM4GEX0fRrU1CQf Z1Nw== X-Gm-Message-State: AFqh2kqb3XStr96vVBGQLchrpVsItERwHb9xUSVtqBjNOjgFcBUmQkWg cxOX4mZchQvfgDc77xB3GMvaZ+iCDjAnomPZ X-Google-Smtp-Source: AMrXdXuw9FtwKvy+aynhrohUVqMND43XjHF0ofYrxQuuAVxOBMUr5qHCwTpfPpVqaW12vTL5/oypHg== X-Received: by 2002:a05:6512:ac7:b0:4b6:ed8b:4f16 with SMTP id n7-20020a0565120ac700b004b6ed8b4f16mr8254903lfu.52.1674515614506; Mon, 23 Jan 2023 15:13:34 -0800 (PST) Received: from [192.168.219.3] ([78.8.192.131]) by smtp.gmail.com with ESMTPSA id u14-20020ac243ce000000b004b4ea0f4e25sm17775lfl.301.2023.01.23.15.13.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jan 2023 15:13:23 -0800 (PST) Date: Mon, 23 Jan 2023 23:13:08 +0000 (GMT) From: "Maciej W. Rozycki" To: gdb-patches@sourceware.org cc: Andrew Burgess , Tom Tromey , Richard Bunt Subject: [PATCH v3 1/5] GDB: Ignore `max-value-size' setting with value history accesses In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: We have an inconsistency in value history accesses where array element accesses cause an error for entries exceeding the currently selected `max-value-size' setting even where such accesses successfully complete for elements located in the inferior, e.g.: (gdb) p/d one $1 = 0 (gdb) p/d one_hundred $2 = {0 } (gdb) p/d one_hundred[99] $3 = 0 (gdb) set max-value-size 25 (gdb) p/d one_hundred value requires 100 bytes, which is more than max-value-size (gdb) p/d one_hundred[99] $7 = 0 (gdb) p/d $2 value requires 100 bytes, which is more than max-value-size (gdb) p/d $2[99] value requires 100 bytes, which is more than max-value-size (gdb) According to our documentation the `max-value-size' setting is a safety guard against allocating an overly large amount of memory. Moreover a statement in documentation says, concerning this setting, that: "Setting this variable does not effect values that have already been allocated within GDB, only future allocations." While in the implementer-speak the sentence may be unambiguous I think the outside user may well infer that the setting only applies to values that need to be retrieved from the debuggee. Therefore rather than just fixing this inconsistency it seems reasonable to lift the setting for value history accesses, under an implication that by having been retrieved from the debuggee they have already passed the safety check. Do it then, by suppressing the value size check in `value_copy' -- under an observation that if the original value has been already loaded (i.e. it's not lazy), then it must have previously passed said check -- making the last two commands succeed: (gdb) p/d $2 $8 = {0 } (gdb) p/d $2 [99] $9 = 0 (gdb) Expand the testsuite accordingly, covering both value history handling and the use of `value_copy' by `make_cv_value', used by Python code. --- Changes from v2: - Always suppress the size check in `value_copy' (keeping the grammatical fix to the function description). - Add Python coverage for `make_cv_value' vs `max-value-size'. New change in v2. --- gdb/testsuite/gdb.base/max-value-size.exp | 3 ++ gdb/testsuite/gdb.python/py-xmethods.exp | 17 +++++++++++++ gdb/testsuite/gdb.python/py-xmethods.py | 17 +++++++++++++ gdb/value.c | 38 ++++++++++++++++++------------ 4 files changed, 61 insertions(+), 14 deletions(-) gdb-value-history-size.diff Index: src/gdb/testsuite/gdb.base/max-value-size.exp =================================================================== --- src.orig/gdb/testsuite/gdb.base/max-value-size.exp +++ src/gdb/testsuite/gdb.base/max-value-size.exp @@ -53,6 +53,9 @@ proc do_value_printing { max_value_size gdb_test "p/d one_hundred" " = \\{0 \\}" } gdb_test "p/d one_hundred \[99\]" " = 0" + # Verify that accessing value history is undisturbed. + gdb_test "p/d \$2" " = \\{0 \\}" + gdb_test "p/d \$2 \[99\]" " = 0" } } Index: src/gdb/testsuite/gdb.python/py-xmethods.exp =================================================================== --- src.orig/gdb/testsuite/gdb.python/py-xmethods.exp +++ src/gdb/testsuite/gdb.python/py-xmethods.exp @@ -160,3 +160,20 @@ gdb_test_no_output "enable xmethod progs gdb_test "pt e.method('a')" "type = void" gdb_test "pt e.method(10)" \ "NotImplementedError.*Error while fetching result type of an xmethod worker defined in Python." + +# Verify `max-value-size' obedience with `gdb.Value.const_value'. +gdb_test "p a1.getarray()" \ + "From Python .* = \\{0, 1, 2, 3, 4, 5, 6, 7, 8, 9\\}" \ + "after: a1.getarray" +gdb_test "p b1.getarray()" \ + "From Python .* = \\{0, 1, 2, 3, 4, 5, 6, 7, 8, 9\\}" \ + "after: b1.getarray" +gdb_test_no_output "python gdb.set_parameter('max-value-size', 16)" +gdb_test "p a1.getarray()" \ + "From Python .*value requires $decimal bytes,\ + which is more than max-value-size" \ + "after: a1.getarray (max-value-size)" +gdb_test "p b1.getarray()" \ + "From Python .*value requires $decimal bytes,\ + which is more than max-value-size" \ + "after: b1.getarray (max-value-size)" Index: src/gdb/testsuite/gdb.python/py-xmethods.py =================================================================== --- src.orig/gdb/testsuite/gdb.python/py-xmethods.py +++ src/gdb/testsuite/gdb.python/py-xmethods.py @@ -39,6 +39,11 @@ from gdb.xmethod import SimpleXMethodMat return obj["a"] +def A_getarray(obj): + print("From Python :") + return obj["array"] + + def A_getarrayind(obj, index): print("From Python :") return obj["array"][index] @@ -48,12 +53,18 @@ from gdb.xmethod import SimpleXMethodMat return obj["array"][index].reference_value() +def B_getarray(obj): + print("From Python :") + return obj["array"].const_value() + + def B_indexoper(obj, index): return obj["array"][index].const_value().reference_value() type_A = gdb.parse_and_eval("(dop::A *) 0").type.target() type_B = gdb.parse_and_eval("(dop::B *) 0").type.target() +type_array = gdb.parse_and_eval("(int[10] *) 0").type.target() type_int = gdb.parse_and_eval("(int *) 0").type.target() @@ -211,12 +222,18 @@ global_dm_list = [ SimpleXMethodMatcher(r"plus_plus_A", r"^dop::A$", r"operator\+\+", plus_plus_A), SimpleXMethodMatcher(r"A_geta", r"^dop::A$", r"^geta$", A_geta), SimpleXMethodMatcher( + r"A_getarray", r"^dop::A$", r"^getarray$", A_getarray, type_array + ), + SimpleXMethodMatcher( r"A_getarrayind", r"^dop::A$", r"^getarrayind$", A_getarrayind, type_int ), SimpleXMethodMatcher( r"A_indexoper", r"^dop::A$", r"operator\[\]", A_indexoper, type_int ), SimpleXMethodMatcher( + r"B_getarray", r"^dop::B$", r"^getarray$", B_getarray, type_array + ), + SimpleXMethodMatcher( r"B_indexoper", r"^dop::B$", r"operator\[\]", B_indexoper, type_int ), ] Index: src/gdb/value.c =================================================================== --- src.orig/gdb/value.c +++ src/gdb/value.c @@ -1034,31 +1034,42 @@ check_type_length_before_alloc (const st } } -/* Allocate the contents of VAL if it has not been allocated yet. */ +/* Allocate the contents of VAL if it has not been allocated yet. + If CHECK_SIZE is true, then apply the usual max-value-size checks. */ static void -allocate_value_contents (struct value *val) +allocate_value_contents (struct value *val, bool check_size) { if (!val->contents) { - check_type_length_before_alloc (val->enclosing_type); + if (check_size) + check_type_length_before_alloc (val->enclosing_type); val->contents.reset ((gdb_byte *) xzalloc (val->enclosing_type->length ())); } } -/* Allocate a value and its contents for type TYPE. */ +/* Allocate a value and its contents for type TYPE. If CHECK_SIZE is true, + then apply the usual max-value-size checks. */ -struct value * -allocate_value (struct type *type) +static struct value * +allocate_value (struct type *type, bool check_size) { struct value *val = allocate_value_lazy (type); - allocate_value_contents (val); + allocate_value_contents (val, check_size); val->lazy = 0; return val; } +/* Allocate a value and its contents for type TYPE. */ + +struct value * +allocate_value (struct type *type) +{ + return allocate_value (type, true); +} + /* Allocate a value that has the correct length for COUNT repetitions of type TYPE. */ @@ -1169,7 +1180,7 @@ value_contents_raw (struct value *value) struct gdbarch *arch = get_value_arch (value); int unit_size = gdbarch_addressable_memory_unit_size (arch); - allocate_value_contents (value); + allocate_value_contents (value, true); ULONGEST length = value_type (value)->length (); return gdb::make_array_view @@ -1179,7 +1190,7 @@ value_contents_raw (struct value *value) gdb::array_view value_contents_all_raw (struct value *value) { - allocate_value_contents (value); + allocate_value_contents (value, true); ULONGEST length = value_enclosing_type (value)->length (); return gdb::make_array_view (value->contents.get (), length); @@ -1752,9 +1763,8 @@ value_release_to_mark (const struct valu return result; } -/* Return a copy of the value ARG. - It contains the same contents, for same memory address, - but it's a different block of storage. */ +/* Return a copy of the value ARG. It contains the same contents, + for the same memory address, but it's a different block of storage. */ struct value * value_copy (const value *arg) @@ -1765,7 +1775,7 @@ value_copy (const value *arg) if (value_lazy (arg)) val = allocate_value_lazy (encl_type); else - val = allocate_value (encl_type); + val = allocate_value (encl_type, false); val->type = arg->type; VALUE_LVAL (val) = arg->lval; val->location = arg->location; @@ -4162,7 +4172,7 @@ void value_fetch_lazy (struct value *val) { gdb_assert (value_lazy (val)); - allocate_value_contents (val); + allocate_value_contents (val, true); /* A value is either lazy, or fully fetched. The availability/validity is only established as we try to fetch a value. */