From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34]) by sourceware.org (Postfix) with ESMTP id 3B3E63857432 for ; Tue, 10 May 2022 21:13:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3B3E63857432 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk Received: by angie.orcam.me.uk (Postfix, from userid 500) id 51FE69200C4; Tue, 10 May 2022 23:13:58 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 4E2149200C1; Tue, 10 May 2022 22:13:58 +0100 (BST) Date: Tue, 10 May 2022 22:13:58 +0100 (BST) From: "Maciej W. Rozycki" To: Tom Tromey cc: Youling Tang , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: mips: Fix large-frame.exp test case failure In-Reply-To: <87mthpfxnk.fsf@tromey.com> Message-ID: References: <1647307310-21454-1-git-send-email-tangyouling@loongson.cn> <875yodkg0a.fsf@tromey.com> <87mthpfxnk.fsf@tromey.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3489.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_INFOUSMEBIZ, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 May 2022 21:14:00 -0000 On Wed, 16 Mar 2022, Tom Tromey wrote: > Maciej> It is a standard code sequence for loading the GP with the n64 ABI (I > Maciej> don't know why DADDIU rather than ADDIU has been chosen for the low part > Maciej> of the 32-bit offset given that they produce the same result, but there > Maciej> you go), produced either explicitly by GCC or by GAS with the `.cpsetup' > Maciej> assembly pseudo-op (in which case ADDIU is actually used). > > Thanks! If you're still looking at MIPS patches I will just let them > slide by :-) I thought this change had been pushed, and then I've noticed it has not. I have therefore verified the microMIPS prologue scanner already has the corresponding bits, reformatted the change description so as to make it fit in 74 columns, added a couple of line breaks, removed `^M' artifacts, and finally pushed the commit. Thank you, Youling, for your contribution! Maciej