From: Joseph Myers <joseph@codesourcery.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: <binutils@sourceware.org>, Matthias Klose <doko@ubuntu.com>,
<gcc-patches@gcc.gnu.org>, <gdb-patches@sourceware.org>
Subject: Re: V3 [PATCH 5/5] gnulib: Support variables from the top level Makefile
Date: Thu, 31 Dec 2020 23:50:22 +0000 [thread overview]
Message-ID: <alpine.DEB.2.22.394.2012312348060.929441@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20201219181036.178248-6-hjl.tools@gmail.com>
On Sat, 19 Dec 2020, H.J. Lu via Gcc-patches wrote:
> Work around what appears to be a GNU make bug handling MAKEFLAGS
> values defined in terms of make variables, as is the case for CC and
> friends when we are called from the top level Makefile.
This description, and the comment in Makefile.am repeating it, is rather
unhelpful as it provides no way for a reader to know what the supposed bug
is. Reviewers need to be able to work out whether the proposed workaround
is correct or the right approach for working around the bug. Maintainers
in future need to be able to tell what the bug is. So the comment needs
to explain what the bug is and give a reference to a report for the bug in
the GNU make bug tracker, so that subsequent maintainers can look at that
bug to tell if the workaround is still needed at all.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2020-12-31 23:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-19 18:10 V3 [PATCH 0/5] Support the PGO build for binutils+gdb H.J. Lu
2020-12-19 18:10 ` V3 [PATCH 1/5] GCC: Pass --plugin to AR and RANLIB H.J. Lu
2020-12-19 18:10 ` V3 [PATCH 2/5] Binutils: " H.J. Lu
2020-12-19 18:10 ` V3 [PATCH 3/5] Support the PGO build for binutils+gdb H.J. Lu
2021-02-28 7:01 ` Mike Frysinger
2021-02-28 12:44 ` [PATCH] Add missing changes to Makefile.tpl H.J. Lu
2020-12-19 18:10 ` V3 [PATCH 4/5] Set TESTS to gdb.dwarf2/*.exp for PGO build training H.J. Lu
2020-12-19 18:10 ` V3 [PATCH 5/5] gnulib: Support variables from the top level Makefile H.J. Lu
2020-12-31 23:50 ` Joseph Myers [this message]
2021-01-01 0:06 ` H.J. Lu
2021-01-05 13:26 ` Christian Biesinger
2021-01-05 14:06 ` H.J. Lu
2021-01-02 19:22 ` V3 [PATCH 0/5] Support the PGO build for binutils+gdb Segher Boessenkool
2021-01-02 19:46 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2012312348060.929441@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=binutils@sourceware.org \
--cc=doko@ubuntu.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).