From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 7C35B386188A; Thu, 31 Dec 2020 23:50:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7C35B386188A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=joseph_myers@mentor.com IronPort-SDR: 5KYHg+qejAiy1GfEOD837iJficnLhYKLNcpgo8k4eAqOwfZHX9JfSBb/uHjLRTg66cYqEO2UY6 YkdGCu/taW//64W1AgC0ykwI87qq8j61Ggd3NYieW/8ytamKjpl0BlsoW9ocGJ4r7o3bfg3UTe x0ebnDFH6Qa+0W8oH4X6mG1koGWN7KBp+Gc3ElHMjSqlWqH1VkYIGqT8B6ibawsuXyN72Ssro9 vIHz2YL6r+o8M2vbu7F64GwpKjGa2E6FZ7sQ6RBb+x4lPszY5Svfk1y2Q2OYlfY5gdRhJ08BW1 9bc= X-IronPort-AV: E=Sophos;i="5.78,464,1599552000"; d="scan'208";a="56821516" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 31 Dec 2020 15:50:28 -0800 IronPort-SDR: nz0myFnXNXvyt9AH0BDbOZpS2E6Ov7GyT782kGF4HRfS7CUAGzWKistK1DoRyGdZeUI16MDguq V0iic9e3lF2jA83a/T6eNUfbGdGE6VqQbsID28Zweb8uHrF/uuiwaZaxdoiH9clC5NBWiQ7kxy 44UF7SDS3cLLtjAG77i91FkXalgVMNETNyfqctWbte9CVkVumaqb5eEn5eETPkU2/MFq6G9PCZ i+jRsMfLFGsQRMF/xfx03Nzq2rc/i4eBvuPniMnt7tMcmC7BL3wxneITy2LSXdwlxzicS0xPZy Kck= Date: Thu, 31 Dec 2020 23:50:22 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: "H.J. Lu" CC: , Matthias Klose , , Subject: Re: V3 [PATCH 5/5] gnulib: Support variables from the top level Makefile In-Reply-To: <20201219181036.178248-6-hjl.tools@gmail.com> Message-ID: References: <20201219181036.178248-1-hjl.tools@gmail.com> <20201219181036.178248-6-hjl.tools@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3124.1 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Dec 2020 23:50:31 -0000 On Sat, 19 Dec 2020, H.J. Lu via Gcc-patches wrote: > Work around what appears to be a GNU make bug handling MAKEFLAGS > values defined in terms of make variables, as is the case for CC and > friends when we are called from the top level Makefile. This description, and the comment in Makefile.am repeating it, is rather unhelpful as it provides no way for a reader to know what the supposed bug is. Reviewers need to be able to work out whether the proposed workaround is correct or the right approach for working around the bug. Maintainers in future need to be able to tell what the bug is. So the comment needs to explain what the bug is and give a reference to a report for the bug in the GNU make bug tracker, so that subsequent maintainers can look at that bug to tell if the workaround is still needed at all. -- Joseph S. Myers joseph@codesourcery.com