From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Recognize branch instruction on MIPS in gdb.trace/entry-values.exp
Date: Thu, 08 Jan 2015 01:24:00 -0000 [thread overview]
Message-ID: <alpine.LFD.2.11.1501080118280.27020@eddie.linux-mips.org> (raw)
In-Reply-To: <87oaqat6uj.fsf@codesourcery.com>
On Thu, 8 Jan 2015, Yao Qi wrote:
> >> If it is jalrc, set
> >> + # RETURNED_FROM_FOO to insn1, otherwise set RETURNED_FROM_FOO to
> >> + # insn2.
> >> + set call_insn {jalrc|[jb]al[sxr]*[ \t][^\r\n]+\r\n}
> >
> > OK, this should work. I have a minor nit yet: `[sxr]?' will be more
> > accurate than `[sxr]*', you want to see the letter at most once. The
> > former regexp will likely interpret faster too.
>
> We want to match JALRS, so [sxr]* is needed here.
Fair enough, the pattern matches more than necessary, but there are no
MIPS instructions it would match that it shouldn't, so let's keep your
proposal as it is for simplicity. I have no further concerns, thanks for
your work and for getting through this review.
Maciej
next prev parent reply other threads:[~2015-01-08 1:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-29 8:15 Yao Qi
2014-12-29 23:20 ` Maciej W. Rozycki
2014-12-30 12:34 ` Yao Qi
2014-12-30 14:17 ` Maciej W. Rozycki
2015-01-04 8:42 ` Yao Qi
2015-01-07 23:22 ` Maciej W. Rozycki
2015-01-08 1:10 ` Yao Qi
2015-01-08 1:24 ` Maciej W. Rozycki [this message]
2015-01-08 3:47 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.11.1501080118280.27020@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).