From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-118820-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19009 invoked by alias); 8 Jan 2015 01:24:23 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 18978 invoked by uid 89); 8 Jan 2015 01:24:19 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: cvs.linux-mips.org
Received: from eddie.linux-mips.org (HELO cvs.linux-mips.org) (148.251.95.138) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Jan 2015 01:24:17 +0000
Received: from localhost.localdomain ([127.0.0.1]:44549 "EHLO        localhost.localdomain" rhost-flags-OK-OK-OK-OK)        by eddie.linux-mips.org with ESMTP id S27010211AbbAHBYPG1sqJ (ORCPT        <rfc822;gdb-patches@sourceware.org>); Thu, 8 Jan 2015 02:24:15 +0100
Date: Thu, 08 Jan 2015 01:24:00 -0000
From:   "Maciej W. Rozycki" <macro@linux-mips.org>
To:     Yao Qi <yao@codesourcery.com>
cc:     gdb-patches@sourceware.org
Subject: Re: [PATCH] Recognize branch instruction on MIPS in gdb.trace/entry-values.exp
In-Reply-To: <87oaqat6uj.fsf@codesourcery.com>
Message-ID: <alpine.LFD.2.11.1501080118280.27020@eddie.linux-mips.org>
References: <1419840861-10723-1-git-send-email-yao@codesourcery.com>        <alpine.DEB.1.10.1412292255010.19155@tp.orcam.me.uk>        <87zja5uxjk.fsf@codesourcery.com>        <alpine.DEB.1.10.1412301401280.19155@tp.orcam.me.uk>        <87r3vbuecf.fsf@codesourcery.com>        <alpine.LFD.2.11.1501072207140.27020@eddie.linux-mips.org> <87oaqat6uj.fsf@codesourcery.com>
User-Agent: Alpine 2.11 (LFD 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-IsSubscribed: yes
X-SW-Source: 2015-01/txt/msg00154.txt.bz2

On Thu, 8 Jan 2015, Yao Qi wrote:

> >>  If it is jalrc, set
> >> +    # RETURNED_FROM_FOO to insn1, otherwise set RETURNED_FROM_FOO to
> >> +    # insn2.
> >> +    set call_insn {jalrc|[jb]al[sxr]*[ \t][^\r\n]+\r\n}
> >
> >  OK, this should work.  I have a minor nit yet: `[sxr]?' will be more 
> > accurate than `[sxr]*', you want to see the letter at most once.  The 
> > former regexp will likely interpret faster too.
> 
> We want to match JALRS, so [sxr]* is needed here.

 Fair enough, the pattern matches more than necessary, but there are no 
MIPS instructions it would match that it shouldn't, so let's keep your 
proposal as it is for simplicity.  I have no further concerns, thanks for 
your work and for getting through this review.

  Maciej