From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Jan-Benedict Glaw <jbglaw@lug-owl.de>
Cc: Doug Evans <dje@google.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [BUILDROBOT] error: redefinition of typedef ‘record_line_ftype’ (was: [PATCH 3/6] DWARF Two Level Line Tables: check_line_address)
Date: Thu, 28 May 2015 13:58:00 -0000 [thread overview]
Message-ID: <alpine.LFD.2.11.1505281448580.21603@eddie.linux-mips.org> (raw)
In-Reply-To: <20150528092738.GY7864@lug-owl.de>
On Thu, 28 May 2015, Jan-Benedict Glaw wrote:
> > > This patch just factors out the checking of a line address
> > > to improve the S/N ratio of the calling function.
> > >
> > > 2015-03-12 Doug Evans <dje@google.com>
> > >
> > > * dwarf2read.c (record_line_ftype): New typedef.
> > > (check_line_address): New function.
> > > (dwarf_decode_lines_1): Call it.
> >
> > Committed.
>
> Seems it's breaking, see eg. this xtensa-linux build
> (http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=442962),
> or hppa-linux
> (http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=443000):
>
> [...]
> gcc -g -O2 -I. -I/home/jbglaw/repos/binutils_gdb/gdb -I/home/jbglaw/repos/binutils_gdb/gdb/common -I/home/jbglaw/repos/binutils_gdb/gdb/config -DLOCALEDIR="\"/home/jbglaw/build/hppa-linux/_install_/share/locale\"" -DHAVE_CONFIG_H -I/home/jbglaw/repos/binutils_gdb/gdb/../include/opcode -I/home/jbglaw/repos/binutils_gdb/gdb/../opcodes/.. -I/home/jbglaw/repos/binutils_gdb/gdb/../readline/.. -I/home/jbglaw/repos/binutils_gdb/gdb/../zlib -I../bfd -I/home/jbglaw/repos/binutils_gdb/gdb/../bfd -I/home/jbglaw/repos/binutils_gdb/gdb/../include -I../libdecnumber -I/home/jbglaw/repos/binutils_gdb/gdb/../libdecnumber -I/home/jbglaw/repos/binutils_gdb/gdb/gnulib/import -Ibuild-gnulib/import -DTUI=1 -I/usr/include/python2.6 -I/usr/include/python2.6 -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wpointer-sign -Wmissing-prototypes -Wdeclaration-after-statement -Wmissing-parameter-type -Wold-style-declaration -Wold-style-definition -Wformat-nonliteral -Werror -c -o dwarf2read.o -MT dwarf2read.o -MMD -MP -MF .deps/dwarf2read.Tpo /home/jbglaw/repos/binutils_gdb/gdb/dwarf2read.c
> /home/jbglaw/repos/binutils_gdb/gdb/dwarf2read.c:17480: error: redefinition of typedef Β‘record_line_ftypeΒ’
> /home/jbglaw/repos/binutils_gdb/gdb/buildsym.h:177: note: previous declaration of Β‘record_line_ftypeΒ’ was here
> make[1]: *** [dwarf2read.o] Error 1
> make[1]: Leaving directory `/home/jbglaw/build/hppa-linux/build-gdb/gdb'
> make: *** [all-gdb] Error 2
>
> Probably just missed a small part of the patch which removed the
> second definition?
Also mips-linux; any build probably.
The typedef in buildsym.h has to stay, it's already used elsewhere.
It's the newly-added one in dwarf2read.c that has to go. Both are
identical anyway.
Maciej
next prev parent reply other threads:[~2015-05-28 13:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 20:03 [PATCH 3/6] DWARF Two Level Line Tables: check_line_address Doug Evans
2015-05-27 20:28 ` Doug Evans
2015-05-28 9:27 ` [BUILDROBOT] error: redefinition of typedef ‘record_line_ftype’ (was: [PATCH 3/6] DWARF Two Level Line Tables: check_line_address) Jan-Benedict Glaw
2015-05-28 13:58 ` Maciej W. Rozycki [this message]
2015-05-28 16:52 ` Doug Evans
2015-05-28 17:27 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.11.1505281448580.21603@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jbglaw@lug-owl.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).