From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 432 invoked by alias); 24 Jan 2020 19:08:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 423 invoked by uid 89); 24 Jan 2020 19:08:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1104 X-HELO: esa2.hgst.iphmx.com Received: from esa2.hgst.iphmx.com (HELO esa2.hgst.iphmx.com) (68.232.143.124) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Jan 2020 19:08:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1579892930; x=1611428930; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=J97IN6QBZqekglMPtQ3GUEPjQShVoe0ywgiBJZq0McU=; b=E+l/iqpVHFTGhgd3IKj5MrnxC4mWLOr0X2tFO6p8COFWNrDtY3PAxlOk Toe3wYxBSSS4SqdOJYR8nQ0QWZKt4s5aPInzYwUl9OUrNjTUiToJ3jcCp UiGtMj29fUckG3mwwiAH7yrfrFCBaCtgDzxGDQ3A5nWV3On1Z1oHU06eH DPqARk4mJOhcxd90ktsepjZYWi4oUKRJvFB38wWOXgmEkT8v3fgKbLEJq 9fMZMK27gkYKsmRN0xof5NmAYDqTpspS87idFxffHuOv4bZWc4Lmmo+c6 AeKbEcU+7v8+eitQ8D1YmTGHkxlkvbflmS+uXhP1TfcRNlE+Po14Rws9t Q==; IronPort-SDR: uANNfqWJA+YBRsJPxfju9K0riAnXnsrwW+d2HHHW2zHTZ0vU6PS47gYgAIL0K6I75/Pv1qRwe1 2S84KdbF4QawZ0VtkFU6nKoiNCZ9WIY1W5qgCLVKLDQrXzUksIWajMaaIUcvWQWtQe8KOpjssb ZeiLWbSPKsnRNCqGgkqKrL6XjoRPrV1oEJY4AU4cmcuM5oFQ07I4Kk/cetBkIJGreLpUBql9ft yWU/EC2xggiIyW3XVn98rVl0zSof0ns/IDcOIrEl7FvjxTkxyGrxNDhgnKb9d7aUpeFTgHS9hR Hh8= X-URL-LookUp-ScanningError: 1 Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 25 Jan 2020 03:08:37 +0800 IronPort-SDR: /SLWqtRDImDdH1+Lh+3ckAM6e7pepFaoEbz9g5712We0L+pl3Le33QXlfeINXjIJcFPmwLHPM/ uQn441glCXv/X6ojQNqUsYwjFloi4pqVTiNhNdnmfJTe9JEgaWk0FxzEOX2tUwf1EMyuevbUEV 4GiGvPjMc1T3/fx+bGL9neImPucU/ToCF3tP0rOFjwKONUxWxfaAqRcn+T8HmmvqTWywWq6wQJ +CmL3Ij9cMIjOlnXoSZiQq70u+ZQmbsh53irDdecwt6mDVrmGxSzZp+vXEYUHFnApfTUEU66z3 QOrwWzee4d2bp03tJYXtb1CM Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2020 11:01:32 -0800 IronPort-SDR: 72RW2f7dFfp9noQuZDBotj8mYNcCIUepKWoQm6pfVPCmEe0XAxcJlvScj01NGg49KQCbFFlQ9f G9wWQ9rFqFZoICe4C2PHM6IHFPFtj6LW8uiPEyBD+XOcx0tchj1RbT7svBW+gU8y62GNOh+nd0 hNGfQpcJb0cgDO37dbgsdwKKUWySI3TRWtZkmFTK3ua2CINIY7QpLmFcgbNIs2RpCq+l4n0YFN AQdPDeISUq7tUbyyNCHFoaukpHAz2ytpCsHHawq/80j3w4OFzVzkylMb9k8rHL9vIGX9/ffjYy 8/g= WDCIronportException: Internal Received: from unknown (HELO redsun52) ([10.149.66.28]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2020 11:08:10 -0800 Date: Fri, 24 Jan 2020 19:14:00 -0000 From: "Maciej W. Rozycki" To: Tom Tromey cc: gdb-patches@sourceware.org, Jim Wilson , Andrew Burgess , Palmer Dabbelt , guoren@kernel.org, lifang_xia@c-sky.com, yunhai_shang@c-sky.com, jiangshuai_li@c-sky.com Subject: Re: [RFC][PATCH 4/4] gdbserver: Add RISC-V/Linux support In-Reply-To: <874kwlu9xg.fsf@tromey.com> Message-ID: References: <874kwlu9xg.fsf@tromey.com> User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-SW-Source: 2020-01/txt/msg00825.txt.bz2 On Thu, 23 Jan 2020, Tom Tromey wrote: > Maciej> Implement RISC-V/Linux support for both RV64 and RV32 systems, including > Maciej> XML target description handling based on features determined, GPR and > Maciej> FPR regset support including dynamic sizing of the latter, and software > Maciej> breakpoint handling. > > I saw a couple of small nits here. Thanks for looking through my proposal! > Maciej> Also handle a glibc bug where ELF_NFPREG is defined in terms of NFPREG, > Maciej> however NFPREG is nowhere defined. > > In case you haven't already, please report this to glibc. Yep, see: , and the discussion downthread. > Maciej> +/* Implementation of linux_target_ops method "regs_info". */ > Maciej> + > Maciej> +static const struct regs_info * > Maciej> +riscv_regs_info (void) > > We stopped using "(void)" in new code, in favor of just "()". > This showed up in a few spots. Right, I'm pretty much in the C world still; will fix that in the next iteration. Maciej