From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Fix leaks when pruning inferiors.
Date: Thu, 05 Dec 2019 22:30:00 -0000 [thread overview]
Message-ID: <b026af857e9da2aece1a588e92bb5e9aa01bc4cd.camel@skynet.be> (raw)
In-Reply-To: <fca2549c-0600-0cec-a0b3-c7c07e4cc842@redhat.com>
On Thu, 2019-12-05 at 16:42 +0000, Pedro Alves wrote:
> Please declare ss_next here instead of at the top.
> You can omit the redundant "struct" while at it:
>
> inferior *next = ss->next;
> delete_inferior (ss);
> ss = next;
>
> OK with that change. Thanks!
Pushed after fixing the above,
and the ChangeLog message as suggested by Kevin.
Thanks for the review.
Philippe
next prev parent reply other threads:[~2019-12-05 22:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-01 15:52 Philippe Waroquiers
2019-12-05 16:42 ` Pedro Alves
2019-12-05 22:30 ` Philippe Waroquiers [this message]
2019-12-05 16:44 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b026af857e9da2aece1a588e92bb5e9aa01bc4cd.camel@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).