From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2068.outbound.protection.outlook.com [40.107.223.68]) by sourceware.org (Postfix) with ESMTPS id B71D5385B51B for ; Wed, 22 Mar 2023 16:59:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B71D5385B51B Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jLS6reyAmxzJVEYGSk+5NA3Yn95nKfVG20dMqGltH/5J/3DWh5kVTBUCAzDg5uOhqFakGsasD6SI3Y2DxjJEXf6w89450/bYLjAXYbzTWfBE3c2R90TNF+sqYPQy37R9+Y0/OdXupY8qVn+2SoRLOH/HzJxG1kvI2e2qmtzvf1WTp53Ie6WMBusFUTdXFwv4iUXOMbu2IujSJOQTs9u8w6nXvRhSQjLeut21impn8a3d85x2hLHfxfr29ZJjrGkXvD75wrRyF1f6t6MsnzSpSQeR3sAEdKjBUsCN3efa7FdytNUFQO7bqHIn+pu9a81ar2PYoFyY3EEwVuv3w6mSdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hjLxsrFmCQ6H4rW/ha7CS5F5IHVYpziB8dLUfiuK86A=; b=kbdtvbfGw4z4I6s9khmnhGF02/youpOtNCyQ7wksckmg7zCFriBE6/ALkVLEp3GuXmtc6tKYQBBy8O9WY+CrKYgSGgU2rBaitjzU22OalTFdb/zsmsjudqNy+gJl9N4cKcoEdVS36sIm7/Xh0kr8/hiQXONW5qpMdJBJT1nH4XeXR5AiY3xcEoPoVGnYDw7Q74mDixbReaK6TDZx07qvwHH1YTg1zVYLxxvcxQe5IAPtymZbniONqvvVj+Uzf9vJiQDiW3taP73FuYeOq66hWfAKa02ewtojF+jY9xsGnMUSgW+i46Nz+E4fTkdSaVLUBsWAUgt2+FMvAifF1jgPcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hjLxsrFmCQ6H4rW/ha7CS5F5IHVYpziB8dLUfiuK86A=; b=o4ntBGs5p6ebo10rzXGr6fnIO7vwORAxVFHI7HgDavRLqAh5k3/shxMP1fXWiGTc9kt0QInTvDxAJIUzrMEyQsPSVQRA+CV2e964BH05sAjl0AQB5VTq44lsX0jDjTC4GPNWFfw8ecH2aHeisfAlcmr5He3/rFLBc2i7ssua7Ck= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5745.namprd12.prod.outlook.com (2603:10b6:8:5c::7) by DM4PR12MB6278.namprd12.prod.outlook.com (2603:10b6:8:a4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Wed, 22 Mar 2023 16:59:48 +0000 Received: from DM4PR12MB5745.namprd12.prod.outlook.com ([fe80::c964:ca2d:5a4f:fc45]) by DM4PR12MB5745.namprd12.prod.outlook.com ([fe80::c964:ca2d:5a4f:fc45%7]) with mapi id 15.20.6178.037; Wed, 22 Mar 2023 16:59:48 +0000 Message-ID: Date: Wed, 22 Mar 2023 16:59:42 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v6 3/3] gdb/gcore: interrupt all threads to generate core in non-stop targets Content-Language: en-US To: Eli Zaretskii Cc: gdb-patches@sourceware.org, lsix@lancelotsix.com References: <2daa1736-57cb-3c5a-f1cd-48f5aa03d010@simark.ca> <20230322163504.560986-1-lancelot.six@amd.com> <20230322163504.560986-4-lancelot.six@amd.com> <83o7ok68hm.fsf@gnu.org> From: Lancelot SIX In-Reply-To: <83o7ok68hm.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0035.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::8) To DM4PR12MB5745.namprd12.prod.outlook.com (2603:10b6:8:5c::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5745:EE_|DM4PR12MB6278:EE_ X-MS-Office365-Filtering-Correlation-Id: 09515461-a59d-4bbc-e375-08db2af6d81c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uO3v9URPR0le2KAnGi4hIsES8wComoIQqvky7Rm7eEYfGdUXI6bRflgzOyVd2Bkngbloz9sYh7InQgI3tGy1pRFTMsmWxRZ/gl/GGDPYeTv+s+DP+3dcihhP3YuUHVKdR0LLHx4Qb+vJL7ydCaU1OuVT45NWnSP6N2tlEfk4gz+lNLcR2mtaB3QEgudHX1gkYtXYv97MnXx8IVyTwRpVFdfK0Uoz7nN5XU8ooJ5mGpj4LLkXQdxeMW7gNTvSTOkPrsBm+Mvx9N+2IHP4lqeQQmLIhgvFAvjsLvTKLbUwaNmJ+t3qF1Pz1c5j5B24/nOr0nh08HemTW2fjf1vwUtg7cFJq6ZH2V43MBbu6xOIOA56CqmZ0QFP17mTRn8iAvps3y2E5+k8PNJzuFalBxqEmFiRjUgzoWSo5evmD7bhyBNoA79bfJcW8vpShMfhYKI1W7z5QBNg18kHlVSoBmvkmd9KwYOIDatdsTGZgils7GhiJg9wFPHYpsuXGuYsymSIAQtUeegv6C+b4Zcfk+mWyiP3sOghp4djhdtUmhZf7Zhi5L4WtcdxF53H2LAQk0uvyayAxDfEGknST9FTVzp0wXOVXPhaPZHxc73NKJDXvgP8WmQfPF66yUST6WXzQE++7oufHYKSuV9ILrmB885hMxL1vWNpOJwdI7zbLW6+0uvg5JaMFbxhwSoS8a7yqwn39OoX10CB1SvBWEFAjVh5d2lhY9N73AOWSWdXqQeaI/U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5745.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(396003)(366004)(39860400002)(346002)(136003)(451199018)(31696002)(86362001)(31686004)(26005)(6512007)(2616005)(6506007)(6486002)(38100700002)(5660300002)(36756003)(2906002)(6666004)(8936002)(41300700001)(478600001)(186003)(6916009)(66476007)(8676002)(316002)(66946007)(4326008)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFFZTzlxQjY3VmhXRGhhblVvS3ZpcDQxZFZIMWdSM0pVK0huMnZOMzFtNjZN?= =?utf-8?B?cnBQdVNXUXVEWDJ5NnJucVdEUkNCMDRrSDVMZGtMblNoRE5zR3IrYnQ3VWJI?= =?utf-8?B?NkdRMCtPUW5JVnhwRWhBRXAwTlhlWHNhdTdJUU45U28wcm81b3F6blVUTDlW?= =?utf-8?B?UGZ2VCtuSFNqaEptdllKTk5vbVhKNFU0Nk1pZGlLa1JQWGthVWFmeldJbkdq?= =?utf-8?B?b1grTGpFVWFpS0FVMkpCQ1ZVeS9CS2YveE9zaUpvSm5ORmxvczNWY3BFdEZp?= =?utf-8?B?MUZJeW9nWFVHanZPY243Z0FPS0xFcmxKR21QNUl4WDl0T3MrV1NRemNWTW56?= =?utf-8?B?cnZEQUdWbzdOeUUrcHRNT2dkM0N3VzVJUUxsQUFGb2hNemk1RFh3VzhvdHhv?= =?utf-8?B?ZGVIYXlxYnd2dlZwYnMvckt4TkRCRnZiQ0s0aGk3VldNZmZTUkhMQjRlcTZD?= =?utf-8?B?a3hydGhmclBlSW5uUWNuMFI5U1YzeERpbEZuRUwxSUxDOXBud2lwRGFPSEx0?= =?utf-8?B?UXZPNklVY0o0VG04WlZGWHg3RGZRYXZzMXlxNytHVmh6L2szQmFLTFFJTnFF?= =?utf-8?B?TTZ3QTN0c2tPZzZhd1ByYW1JNjIvK25KZGhtRjRLQkRBNjNIRndMUUgxZ3pB?= =?utf-8?B?RTZWMCthaWV2NytSbmExejZVNmhCVnJPcXJZSGhqc2VPOGhDamtDbHJyd0xS?= =?utf-8?B?MEpqTmRKcERjN043MFFLZXhSaGkwa0t4ZnVQaFUySzV1MEQ3NG5BY3BGeVhh?= =?utf-8?B?UFJXaTB0aWl3bEJaKzdlbm4zRXcra3hxSEI0VEljVFpsQlFHcjJ5N3RlZmFI?= =?utf-8?B?dzNNajlqUk5rd0taM0dicEZZNytPQ2M5dmJNZ0dxckRsellqL0JDcGx3d0xI?= =?utf-8?B?VzBoRmJ3YmVNcDkrMGczQncvMGtQd1YrVVlTK25kUm40RmRhUU13cnJFT3di?= =?utf-8?B?dTN6Z1VlTVE5bWtSLzhVSTZPSlZEeS8zL3dST0FZKytqM0FQWTdXNEplOGZh?= =?utf-8?B?SkdOcmhBZDhpUnJuU2NPMnB3djZwTWE3cTNhWTl2cE9RcitJdUNsaFVLYkpu?= =?utf-8?B?RldKcm9uc1lyTlk0d1c2RzJTU3FpMGNiVGxRWXJMMVdZdExreG10MGFESmp1?= =?utf-8?B?T3NDcmhoWklmVmlKQklkazA2NGNUb0t5RjdmQVRMYnRUcHpFSGV2VkNhMEpr?= =?utf-8?B?emM3d2VkOFgrOUEzdDhBOUF2Vnl3blN6YUkrSWowdThaUVl1aUhFRU9Cb045?= =?utf-8?B?dE9YZks3N2pxT21hQ0tscE1aVkJ2LzY3MFl0cWdoVmMyNGRXdUdHNXdJSXNs?= =?utf-8?B?YUF2MlVFY1NVM2ZEb1ZJelAvcUZWdmpBTkppUE9WWTVkdjBjdEhLSnkzRmFm?= =?utf-8?B?TFNPTjM3UkErb1NZUi9QTGp2aS9Hc0hwQ2JVcjB5QXljSmlHdm03UXVSM042?= =?utf-8?B?MWFFcVFQU0dsODJZNDA1aTAvRXFUTGVMNW9XSi9EZGx3QlE1T0RrZnowell3?= =?utf-8?B?Z2JZK2liUTBkR1FPTDNmOXlRK0pLVk1nM0ZYT2wwWWpKTG8zbFA3cFVlNlps?= =?utf-8?B?YjN6S2xxTmRnNkRFQ2NWbncxZmJnRityNy9yeU1UcWNUUkpiaWtJeWVvRnIx?= =?utf-8?B?OENJVHJXanovZlYyMmdOZVA0S2tpaVYwZnZhWXVEMEpIbTMzdE54UVcvaWFE?= =?utf-8?B?WWRjb3hvZjE5MWE4a2JDSTl5eGNyQnlqZFRRWW5wbEZ2SlBYOFZta1NsQTdl?= =?utf-8?B?WTkvSHNxN3Fva2RMeGd5NG05WlpzN3Rrc1d4T3o3WWVvdDVvc2JkaXJOZWtu?= =?utf-8?B?azNVTFRQMEw4MUNHdFE5a1NFdVJsVTJVdStJejJSUXBEV3EycDhNNXJLRGpo?= =?utf-8?B?V0Zjd1gzeWZmdnBiUE9qd2s4QkVKMVplNnRucjArOGpHTGVNWGhyb0p2TndF?= =?utf-8?B?Tkpxa0s1WkdPbUwySExNM0d2KzVBQXRWMDRMN0dsWmpBdkxZaXlYeWdKUmZs?= =?utf-8?B?djZUOTRLU005Q0NBczR0aHBVY0djU0VHT3haYVRzNW9JN1hsM3dkV2t1QXBH?= =?utf-8?B?V082TjZ2Z0JaSEpXcWxPOGtmaUNad2Z1eG5mUnVvQXZZM3dFUmNtci90UEdF?= =?utf-8?Q?Vdz4bU/0mVV/yZZqJKNmoHOSr?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09515461-a59d-4bbc-e375-08db2af6d81c X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5745.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2023 16:59:48.2131 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AJocep31G8zoh/imJfH4nrP4ByL2Yt/HG5YIZJggzk+y9QpcZ17pn1D/DLBd7KQoCAPvF0Ivr6B+DXXmQ/Nd9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6278 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Eli, >> >> +If the current inferior's target is non-stop, @value{GDBN} ensures that > > Please add a cross-reference after "non-stop" to where we describe > that mode. I have done the change locally. This part of the patch is now: diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 6c811b8be2e..00949b4b950 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -13763,6 +13763,12 @@ Produce a core dump of the inferior process. The optional argument specified, the file name defaults to @file{core.@var{pid}}, where @var{pid} is the inferior process ID. +If the current inferior's target is non-stop (@pxref{Non-Stop Mode}), +@value{GDBN} ensures that all the inferior's threads are stopped while +generating the core dump. @value{GDBN} stops every running threads of +the inferior before generating the core dump and resumes them when the +command is done. + Note that this command is implemented only for some systems (as of this writing, @sc{gnu}/Linux, FreeBSD, Solaris, and S390). Best, Lancelot. > > Thanks. > > Reviewed-By: Eli Zaretskii