From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 25FF13858CDB for ; Thu, 18 May 2023 09:02:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 25FF13858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684400528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Is6JVSN2vTf7q0hdzEoU39dv5eqvkCAizJp/aBzKf9M=; b=cCp0nV9ablUHzB60Bbz+oqoX2KhEoSONJxDdm+0zPBNdaEkH4RcyidVo7b74qh2CdLVTbe 4ZSMoWT3M+CWr/kgAZxVBXJk5m1cFWn1YNJWIhv3Ne+1yrA7Gx2I67S5JVxCJQi8BvMe8O p8pq4xrIjJw5d4d0Q4GNWaar6fdkF5o= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-512-gUMDdWjRPOCVoNCveCyZ0A-1; Thu, 18 May 2023 05:02:07 -0400 X-MC-Unique: gUMDdWjRPOCVoNCveCyZ0A-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-307897bc279so1234352f8f.3 for ; Thu, 18 May 2023 02:02:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684400526; x=1686992526; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Is6JVSN2vTf7q0hdzEoU39dv5eqvkCAizJp/aBzKf9M=; b=fytK6C3lAFEsJZzwk9luevAwn7YBHxkQAZFUn4ylnTJpK3YAYeVoRd2jtO5mA+eSb/ JFo36dkxceK72ymXzgNWYYT+EAuFHium84yp6MbGJ50GTJ7NKHQX+JT7qN0KUmgnJju7 5UOliUhaQSMxKHiIcxa2jNfgTzfoZg+n5eAX3sfiUHfQm1F6D22akRdR4QkJ17lOvBCY XVxSKp3SIcSB3UCkmniMXH8B6pnpEUxqXL/01I6J4kbyjjVPXyiU0l8lkwCSnpp29CS1 OrfeOgHdVwcgY2uVW2TdPbdkMAM7tRJ3PBLUblJ4APjl7w3xapkkkR3RwZR4RUsW2qff KaJQ== X-Gm-Message-State: AC+VfDz9RsKkhcbh6z4KvFeshC63xa/0Jg2gHEXSCNT5OF6aQSdlCik+ L3LdprJQ1fW9PvdtjFeJ7CUemj/YV27os9RFkOV2ZjipcXUAdQSd0savrz3xBZLtLoE4A4PLB6o /VHSHLJ63HGnA4etvJYlAIt6p6e0pVA== X-Received: by 2002:adf:ee87:0:b0:307:8126:5e30 with SMTP id b7-20020adfee87000000b0030781265e30mr972836wro.38.1684400526047; Thu, 18 May 2023 02:02:06 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4fvKz4kZhjOD3heRI6wE2TBtpXFcYVZxPuMogrzo0Dq2+UqBeSSq4qi2bAqAsvYfEOlS61GQ== X-Received: by 2002:adf:ee87:0:b0:307:8126:5e30 with SMTP id b7-20020adfee87000000b0030781265e30mr972815wro.38.1684400525672; Thu, 18 May 2023 02:02:05 -0700 (PDT) Received: from [192.168.0.129] (ip-94-112-225-44.bb.vodafone.cz. [94.112.225.44]) by smtp.gmail.com with ESMTPSA id o14-20020a5d408e000000b003047dc162f7sm1466566wrp.67.2023.05.18.02.01.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 May 2023 02:01:56 -0700 (PDT) Message-ID: Date: Thu, 18 May 2023 11:01:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: [PINGv2][PATCH] gdb/testsuite: change hardcoded assembly in gdb.arch/disp-step-insn-reloc.exp To: Bruno Larsen , Bruno Larsen via Gdb-patches References: <20230426132916.1988539-1-blarsen@redhat.com> From: Bruno Larsen In-Reply-To: <20230426132916.1988539-1-blarsen@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping! -- Cheers, Bruno On 26/04/2023 15:29, Bruno Larsen wrote: > When testing gdb.arch.disp-step-insn-reloc.exp with clang in an x86_64 > machine, the compiled test case would segfault when returning from > the function can_relocate_call, with a suggestion of a broken stack. > The example assembly in the commment was the following: > > f: > MOV $1, %[ok] > JMP end > set_point0: > CALL f ; tracepoint here. > end: > > And the segmentation fault happening at the final "ret" instruction of > the original function. This suggests that gcc's compilation process would > realize that no ret instruction ever happened after that call and doesn't > save the return address, while clang's process wouldn't. Looking at the > generated instructions, we can indeed see a difference: > > clang's version: e8 f1 ff ff ff call 11a4 > gcc's version: e8 f4 ff ff ff call 401125 > > Notice the difference on the second byte. > > Changing the assembly to use "ret" instead of "JMP end" does not change > the behavior of the program and guarantees a compiler independent > behavior. This commit does just that. > --- > gdb/testsuite/gdb.arch/insn-reloc.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/gdb/testsuite/gdb.arch/insn-reloc.c b/gdb/testsuite/gdb.arch/insn-reloc.c > index f687c2c5631..365e6180057 100644 > --- a/gdb/testsuite/gdb.arch/insn-reloc.c > +++ b/gdb/testsuite/gdb.arch/insn-reloc.c > @@ -49,10 +49,9 @@ fail (void) > JMP set_point0 > f: > MOV $1, %[ok] > - JMP end > + RET > set_point0: > CALL f ; tracepoint here. > - end: > > */ > > @@ -65,10 +64,9 @@ can_relocate_call (void) > " jmp " SYMBOL (set_point0) "\n" > "0:\n" > " mov $1, %[ok]\n" > - " jmp 1f\n" > + " ret\n" > SYMBOL (set_point0) ":\n" > " call 0b\n" > - "1:\n" > : [ok] "=r" (ok)); > > if (ok == 1)