GDB 9.1 release -- 2019-11-18 Update

GDB 9.1 release -- 2019-11-18 Update

[Joel Brobecker]

Hi everyone,

If you see your name attached to an item, would you mind double-checking
that the status is correct? I'm wondering, for instance, if some patches
might be open on gerrit while a different patch got pushed in the end,
but without the same ChangeId in the revision log (preventing Gerrit
from detecting that the patch was pushed, and thus closing the review).

Here is another update. Sadly, it looks like progress on the specific
items we identified has been slow (1 item moved to the "done" section).

As in the previous update, we can use the "for-9.1" tag to identify patches
that we think should go in GDB 9.1. Here is the URL to the corresponding
dashboard:

    https://gnutoolchain-gerrit.osci.io/r/q/hashtag:%22for-9.1%22+(status:open%20OR%20status:merged

As a quick overview, as of today, we are at:
  - 3 merged
  - 1 pending (I think it will go in soon)
  - 11 patches that no longer apply ("Merge Conflict") :-(

Still Pending:
--------------

  - [Tom DV] Only force INTERP_CONSOLE ui_out for breakpoint commands in MI mode
    https://sourceware.org/ml/gdb-patches/2019-10/msg00099.html
    Gerrit: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/28

    Pedro gave it the OK, but mentioned that he'd like Andrew to review.

  - [Tom DV] Prefer var def over decl
    https://sourceware.org/ml/gdb-patches/2019-09/msg00161.html
    Gerrit: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29

    Tom T said the patch is reasonable, but was wondering whether
    we shouldn't even be in that situation in the first place, if
    we were to not create symbols for declarations...  This lead to
    a different patch, but after discussion, we propose the original
    patch for trunk to start, and then discuss the alternative
    approach after 9.x branching. Joel is double-checking with
    TomT that this is OK with him as well.

  - [Christian B] The threaded symbol loading that tromey Christian have been working on
    Gerrit: https://gnutoolchain-gerrit.osci.io/r/q/topic:%22minsyms-threads%22+(status:open%20OR%20status:merged)

    This patchset was identified as a risk for inclusion so close
    to branching, due to the use of threads for parallelizing
    the load of minsyms. However, considering the potentially massive
    gains to be had on large programs, the consensus was to allow
    this patch under the control of a setting, off by default; and
    then remove that setting once we've branched.

  - [TomT] Fix the "winheight" command
    https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/371

    Fixes a regression.
    Tom says it can be backported after branching if needed.

  - [TomT] Handle pending stops from the Windows kernel
    Gerrit: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/414

  - [TomT] Add pending stop support to gdbserver's Windows port
    Gerrit: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/432

    Fixes an internal-error.

If reviewed and completed in time:
----------------------------------

  - [PhilippeW] [RFC] Have an option to tell GDB to detect and possibly handle mismatched exec-files
    https://sourceware.org/ml/gdb-patches/2019-09/msg00580.html

  - [PhilippeW] Allow the user to define default leading args for commands and aliases
    https://sourceware.org/ml/gdb-patches/2019-09/msg00583.html

  - [PhilippeW] Implement 'print -raw-values' and 'set print raw-values on|off'
    https://sourceware.org/ml/gdb-patches/2019-09/msg00582.html

  - [PhilippeW] More flexible user-defined commands prefixing and naming
    https://sourceware.org/ml/gdb-patches/2019-09/msg00588.html

  - [AndrewB] MI access to some new CLI commands
    Gerrit: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/264
    Gerrit: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/265
    Gerrit: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/266
    Gerrit: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/267
    Gerrit: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/268
    Gerrit: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/269

    Most of these patches already pre-reviewed.

Completed since the last update (2019-11-11):
---------------------------------------------

  - [AndrewB] gdb: Support printf 'z' size modifier
    Gerrit: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/511

    Fixes a regression.

Thank you all!
-- 
Joel

Re: GDB 9.1 release -- 2019-11-18 Update

[Tom Tromey]

Joel> As in the previous update, we can use the "for-9.1" tag to identify patches
Joel> that we think should go in GDB 9.1. Here is the URL to the corresponding
Joel> dashboard:

I added one more today.  It's a small patch that fixes a crash.

Joel>  - 11 patches that no longer apply ("Merge Conflict") :-(

This is actually the normal state due to ChangeLog files.
I just ignore that column.

Joel>   - [Tom DV] Prefer var def over decl
Joel>     https://sourceware.org/ml/gdb-patches/2019-09/msg00161.html
Joel>     Gerrit: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29

Joel>     Tom T said the patch is reasonable, but was wondering whether
Joel>     we shouldn't even be in that situation in the first place, if
Joel>     we were to not create symbols for declarations...  This lead to
Joel>     a different patch, but after discussion, we propose the original
Joel>     patch for trunk to start, and then discuss the alternative
Joel>     approach after 9.x branching. Joel is double-checking with
Joel>     TomT that this is OK with him as well.

I will look at this either today or tomorrow.

Joel>   - [Christian B] The threaded symbol loading that tromey Christian have been working on
Joel>     Gerrit: https://gnutoolchain-gerrit.osci.io/r/q/topic:%22minsyms-threads%22+(status:open%20OR%20status:merged)

Joel>     This patchset was identified as a risk for inclusion so close
Joel>     to branching, due to the use of threads for parallelizing
Joel>     the load of minsyms. However, considering the potentially massive
Joel>     gains to be had on large programs, the consensus was to allow
Joel>     this patch under the control of a setting, off by default; and
Joel>     then remove that setting once we've branched.

I must have missed this discussion.  I saw Christian had a patch to do
this, but I think maybe it can be done more simply... I will
investigate.

Joel>   - [TomT] Fix the "winheight" command
Joel>     https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/371

Joel>     Fixes a regression.
Joel>     Tom says it can be backported after branching if needed.

I'll send a smaller version of this that doesn't involve rewriting all
of the TUI layout code.

Joel>   - [TomT] Handle pending stops from the Windows kernel
Joel>     Gerrit: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/414
Joel>   - [TomT] Add pending stop support to gdbserver's Windows port
Joel>     Gerrit: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/432
Joel>     Fixes an internal-error.

These two are the same series, I'm re-investigating now.

Tom

Re: GDB 9.1 release -- 2019-11-18 Update

[Tom Tromey]

Joel> - [TomT] Fix the "winheight" command
Joel> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/371
Joel> Fixes a regression.
Joel> Tom says it can be backported after branching if needed.

Tom> I'll send a smaller version of this that doesn't involve rewriting all
Tom> of the TUI layout code.

I think it's possible to just cherry-pick the final patch in that series.
So, I'll probably check it in later today, if testing it shows it is ok.

Tom

Re: GDB 9.1 release -- 2019-11-18 Update

[Philippe Waroquiers]

On Mon, 2019-11-18 at 17:12 -0800, Joel Brobecker wrote:
> If reviewed and completed in time:
> ----------------------------------
> 
>   - [PhilippeW] [RFC] Have an option to tell GDB to detect and possibly handle mismatched exec-files
>     https://sourceware.org/ml/gdb-patches/2019-09/msg00580.html
> 
>   - [PhilippeW] Allow the user to define default leading args for commands and aliases
>     https://sourceware.org/ml/gdb-patches/2019-09/msg00583.html
> 
>   - [PhilippeW] Implement 'print -raw-values' and 'set print raw-values on|off'
>     https://sourceware.org/ml/gdb-patches/2019-09/msg00582.html
> 
>   - [PhilippeW] More flexible user-defined commands prefixing and naming
>     https://sourceware.org/ml/gdb-patches/2019-09/msg00588.html
Ping for reviews ?
Thanks
Philippe