From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41472 invoked by alias); 30 Apr 2018 17:05:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41196 invoked by uid 89); 30 Apr 2018 17:05:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=tiny X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Apr 2018 17:05:27 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0969D8DC4F; Mon, 30 Apr 2018 17:05:26 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7121F111AF09; Mon, 30 Apr 2018 17:05:25 +0000 (UTC) Subject: Re: [RFA 3/4] Use new_reference for struct value To: Tom Tromey , gdb-patches@sourceware.org References: <20180430042147.28337-1-tom@tromey.com> <20180430042147.28337-4-tom@tromey.com> From: Pedro Alves Message-ID: Date: Mon, 30 Apr 2018 17:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180430042147.28337-4-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-04/txt/msg00656.txt.bz2 Hi Tom, The series looks fine to me. Tiny comment below. On 04/30/2018 05:21 AM, Tom Tromey wrote: > diff --git a/gdb/value.h b/gdb/value.h > index b58f78998a..060cef5639 100644 > --- a/gdb/value.h > +++ b/gdb/value.h > @@ -88,12 +88,12 @@ struct value_print_options; > > struct value; > > -/* Decrease VAL's reference count. When the reference count drops to > - 0, VAL will be freed. */ > +/* Increase VAL's reference count. VAL is returned. */ "VAL is returned" is stale here. Thanks, Pedro Alves