Re: [PATCH] Avoid harmful fall throughs in core_target::xfer_partial.

[Pedro Alves <pedro@palves.net>]

On 2022-03-17 16:23, John Baldwin wrote:
> On 3/17/22 9:06 AM, Pedro Alves wrote:
>> On 2022-03-16 19:36, John Baldwin wrote:
>>> The cases for TARGET_OBJECT_LIBRARIES and TARGET_OBJECT_LIBRARIES_AIX
>>> can try to fetch different data objects (such as
>>> TARGET_OBJECT_SIGNAL_INFO) if gdbarch methods for the requested data
>>> aren't present.  Replace case fallthroughs with an explicit goto to
>>> the default case.
>>
>> This is OK.  I mean, I think it would be reasonable to instead return
>> TARGET_XFER_E_IO -- it's what the other cases do (notice even TARGET_OBJECT_SIGNAL_INFO
>> doesn't fallback to the beneath target if there's no gdbarch method installed), and the targets
>> beneath (file and dummy) won't be returning any library anyhow.  OTOH, maybe some day we will
>> teach GDB to read the list of libraries the program is linked with and load those before
>> the program starts, and it's conceivable that we would do that at the file_stratum layer.
> 
> I'm happy to do whichever.  I was trying to preserve the intent from when
> TARGET_OBJECT_LIBRARIES was first added.  If there are no beneath targets that
> handle these objects, then I think it probably is cleaner to just fail with
> TARGET_XFER_E_IO for now and let explicit fall through logic be added in the
> future when it is needed.

Fine with me.  Consider it pre-approved.

Thanks.