From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by sourceware.org (Postfix) with ESMTPS id 242B63858408 for ; Tue, 17 Oct 2023 19:21:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 242B63858408 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 242B63858408 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697570469; cv=none; b=lgpOV7KrOcr4zFo+wdvzD2oI2is6bdidri7tHRZOlfey3ddE82QQh1CFn6uFb8q9AKB3QhwzFYuhuw6l3YyTmU5CtB/PNHUA9ZtaKOouMwGCwQf4WKdz/M/fqIDl7hO6GNaUIcK1bIduq3av8l6l5wNSCUoCpPBF6mu6Jb0uttA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697570469; c=relaxed/simple; bh=EV3qk31UEDyk9y6wGAYxUZYFMcvPXFyWxrsASGEyi28=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=JPSYZcQvw6UdkfcsQYV3irPuDyqUSm7428DNXOMAUZyFRPfyfEuj8rRRGl5lffFWaSgpJ10RUeif/QydA0LFuZtSFe2vAljLk5+gU5K1gsPf6xNfgv/zAE4FK2NssFRawkbmX7cpt/zA31bshaVlc2lbrongsLCnKqJ+EBypHc4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4064876e8b8so63102485e9.0 for ; Tue, 17 Oct 2023 12:21:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697570463; x=1698175263; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6y3qC0Kk7o8Bf1TJ9XwzF2s+Lofmsj/pQ/AEMfMD+CI=; b=BOsho+lxITzFMIFcoP6NHIZKpA+Vd1qcWCvVIaT2X59V+GXIrZkUZv0LqtU/Yv0v4E 5THD4DHnUDCMXGWEdjRruIgfp4ZpCzwy1Tzu6R6MEaF5xSmc2E8olBQyQyUdsakpDeqf HQYSWm5FzfsJT+/8iNL6CSCTB9mKEnXguGukBRJDDA1XI3fugM4pqAm9Mpm2TmQcgO5M X3q92jSi8W9vf29mTYV+RG+gAguisaMB7lgQLlPSkYFIby+RxUzZ9DJ6d9FdxWLJLmbn zm1z5YD0XVHjvTlSyuhDdjdVYxMvgg3KUPu+QuJkjDQaUJV5ICBbR5LBI9ny49TcDF/M H7Dg== X-Gm-Message-State: AOJu0Yz9/p09Y6OnIFj5fkZJcet/CP8DvfJUDQpG9uAEEicykAPHBBgC bA8jw9T4uuoXnzauryGJgjSHMJ6kYkacSg== X-Google-Smtp-Source: AGHT+IF16jEIx4qtlQDiRk7HuUBVzZ9Vn1l+qmiMSyStqrT5DPQLGz/7Ak/VTysdOTGx0TlEaFafOA== X-Received: by 2002:a5d:590f:0:b0:323:16c0:9531 with SMTP id v15-20020a5d590f000000b0032316c09531mr2596548wrd.13.1697570462837; Tue, 17 Oct 2023 12:21:02 -0700 (PDT) Received: from ?IPV6:2001:8a0:f939:d200:5aaf:ade2:476b:3ff2? ([2001:8a0:f939:d200:5aaf:ade2:476b:3ff2]) by smtp.gmail.com with ESMTPSA id k1-20020a5d66c1000000b0032dbf99bf4fsm400475wrw.89.2023.10.17.12.21.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Oct 2023 12:21:02 -0700 (PDT) Message-ID: Date: Tue, 17 Oct 2023 20:20:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/24] C++ification of struct so_list Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20231010204213.111285-1-simon.marchi@efficios.com> From: Pedro Alves In-Reply-To: <20231010204213.111285-1-simon.marchi@efficios.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-10-10 21:39, Simon Marchi wrote: > This series modernizes the struct so_list area by C++ifying it a little > bit and replacing the manual linked list implementation with > intrusive_list. It also contains a few other cleanups written along the > way. Very nicely split. Thanks. I sent a few comments, but nothing too serious. The only thing on my end that requires some churn is the pointer vs reference thing in the disposer. Otherwise, all LGTM. Oh, I did notice that "struct so" ends up as an ungreppable/unsearchable name, and wondered whether that is going to make our lives harder in practice. Maybe we should consider renaming it to "shared_obj" or "shobj" or something easier to grep. Or maybe it doesn't matter. But no real strong opinion, I think I'm OK with "so" too.