From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 5AC443858C78 for ; Wed, 6 Sep 2023 12:46:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5AC443858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 386Ck69W019416 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 6 Sep 2023 08:46:10 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 386Ck69W019416 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1694004371; bh=AoEhDi1aJBzN44+plxC9HMAnoLF5pvFJRqM/xQGjaO0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=fna2WyqfZ/oH48y2JpKqiUO5N+tVEJz66UkeI8rLvgsNZh9fJQ2EH5e0eJcH7Okrq RRC4ug46vwGU4is5cuHvhGcMulmzDJWPiPQKssen4SLMXSsRu/SqX4QH1pkheJMwM8 SwdjwmmTr98vv5uC5sJOXdN050nIz0/+0mTuWlnA= Received: from [10.0.0.170] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D921B1E092; Wed, 6 Sep 2023 08:46:05 -0400 (EDT) Message-ID: Date: Wed, 6 Sep 2023 08:46:05 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] gdb, btrace: move xml parsing into remote.c Content-Language: fr To: Markus Metzger , gdb-patches@sourceware.org Cc: vries@gcc.gnu.org References: <20230906074727.426831-1-markus.t.metzger@intel.com> From: Simon Marchi In-Reply-To: <20230906074727.426831-1-markus.t.metzger@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 6 Sep 2023 12:46:06 +0000 X-Spam-Status: No, score=-3031.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/6/23 03:47, Markus Metzger via Gdb-patches wrote: > The code is only used in remote.c and all functions can be declared static. I think this is fine. Approved-By: Simon Marchi Simon