From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailsec116.isp.belgacom.be (mailsec116.isp.belgacom.be [195.238.20.112]) by sourceware.org (Postfix) with ESMTPS id 24E713858D1E for ; Sat, 19 Nov 2022 14:52:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 24E713858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=skynet.be Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=skynet.be DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=skynet.be; i=@skynet.be; q=dns/txt; s=rmail; t=1668869539; x=1700405539; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=vDnPXLEXKNBTpbqxxUPmbRGcXjgnlqqx9rOcOBUaLx8=; b=MhKCT2pOJtHUHJiiOuyvk94AgHfgfamqCS36t7/cwYb6JCb1g2l6WEL5 8ApTEKbIm8Djg6jolzesCFV4fB0fOxMHPWOIq107G3jQQN2pmitEfhjXZ eiYPAYfL7DyM5B8ZtrkiyQ8syvckuRHCO0hj4+3Rosyo1tiVj3x0Smu7x w=; X-ExtLoop: 1 X-IPAS-Result: =?us-ascii?q?A2DdAAAl7Hhj/1uGgG0NTYEJCYFGiVeRHZFci1WBfg8BA?= =?us-ascii?q?QEBAQEBAQEJRAQBAYUAAwIChQImNAkOAQIEAQEBAQMCAwEBAQEBAQMBAQYBA?= =?us-ascii?q?QEBAQEGBAGBG4UvgnspAYN1AQEBAyMECwFGEAkCDQsCAiYCAlcGAZs2mx16f?= =?us-ascii?q?zMaZ4RxmmWBZ4EULIFmhxqDYIQwN4FVRIJRgW4+iBuCRSIEjDeLKBw3AxkrH?= =?us-ascii?q?UADCzsyDUobWA4JHxwOFw0FBhIDIGwFCjcPKC9nKxwbB4EMKigVAwQEAwIGE?= =?us-ascii?q?wMiAg0pMRQEKRMNKydvCQIDImUFAwMEKCwDCSEfBxYRJDwHVjoBBAMCDyA4B?= =?us-ascii?q?gMJAwIiVXUuERUFAwsVJQgFSwQIOQUGUxICChEDEg8GJkUOSD45FgYnQgExD?= =?us-ascii?q?g4UA16BaQQ1gXEKnAxjGBQbgljCMzQHg2uBRwYMnnsylxgDkXuXNCCnWIFig?= =?us-ascii?q?hVtgztRnRmBLwIHAQoBAQMJiAstgikBAQ?= IronPort-PHdr: A9a23:QkSL0R+sRhHn6f9uWdi7ngc9DxPPW53KNwIYoqAql6hJOvz6uci4Y AqCv74z3BeJBdydt6gfzbKO8ujJYi8p2d65qncMcZhBBVcuqP49uEgeOvODElDxN/XwbiY3T 4xoXV5h+GynYwAOQJ6tL1LdrWev4jEMBx7xKRR6JvjvGo7Vks+7y/2+94fcbglWizexe7N/I Au5oQjQtcQdnI9uJrosxhfTrXZEZepbyXl0KV6Pmhr3+9u98oNk/ylMofwq6tROUb/9f6Q2T LxYCCopPmUo78D1thfNUBWC6GIEXmoZjhRHDQ7F7ArnXpjqqSv1qvB92CiBMsLoS70/RCmv4 L1qSB/sjycHKiI5/WTKgcF+kK5XvBSsrAFkzoXKfI+aKuZxfqLFfdMbW2VBWNpRVzdcCY+4d ocDEvYNMfpdo4T7ulAArwaxBRO0Ce3s1zFGhmH40LM03esjHwHJwAIvEN0BvnnPsNX4N70fX fypwKTSzzjOae5d1zfn6IjPdxAsueuCXbJxccrVyEkvDxvFgUuNooPlJTyVzOMNs3GG7+phS +2vkXUnoBx2rzi3xscsi43JhoMNylDc6yp12og0KseiSE58eN6kDZpQuD+AN4ttWc4iWGJou SY8yrIYpZ63ZjMFx4o+yhPZdveIfJSG7Aj5W+aNPTd3mmhleLSnihu27USuyvHxW8i13VhFs CZIndnCu3QC2hHR6MWKSftz8lq91DqS1g3e9OFJLEQomKbGNpMvzbA+mocdvEjdGiL7nlj9g qyOdkg85+Sk9+Dqbq/7qpOCNIJ4kBzyP6ohl8ClBek0Lw4DVHWB9+umzr3s50j5Ta1Pjv0xj 6bWrojXJd8epq6lGw9V1Zsj6wqnAzemztsYmX4HIUpBdx6ai4XlJUvCLO35APq8mVigjS1ny +3CM7LnGpnNL37Dn6n9fbtl9kJQ1A4+wcpC655KCbwNOu//V0H+udDCChI1LhS4w+P9B9V80 oMeV3iPAqicMK7KqV+I5uMvI+2NZI8NoDbyNeIp5vD0gn8jnl8dZLSp3ZoJZ3CiBfRrOF6ZY Xnsg9cHD2gKohAyQ/f0h1GaVz5cfG69X7gg6TEjFIKmEYDDS5ijjbCZxie0AoVWZnxaClCLC XrnbJ+EW/AXZy2MPsBhkSILVaK6RoA7yB6hrhP1y719LuXK4CEXqZXj1N1t6+3JiR4y7SB0D 9ia02yVQGF7g3gHSyYu3K9lvUxy1leD3rZjg/FDDtxT4O5JUh0mOpHCwe11EcryVRzbcteOU lamTc2qASstQdIp398Of0F9Fs2+jhDZ2CqqBqEalryQCZMu763TxWT+J8Fny3nYzqUuk14mQ s4cfVGh04x4+gybLZTOmUiSlKuwPfAWxinH+WyAwHCmtU1RWwlqXOPOWnVJIgPqqtGx2lnFS rK/QaomO0NuxcTHMqJWYd3klh0SS/vpfczXf2mxlnyYHhGV3LiBc4PwdiMaxiqLW2YelAVGx XaHMQkmHirpnGvECyVzFF/1eAu46el/rHKjVkJy0AiQaFR81rev4TYOhu2aRu9V1L9S63Rpk Cl9AFvoh4GeMNGHvQc0OfwEObsA IronPort-Data: A9a23:H+lQ7qNmbnRyNurvrR3ClsFynXyQoLVcMsEvi/4bfWQNrUoq0TdTz zYcUD+GaauJZmf9Ldgkaty2oR5S78eDnNNnS3M5pCpnJ55oRWopJjg4wmPYZX76whjrFRo/h ykmQoCcappyFxcwnz/1WpD5t35wyKqUcbT1De/AK0hZSBRtIMsboUsLd9UR38g537BVPyvX4 Ymo+pSGaQf/s9JJGjt8B5yr+UsHUMva5WtwUmwWPZhjoFLYnn8JO5MTTYnZw6zQG9Q88kaSH o4v/Znhlo/r105F5uCNzt4XRnY3rov6ZmBivJb5t5+K2XCurgRqukoy2WF1hU1/011llPgpo DlBWADZpQoBZsXxdOohvxZwLhx7DKl51YX7eHGnmMCv9FKcayfF6qA7ZK02FdVwFudfMjgfr 7pBdmBLN1ba1tfeLLCTE7E9wJ15fI+yZ99Z6ygIITLxVJ7KRbjbQ6TO5MdA0XEvj9pJBOvfa tACQSFsfRLNf1tFNz/7Dbpnxrf43yaiImQwRFS9mJo8/mnO11VK9bngEYLZVMOred1npxPNz o7B1yGjav0AD/SV0z2P/3mvi/XnlC/yU4UIGfuz8fsCqFKfzCkLAQEdVVagieK+l1S1Vs1WM UFS/TAhxYAu7kuuQ8jVVhGxq3mes1gXXN84LgEhwFjVm+yNuVbfXzNYCG8YADA7iPILqfUR/ gfht7vU6fZH6tV5lVr1GnyoQf9e9MTbwaLupcPJcOfd3+TenQ== IronPort-HdrOrdr: A9a23:tY8hIaMmvDmkScBcT7v255DYdb4zR+YMi2TDiHoedfUFSKOlfp 6V8MjzjSWE9wr5K0tQ5+xoWZPwDk80kKQV3WB/B8bYYOCLghrLEGhC1/qa/9SkIVyDygc/79 YvT0EdMqyLMbESt6+Ti2PUc6dC/DDEytHUuQ639QY0cegAUdAF0+4NMHf8LqQAfnggOXNWLu v42uN34x6bPVgHZMWyAXcIG8LZocfQqZ7gaRkaQzY69Qinl1qTmf/HOind+i1bfyJEwL8k/2 SAuRf+/L+fv/ayzQKZ/3PP7q5RhMDqxrJ4dYyxY4kuW3bRYzSTFcFcso65zXQISSaUmREXee z30lUd1gJImjXsly+O0ELQMkLboUcTAjfZuC+laD3Y0JfErUkBerJ8bUgwSGqC16Li1OsMjZ 6ipQiixsVq5UirplWi2zCNPCsaxXZdZBIZ4LIuZ7g2a/pOVFeXxbZvrH+9Wa1wbh4T5O0cYZ pTJdCZ6/BMfVyAaXfF+mFp3dy3R3w2WgyLW04Yp6WuonJrdV1CvgMlLfYk7zw93YN4T4MB6/ XPM6xumr0LRsgKbbhlDONERcesEGTCTR/FLWrXeD3cZe06EmOIr4Sy7KQ+5emsdpBNxJwumI 7ZWFcdsWIpYUrhBcCHwZUO+BHQR2e2Wyjr16hlltVEk6y5QKCuPTyISVgoncflq/IDAtfDU/ L2I55SC++LFxqmJW+I5XyJZ3B/EwhobCROgKdPZ7unmLO+FrHX X-IronPort-Anti-Spam-Filtered: true X-ProximusIPWarmup: true Received: from unknown (HELO [192.168.1.19]) ([109.128.134.91]) by relay.proximus.be with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2022 15:52:18 +0100 Message-ID: Subject: Re: [PATCH] Fix crash in "document" command From: Philippe Waroquiers To: Joel Brobecker , Tom Tromey via Gdb-patches Cc: Tom Tromey Date: Sat, 19 Nov 2022 15:52:17 +0100 In-Reply-To: References: <20221118160547.1336252-1-tromey@adacore.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, 2022-11-19 at 16:24 +0400, Joel Brobecker via Gdb-patches wrote: > Hi Tom, > > On Fri, Nov 18, 2022 at 09:05:47AM -0700, Tom Tromey via Gdb-patches wrote: > > PR cli/29800 points out that "document" will now crash when the > > argument is an undefined command. This is a regression due to the > > "document user-defined aliases" patch. > > --- > >  gdb/cli/cli-script.c | 2 ++ > >  gdb/testsuite/gdb.base/document.exp | 4 ++++ > >  2 files changed, 6 insertions(+) > > > > diff --git a/gdb/cli/cli-script.c b/gdb/cli/cli-script.c > > index 2442f7ae38b..2101d6fface 100644 > > --- a/gdb/cli/cli-script.c > > +++ b/gdb/cli/cli-script.c > > @@ -1515,6 +1515,8 @@ do_document_command (const char *comname, int from_tty, > >    validate_comname (&comname); > >   > > > >    lookup_cmd_composition (comfull, &alias, &prefix_cmd, &c); > > + if (c == nullptr) > > + error (_("Undefined command: \"%s\"."), comfull); > >   > > > >    if (c->theclass != class_user > >        && (alias == nullptr || alias->theclass != class_alias)) > > diff --git a/gdb/testsuite/gdb.base/document.exp b/gdb/testsuite/gdb.base/document.exp > > index 2d8f6b88090..6f426510d29 100644 > > --- a/gdb/testsuite/gdb.base/document.exp > > +++ b/gdb/testsuite/gdb.base/document.exp > > @@ -28,3 +28,7 @@ gdb_test_multiple "define do-document" "" { > >  } > >  gdb_test_no_output "do-document" "invoke do-document" > >  gdb_test "help do-document" "usage: do-document" "invoke help do-document" > > + > > +# Test that document of a non-existing command prints an error. There > > +# was a regression at one point causing this to crash. > > +gdb_test "document nosuchcommand" "Undefined command: \"nosuchcommand\"\\." > > Thanks for the fix. This looks good to me! > I also took a look, thanks for fixing the regression Philippe