public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Ajit Kumar Agarwal <ajit.kumar.agarwal@xilinx.com>
To: Michael Eager <eager@eagercon.com>,
	"gdb-patches@sourceware.org"	<gdb-patches@sourceware.org>
Cc: Vinod Kathail <vinodk@xilinx.com>,
	Vidhumouli Hunsigida	<vidhum@xilinx.com>,
	Nagaraju Mekala <nmekala@xilinx.com>
Subject: RE: [Patch, microblaze] Add little-endian breakpoint
Date: Wed, 17 Sep 2014 08:48:00 -0000	[thread overview]
Message-ID: <b2015e46-4d91-42cc-bd39-889b9bbac826@BY2FFO11FD014.protection.gbl> (raw)
In-Reply-To: <53D00167.4070606@eagercon.com>



-----Original Message-----
From: Michael Eager [mailto:eager@eagercon.com] 
Sent: Thursday, July 24, 2014 12:10 AM
To: Ajit Kumar Agarwal; gdb-patches@sourceware.org
Cc: Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala
Subject: Re: [Patch, microblaze] Add little-endian breakpoint

On 06/16/14 12:02, Ajit Kumar Agarwal wrote:
> Hello All:
>
> The following Patch add the little-endian breakpoint.
>
>   [Patch,microblaze] Add little-endian breakpoint
>
>      Add little-endian breakpoint.
>
>      ChangeLog:
>      2014-06-16 Ajit Agarwal <ajitkum@xilinx.com>
>
>          * microblaze-tdep.c (microblaze_breakpoint_from_pc): Use
>          of gdbarch_byte_order. Initialize break_insn_le to
>          MICROBLAZE_BREAKPOINT_LE. Check byte_order with
>          BFD_ENDIAN_BIG.
>
>          * microblaze-tdep.h (MICROBLAZE_BREAKPOINT_LE): New Macro.
>
>      Signed-off-by:Ajit Agarwal ajitkum@xilinx.com

>>Please update this patch to add a test case to the gdb test suite.

The existing gdb testsuite if compiled and tested with little endian binaries will fail.
Hence the existing testsuite is sufficient and we don’t see a need for a new testcase.
 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077

  reply	other threads:[~2014-09-17  8:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-16 19:02 Ajit Kumar Agarwal
2014-06-17 16:36 ` Tom Tromey
2014-07-23 18:51 ` Michael Eager
2014-09-17  8:48   ` Ajit Kumar Agarwal [this message]
2014-09-17 14:09     ` Michael Eager

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2015e46-4d91-42cc-bd39-889b9bbac826@BY2FFO11FD014.protection.gbl \
    --to=ajit.kumar.agarwal@xilinx.com \
    --cc=eager@eagercon.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nmekala@xilinx.com \
    --cc=vidhum@xilinx.com \
    --cc=vinodk@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).