From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 77CEC3858C39 for ; Tue, 7 Mar 2023 15:20:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 77CEC3858C39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 182F81E128; Tue, 7 Mar 2023 10:20:13 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1678202413; bh=+dOpbWT74W+y/ENLnkfa15NlNrCq8qp1aFffCbDtdj0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=LWqtBCEySdYuq6ctQN3QWoJfcOblc00QKHmzbaTe8/ipmCVUfBl6M5LeHnGKGJmf/ V2kweP8drIVFM03RjFmyJ7u2dBvRVsN+eiB6gTAIvGHY83jBSudDnfxIvJXGfJ8y5+ HZFeUpFTfFVDdSleROfHJJ+jsDyI1yZgvyYH7QKA= Message-ID: Date: Tue, 7 Mar 2023 10:20:12 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCHv2 4/5] gdb/gdbarch: remove the 'invalid=None' state from gdbarch_components.py Content-Language: en-US To: Tom Tromey , Andrew Burgess via Gdb-patches Cc: Andrew Burgess References: <7452e65c89feea14efa71eb0272e00c2e68f6afd.1678116328.git.aburgess@redhat.com> <87o7p4sia1.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87o7p4sia1.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/7/23 10:17, Tom Tromey wrote: >>>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: > > Andrew> --- a/gdb/gdbarch_components.py > Andrew> +++ b/gdb/gdbarch_components.py > Andrew> @@ -1675,6 +1675,7 @@ BFD target to use when generating a core file. > Andrew> predicate=True, > Andrew> predefault="0", > Andrew> printer="pstring (gdbarch->gcore_bfd_target)", > Andrew> + invalid=True > > Super nit, but it's better to have a trailing comma here, because it > means that future additions can be done without touching this line. Actually, black adds it automatically in this case. Simon