Re: [PATCH v3 00/11] Improve Fortran intrinsic types and procedures

[Luis Machado <luis.machado@arm.com>]

Hi,

On 4/11/22 09:18, Nils-Christian Kempke via Gdb-patches wrote:
> Hi,
> 
> please find attached v3 of the series.
> 
> V1 can be found here
> 
> https://sourceware.org/pipermail/gdb-patches/2022-March/186473.html
> 
> V2 here
> 
> https://sourceware.org/pipermail/gdb-patches/2022-April/187655.html
> 
> Changes since V2:
> 
> 	- [Patch 11/11]: Fixed Texinfo issues.
> 
> 
> Thanks!
> 
> Nils
> 
> 
> Nils-Christian Kempke (11):
>    gdb/f-lang: add Integer*1 to Fortran builtin types
>    gdb/f-lang: remove hidden ^L characters
>    gdb/fortran: fix complex type in Fortran builtin types
>    gdb/fortran: reformat build_fortran_types in f-lang.c
>    gdb/fortran: change default logical type to builtin_logical
>    gdb/fortran: clean-up Fortran intrinsic types
>    gdb/fortran: Change GDB print for fortran default types
>    gdb/fortran: rename f77_keywords to f_keywords
>    gdb/fortran: rewrite intrinsic handling and add some missing overloads
>    gdb/fortran/testsuite: add complex from integers test
>    gdb/doc: add section about Fortran intrinsic functions and types
> 
>   gdb/doc/gdb.texinfo                         | 143 ++++++-
>   gdb/f-exp.h                                 | 182 +++++++--
>   gdb/f-exp.y                                 | 397 ++++++++++++++------
>   gdb/f-lang.c                                | 267 +++++++++----
>   gdb/f-lang.h                                |   7 +-
>   gdb/std-operator.def                        |  10 +-
>   gdb/testsuite/gdb.fortran/complex.exp       |  10 +-
>   gdb/testsuite/gdb.fortran/complex.f90       |   7 +-
>   gdb/testsuite/gdb.fortran/intrinsics.exp    |  46 ++-
>   gdb/testsuite/gdb.fortran/lbound-ubound.F90 |  49 ++-
>   gdb/testsuite/gdb.fortran/lbound-ubound.exp |  29 +-
>   gdb/testsuite/gdb.fortran/size.exp          |  84 ++++-
>   gdb/testsuite/gdb.fortran/size.f90          | 213 ++++++++---
>   gdb/testsuite/gdb.fortran/type-kinds.exp    |   2 +
>   gdb/testsuite/gdb.fortran/types.exp         |  34 +-
>   15 files changed, 1160 insertions(+), 320 deletions(-)
> 

I'm running into an internal error after this series when running 
gdb.fortran/intrinsics.exp on 32-bit arm Ubuntu 18.04.

We're failing this particular assertion in eval_op_f_cmplx:

gdb_assert (kind_arg->code () == TYPE_CODE_COMPLEX);


kind_arg->code () == TYPE_CODE_ERROR. I see gdb/f-lang.c initializing 
some types to TYPE_CODE_ERROR if they're not supported. Should we fail 
gracefully in this particular case?