From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80074.outbound.protection.outlook.com [40.107.8.74]) by sourceware.org (Postfix) with ESMTPS id 3CAE43858430 for ; Mon, 25 Apr 2022 12:52:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3CAE43858430 Received: from AS8PR04CA0110.eurprd04.prod.outlook.com (2603:10a6:20b:31e::25) by DBAPR08MB5829.eurprd08.prod.outlook.com (2603:10a6:10:1a9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Mon, 25 Apr 2022 12:52:34 +0000 Received: from AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:31e:cafe::26) by AS8PR04CA0110.outlook.office365.com (2603:10a6:20b:31e::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.21 via Frontend Transport; Mon, 25 Apr 2022 12:52:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT015.mail.protection.outlook.com (10.152.16.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.19 via Frontend Transport; Mon, 25 Apr 2022 12:52:32 +0000 Received: ("Tessian outbound 9511859e950a:v118"); Mon, 25 Apr 2022 12:52:32 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 8b357fa45340d864 X-CR-MTA-TID: 64aa7808 Received: from d06c96516f1e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8F36BDC1-7EE6-4F32-BF76-C4CA7EF65207.1; Mon, 25 Apr 2022 12:52:26 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d06c96516f1e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 25 Apr 2022 12:52:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i3gMcDBxSWYIbIKkmSNVAbMJQ9khDvU2Hrhc2BKptFQFrSm8H0EwNs6DE8t8lkdSBe2R1zC9CcborLCYKxGCIS/G6wTA7Fy/cShIlDUuqvFGa7pakjDT+mRImEcmkLDd8K5QUfYCYgHDp9yOFE6reY/ngLTRl7yAj1ymhN6nONnqRPBfp8SsNcTzqPk9XnHAHIO5nHWGoUEBQeSkuh+PwxAurWARwgfIiERVmDYi3cUzp0cd2L5I5mg7TRIrM9Wta8dtnxcmFWme91/SSksDu/YBz2eaCUHR6iSaWrgbto9rN6EjAK8ZzUlkrODYXCB8brwVpB60fCIItaA0sC4U9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oIOfZm3Gt9ArrbbWwaYBoKI3BEKezrT+5vagP/SPhJE=; b=evTI4jMzo3n04vbIH+mrb6JdQHj7FgSINZ+5S1FVII5NuoyarPLUlw/EHQtqQlP860ULPrmfQuoSb76eJCe/BHBxkd/ZOYk4N3n6gBzW9HRVOlw8CHPVGQ5UP4YO5WGUl+NxQivtlusY7fi1IGQAoAYRLmJEEuR+6FNCPAFBALwLAZD8+bsX2fMBV01MrMl7jVUa91utX1iFCQttPrkdK2X4MSAhyd2QoZxnapcYc8NYByhAhC/AadmRxXzmw2a0aw6xyPZqRowzD3GTqYuqysZukhU96Dd7Mdsz+SXnNjvovJ6Na/b1/F2EOyoDeb7yYPapaiktWQHE5A1WYx0OcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AM5PR0801MB1636.eurprd08.prod.outlook.com (2603:10a6:203:3a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Mon, 25 Apr 2022 12:52:21 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6%7]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022 12:52:21 +0000 Message-ID: Date: Mon, 25 Apr 2022 13:52:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v3 00/11] Improve Fortran intrinsic types and procedures Content-Language: en-US To: Nils-Christian Kempke , gdb-patches@sourceware.org References: <20220411081859.459151-1-nils-christian.kempke@intel.com> From: Luis Machado In-Reply-To: <20220411081859.459151-1-nils-christian.kempke@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0082.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::15) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: bb04b856-df0f-4ad1-5b1a-08da26ba771a X-MS-TrafficTypeDiagnostic: AM5PR0801MB1636:EE_|AM5EUR03FT015:EE_|DBAPR08MB5829:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: u1zKKzfTSHGLZthQymsxB8X5CGEm5musk+tT3bci98vzPdrd4fwomYhSteCs4dkxR+nbzb/ICXDzaJRPlDA+YVUHJKCvJCK/3pb2X5TmvGcVcu2t0jYSuxo3Qcamav3eOVqfDmADBXeUZu4OhKRfMktmB9j5ziGQ7zGAR/qJVYYlKXQ1cfu1tA5AXEWcKRdMKtdZWFbXJJ63ODLf5JGX03ujWH+VlN+yQZI1oquFvrRDoAAP9zXRRrpMTyiKa+JrPe05xQrV9PPcr5SziYB1Ed1LQJmV9Ufhv+KdjnNOk4vNDP0nV4jPVp4a9MwhHVT9xG4s3DlsWFo3S/qP2YDIp8/uVTukLRWlg3JnWFXSELDCFAINm4gIAl91D4vwM1VYohnOpM0btZWDPAHS+P105LjcxHPdufCT0t/25CQ0o52LKHS0DLCAm3FCvr/DCynWwmk//9HgQVbhwH4ZntuyFf5XOXvwgpSn7amNLx3zNRWKJ1oVez2a+OCHECJAuiQUMQTd5zMsIJi2oHu+Rv2vLPO+E6ypCsLWcFPeOiZTxICwuWusuKinVoANcS+hitot7fZvOn/lleKFyHfiedxdQtRPBYo4meuRDU+lJaPFfomU+rBs6tZbUAx3IMMOwBf271JFSFhKG7Kpa2oYW99QrqqlTufPaNKw6AnQOoMh06jze+9E4s4um58e2haVA0Stf/js4NQtjSZf15f3HyOXJzTmDGPjGaDzZISHbbsGBS5vsreZuF54CRh2+5Ltm44phn64O2ymDYtfj9OEspn2vHx83afbeQNAWBJ6DWW981qPdAxmg7Kc/xC9+GlriK+Aos2y3/6WZBzhZR62890g+prwapVp+qTx/rmZyyHr6Y4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(508600001)(186003)(2616005)(66946007)(66556008)(8676002)(66476007)(84970400001)(6506007)(26005)(53546011)(6512007)(966005)(316002)(36756003)(6486002)(31696002)(2906002)(86362001)(31686004)(8936002)(44832011)(5660300002)(83380400001)(38100700002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1636 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 71da2da7-ef47-4c3c-5141-08da26ba6fdc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 27fMJI/6xMWL0j2l91iHdWkTbpIOXxquB4DJrHvjtwttKGSDdQ8ABwzDzx74jFFYb6/rcd4W46iFOxiT7VIK+3BpWQmP7zIvdAE4x55EfmR5n/ATUvqGNzBKBCTqQEzJneep5XJIatstvJNYnjX/IAFII8zst4DdgfYDkqoRFdG/VgteJVceG3K+oSfKBtip3MtSFaK+1+RK22K953PlHNmrBw4g+RGKLpoMsYOJP+Plt9FBIuKTjAHyEHEEHDI38eX+P9OLxfuAt1NdaaigF7Ij28fuHtR75pahtkKs64sIFUhryxGHUvT5gdefmRq13MjwEbfDajeX8xQJCo2RdyEZsaRUp1u45dFGFY6PS8cwMafyxeNUyAACVcsOPLDA9aBq4T6DD5nNmi4LLSBsHZg+fP3qyX64q41lPbmc49P6hz3u8keQ+3DyPKA9DM93UjRyr+0h8oXbIzslgNV0+EMKHWdHcHoPnnCg65RddR7yRBRD55eg7IYxnJztfOqEdL6U/OZsN26XtG/uo12sqO73mZjc61CODv35Z9f9lNBAh4hXw3jptAFB1IQiRupSnqUhCvkdyvH7yzcVvlomdgdC/TAZE6DJSIME5OTIHPujvl8FO9yzzdfwD4ffOQKaIFR2KziPwd0oaNIFusHMBI4a3xdfu5oqOBnOAE3S3j4yGMGDy2klRuHzH9aVWqEUiZ+MaG9t/bcIOzmeCnc9mALPOHDoFTYFFqCkCg5NfuV5nRNTS0xiDHdx/+O2Euu+w4aFERDdJxwq/I9Z5OlFHRHQps8H3cvJNXtpG12YqswqUKR49qJLM9Ig6nDEJfoKf37yvWuqWusL32OWmq1d6g== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(316002)(70206006)(8676002)(26005)(31696002)(86362001)(2616005)(83380400001)(70586007)(84970400001)(40460700003)(336012)(81166007)(36860700001)(82310400005)(6512007)(47076005)(186003)(356005)(508600001)(5660300002)(36756003)(2906002)(6486002)(31686004)(8936002)(966005)(6506007)(53546011)(44832011)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 12:52:32.9553 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bb04b856-df0f-4ad1-5b1a-08da26ba771a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5829 X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Apr 2022 12:52:39 -0000 Hi, On 4/11/22 09:18, Nils-Christian Kempke via Gdb-patches wrote: > Hi, > > please find attached v3 of the series. > > V1 can be found here > > https://sourceware.org/pipermail/gdb-patches/2022-March/186473.html > > V2 here > > https://sourceware.org/pipermail/gdb-patches/2022-April/187655.html > > Changes since V2: > > - [Patch 11/11]: Fixed Texinfo issues. > > > Thanks! > > Nils > > > Nils-Christian Kempke (11): > gdb/f-lang: add Integer*1 to Fortran builtin types > gdb/f-lang: remove hidden ^L characters > gdb/fortran: fix complex type in Fortran builtin types > gdb/fortran: reformat build_fortran_types in f-lang.c > gdb/fortran: change default logical type to builtin_logical > gdb/fortran: clean-up Fortran intrinsic types > gdb/fortran: Change GDB print for fortran default types > gdb/fortran: rename f77_keywords to f_keywords > gdb/fortran: rewrite intrinsic handling and add some missing overloads > gdb/fortran/testsuite: add complex from integers test > gdb/doc: add section about Fortran intrinsic functions and types > > gdb/doc/gdb.texinfo | 143 ++++++- > gdb/f-exp.h | 182 +++++++-- > gdb/f-exp.y | 397 ++++++++++++++------ > gdb/f-lang.c | 267 +++++++++---- > gdb/f-lang.h | 7 +- > gdb/std-operator.def | 10 +- > gdb/testsuite/gdb.fortran/complex.exp | 10 +- > gdb/testsuite/gdb.fortran/complex.f90 | 7 +- > gdb/testsuite/gdb.fortran/intrinsics.exp | 46 ++- > gdb/testsuite/gdb.fortran/lbound-ubound.F90 | 49 ++- > gdb/testsuite/gdb.fortran/lbound-ubound.exp | 29 +- > gdb/testsuite/gdb.fortran/size.exp | 84 ++++- > gdb/testsuite/gdb.fortran/size.f90 | 213 ++++++++--- > gdb/testsuite/gdb.fortran/type-kinds.exp | 2 + > gdb/testsuite/gdb.fortran/types.exp | 34 +- > 15 files changed, 1160 insertions(+), 320 deletions(-) > I'm running into an internal error after this series when running gdb.fortran/intrinsics.exp on 32-bit arm Ubuntu 18.04. We're failing this particular assertion in eval_op_f_cmplx: gdb_assert (kind_arg->code () == TYPE_CODE_COMPLEX); kind_arg->code () == TYPE_CODE_ERROR. I see gdb/f-lang.c initializing some types to TYPE_CODE_ERROR if they're not supported. Should we fail gracefully in this particular case?