From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2076.outbound.protection.outlook.com [40.107.243.76]) by sourceware.org (Postfix) with ESMTPS id E48253858D3C for ; Sun, 6 Feb 2022 20:44:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E48253858D3C ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b3IwuoS0TWIT0XT4zv5CCKcE91z4oNPiRxRoJA+wR67Na3jLEhiMB2q3dAf4vs5ks4jUY0PBYB4K5bnbZfAYZh0xlHma+2KoiyaRTMH5GBUEo9GiJoO1F5GH/zOkOKO8Qr2VBQAga7Tb562mZB+h5xbOIFoX2vA868mKi4QqfCPm2BmcEw9sLS6Ion0Ad4gTotoKwKZzH5bPScW8Hr5i9XMLGS8J0/1ozuReFd5udFJ2zTKRYNSx0ZaIo/D3sR/mnsH7sPXv6fLeLh4Cl9UAMXLOJtb073ct/ARkjIFrSI8eIMYeh0fA9QA/svaAZAjW1De51odUqO7W5anEfz4E0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DUqMkvCZ+THMe6snCT2J/8/NVtAH/BL9aKIAfOoYEgE=; b=i1vduAq0aIrpz6iOMa1vouwzRDVPRvux7cZtYc3k6XU3XijBbBsTKesDDb4AwGc9PfNTmN2Q3QyXm67g6/mYd4NtQfIDRHiFTRWt6tzTCd6WCYgxYNp09XnFUT6FEjkZqFXhqO/BgpMmLe2/WPEyhzLppzdBzYSvP/s5ozIazmzK/2YEO1ZFuQwQCumTwEvGGaKeIKp6Ha3/wHUf/VJJWVXcf0J1Lsfc54MH9mr0C6R54gvsHPvmPMkuL1B6rJbbyFJKQxDnznIzLzA3Nvw3OBWWWz9/+aPMiAVnw0+XkC/CDWvOrA/XEOdYEpKLS8EsYzL/GkruFSNXJOWtTMysTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM6PR17MB3113.namprd17.prod.outlook.com (2603:10b6:5:6::10) by BN6PR17MB3252.namprd17.prod.outlook.com (2603:10b6:405:7a::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Sun, 6 Feb 2022 20:44:23 +0000 Received: from DM6PR17MB3113.namprd17.prod.outlook.com ([fe80::78f9:3a56:7d30:e2c9]) by DM6PR17MB3113.namprd17.prod.outlook.com ([fe80::78f9:3a56:7d30:e2c9%5]) with mapi id 15.20.4951.018; Sun, 6 Feb 2022 20:44:22 +0000 Message-ID: Subject: Re: [PATCH 3/5] gdb/python: allow redefinition of python GDB/MI commands From: Jan Vrany To: Simon Marchi , Lancelot SIX Cc: gdb-patches@sourceware.org Date: Sun, 06 Feb 2022 20:44:16 +0000 In-Reply-To: <2d84de61-dd35-1f84-13fe-a3917b9cafeb@polymtl.ca> References: <20220117124425.2658516-1-jan.vrany@labware.com> <20220117124425.2658516-4-jan.vrany@labware.com> <20220206171355.ldrvzh5pq46hpnom@Plymouth> <2d84de61-dd35-1f84-13fe-a3917b9cafeb@polymtl.ca> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0056.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::7) To DM6PR17MB3113.namprd17.prod.outlook.com (2603:10b6:5:6::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dfbbcffc-f7ed-4af2-c4eb-08d9e9b1749c X-MS-TrafficTypeDiagnostic: BN6PR17MB3252:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2089; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KuRD/lbG62vvD9gcZiIeNZrJjtNrG4MlVQbHNcEAhkKCgIiOfvUvkU6KRlhtGnB3BjL35rBjvWC0mIaovpPvOAk+gGD/b/QnaFqhizHbHKhhY4EhF3iF5CL53JMcBPqKqrfY85RKNXW1N2XUM2TB+ycQoAKjYJMw754WUQCM7VSWE9OVpNkCAuAYhFPYCsPlyvvNz619srDQVpWCpNJi/pxX8MLsyPHVkrV1Dp6QkiDC7Fyeee/cTyRFhznKDQ4hpHuhoP97qKEGRLxyIyFYTAWqJWfITEOSqjFedoG9dtLX4vA/KHs2O7cQrMdqkF8Vo/fKZ12TpZhX9J5GUKLVPamO7U5tfrU8FbRwkVVJ9E3yC6WZtxL1l5t+7CzjlsKVtHBackohrtDVoQeU7pzqZvU2p2QUNkGhOlpZ+TBW9sKWEfcG7/XliXlkbJDr4PRp3/FWUK67PpdTe87fRqrc4HmkvNokgtlTxrV6VL+U3I8TfXPV7cZ2kR+vJ1RxRjdXUKPTPqcGzvRucz30/wFOmSsqXFsNnhZ42rFjcAdCx1Zg2sQZDpB7HWIcqi560jTj8u33fSD2eFvC0Abfr+ufWRVWpArJ15RpTy9Tu0LWpbzxxyHcvhXOEuThlWh8v3nYURQSFgYjp+/w6nNISN7oRTjER1hhcPQJVtJLFHUCHHQkN0HTEkgHrdlYl/WJ+PXV0QQlvqdWXX0HC11qTqbswya7gPVqtghheEfWGOPDVL8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR17MB3113.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(86362001)(110136005)(6506007)(36756003)(6512007)(316002)(52116002)(508600001)(6486002)(966005)(6666004)(2906002)(4326008)(8676002)(8936002)(66476007)(66556008)(66946007)(2616005)(5660300002)(186003)(38100700002)(44832011); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFhVVlcvTGluL2VLeUo2bDJkMjJkRmhNY0I2amxrdWQ0a0RxS3FUNGhvV1or?= =?utf-8?B?YldjTUMyN0RTZm5Ta0ZyS2Vqd1NHWUpJbHJXM3lRYWxRdUIvQU53QjFIMTc0?= =?utf-8?B?Qkc2MWVINkhjd2V5QmFBbGhjUXZVUjZHZ0JUVUpnMVcrTmZPWUVpMkpEcnlw?= =?utf-8?B?VjNKcFFlWUNDKzFOSUVDUWJwUURvck5DdUFEd1M2TUlYamxmd1hvRDcvQWh6?= =?utf-8?B?aThTclBsQVkzZnkxdDBnbGhwU3JOMGE2c0dCRlY5NWRVUmtNR0NnNm1NenBn?= =?utf-8?B?aUdnTFZWazF2MWNmRlBVZmFnbjU3blJaR1RCeDE0TnducnR5d0pNMXRVY1pU?= =?utf-8?B?Q0FmZFM5bDg2V3B4bFNlRnd5aTN2WlY1YmRzLzBDem5iZEp1dW13eVRlWllH?= =?utf-8?B?Ri9rWjU1ZnZtSzFyZVZFd0NTcnJYY0lPbWVwaEx0c2NJSHNuVDAydjJqMHY2?= =?utf-8?B?OVNBRS9BNDdOeFZGS0cxb01ISEZaMUJVQ0h4SGIrYXV6OUZVazdReFZac3FF?= =?utf-8?B?Z2RzaUtTcmpaRFNZMXZJVVU5a2RCUmtnYnA3cmRobGJ0T2owamVnN1FkeWtz?= =?utf-8?B?dlNQVEFqam9FL0lZaWJuL01CQ1Bjd2U1YUVzSGIvSGZqcHdtTEk2MmVkSjF3?= =?utf-8?B?TnM4clBVVXV1VUFTTzg2aUhtcDErR0h0QVZrb2x1SU8zS3drQ3laakpXQ0FD?= =?utf-8?B?SXRyblpGNDF1bVUySzhZZTFPc1Job1N4WXA1RjRwaExvUGpDSnJQWWV0dFpt?= =?utf-8?B?YURQdmZrRXdqczRyZEtFbmpOTWtxS2hPdW1TbWlWclNXZGdPbTJiY2F0RjZ2?= =?utf-8?B?RFlYRlI0Y29YSmpXTEhSWHVPUjVrTi9FdGNZSXpnZ3lIRE9xVGo0cVNwYjZ3?= =?utf-8?B?Sm4rMGkxdXdCbkVYUVpQaThVM1BxclFHbVZQV0V6SjdlYnhHdDE1ajhIdklH?= =?utf-8?B?REVQMDRkZGVvUUd4YXRUQk5aRTFydkdWVDQzSTZzc2YxNVlRTUlPYnJ1TStD?= =?utf-8?B?Ky9LZkUvU3BHWTFyUk0vbVkwWW1vbnEzR2JRcGJzVUFGNk5lV3ZpTXVWK0Vj?= =?utf-8?B?SWh6QUNzWDc0ZVRDdnZWN1JUbHNCZHYzWThLNTRGRWZDZTNZNGdYTmg2QXpq?= =?utf-8?B?LzYwSUN1VWpjNHVkRlozTkliTmc1OVV4UG44WkxhVEM5Q3hXcmtzblRWcU1o?= =?utf-8?B?VVZkRnVEa05QMFNGUTJlc0JrNlJ1bVVyUGlnTzlzVzA1dHRtNmxBa240eUJv?= =?utf-8?B?RXhodHNXU3p5VnNINlZnODNHdW41a0tmbzhDTjRjM2FSZUdlS2YwejRlSm1L?= =?utf-8?B?WlJwN282V2xrY2xHRXQ5YUlRVTcwVWJhRVMwVmgxa3cwRXZxWEdrelNGRElx?= =?utf-8?B?QVVqSXowNVR2dk1Cd0ZxeUlBOTZZSjZvWlFWNHlTb0JJUktpMnB2QldMRDRK?= =?utf-8?B?UzMyYTd2SkRFWDZ3UjBwbGtHWS9ocUQ4N3dSYnhGMFpPN1pXbzVTd1JZbWlE?= =?utf-8?B?T3RJY04zUUw4ZnB3eGlsbkwrWVFQWGVMM0pFS0MvbGV4ampOSGhIUG4yYkJt?= =?utf-8?B?aEtQb0RVeXJXTmpaV05lYmlIR3NmY0JMSHl5LzlRZ1Z2cG9XUkd1SEVsY3g3?= =?utf-8?B?bnpjOXNiQURXS2ZVV3ZmenB4S1hyZjZyeW5zM3pNVGxHVEVvK2dwWHNNLzNy?= =?utf-8?B?NlM3Rk9CU0Q3OTRJSjZwM2JTeDhYZ2RCMzlXd2t1RjRaU1JES0FSTHBMSmZt?= =?utf-8?B?Ny9meGxWM3djNlpRRG9jSDdyaHFnd1drWk5WTE5wSGVpcHBXS2ZwaWV6UFl5?= =?utf-8?B?d0tSLzIyVW9HNjRLYVRIV3ZNUEQrS2ZKTVk4T1BiTnFvcDEyUGFMbXY3cFJa?= =?utf-8?B?a0JwTWkySkpnZm9kYXlEMGFBczFrV3dvNlpIcDVQVCt3b0FpN3BCdHJUTmJm?= =?utf-8?B?M01VbmhsT1cwZlZ0RUJzVmFkR2dpcW8zRU5VZlh6cVpydlk5dEoyUGc3RHZJ?= =?utf-8?B?SUJydTQ4TG5lN0pub0J1Q2xYTHB2ZXNNVzNQRHFlTTk4dHlDK0pWNUQ5QmVP?= =?utf-8?B?MkcwWVVEdnowZWdYamo0cGhhQzZQaHFxSnRBUlRwdWloZjhQckxySEU1aHBp?= =?utf-8?B?QXExV2NCTVpTRzd3U1dWTWU2NktTdXEwN0xnZjhYaFhBeTFQVDNFb3Z3eFVq?= =?utf-8?B?Y3lOOGx4QlEvSEhSRW90OHVkUjlQTzVNdWU2VUdCOW1oRG0rSlpHYjIxa0lr?= =?utf-8?Q?CHT68ct+o4yo4LaGcYeoYu1cO2KyLtCbe0Xo0qWWpk=3D?= X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-Network-Message-Id: dfbbcffc-f7ed-4af2-c4eb-08d9e9b1749c X-MS-Exchange-CrossTenant-AuthSource: DM6PR17MB3113.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2022 20:44:22.5800 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /O5/+AKIU3Ntc2yGyBA2DWKRoL6GjiTzgRQ7szh6TSIfYdW/vZ863GUmQc6y6lk1nAYbT8yvp4HXcfJ5OmI1sw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR17MB3252 X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Feb 2022 20:44:27 -0000 Hi, thanks! I'd just like to mention that my understanding is that in the end we'd go with Andrew's rework of this patch series, see the thread: https://sourceware.org/pipermail/gdb-patches/2022-January/185236.html and https://sourceware.org/pipermail/gdb-patches/2022-February/185662.html Jan On Sun, 2022-02-06 at 15:33 -0500, Simon Marchi wrote: > > Here you change the indentation from the previous patch. This change > > should probably be moved to it. > > > > I understand that this is tedious to change and am sorry for that. > > Yeah, it looks like there is a good number of changes in this patch that > adjust things added in the previous patch. These changes should indeed > be folded in the previous patch. I was going to comment on some of them > only to find out they get changed here, for no particular reason. > > FYI, with the right tools it's not too tedious. Here's how I do this > particular change: > > 1. "git config diff.tool meld", to set meld as my diff tool of choice > 2. use "git rebase -i" to go to patch 2 > 3. "git difftool --dir-diff " > > That opens Meld, showing the diff between patches 2 and 3. That lets > you bring in the changes you want from patch 3 to 2. Once you're done, > amend the commit, finish the rebase. > > Simon