From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 05/26] Introduce method wrappers for quick_symbol_functions
Date: Mon, 22 Mar 2021 09:52:37 -0400 [thread overview]
Message-ID: <b2b09f7c-9f19-ae5a-a627-24ba3da6609b@polymtl.ca> (raw)
In-Reply-To: <20210228203803.1693413-6-tom@tromey.com>
On 2021-02-28 3:37 p.m., Tom Tromey wrote:
> This introduces wrappers for each function in quick_symbol_functions.
> The wrappers are methods on objfile, and are defined in
> symfile-debug.c, so that they can use the symfile_debug variable.
> Places that call the quick functions are all updated to call these new
> wrapper methods.
>
> gdb/ChangeLog
> 2021-02-28 Tom Tromey <tom@tromey.com>
>
> * symtab.c (iterate_over_symtabs, expand_symtab_containing_pc)
> (lookup_symbol_via_quick_fns, find_quick_global_symbol_language)
> (basic_lookup_transparent_type_quick)
> (find_pc_sect_compunit_symtab, find_symbol_at_address)
> (find_line_symtab, global_symbol_searcher::expand_symtabs):
> Update.
> * symmisc.c (print_objfile_statistics, dump_objfile)
> (maintenance_expand_symtabs): Update.
> * symfile.c (symbol_file_add_with_addrs)
> (expand_symtabs_matching, map_symbol_filenames): Update.
> * symfile-debug.c (objfile::has_partial_symbols)
> (objfile::find_last_source_symtab)
> (objfile::forget_cached_source_info)
> (objfile::map_symtabs_matching_filename, objfile::lookup_symbol)
> (objfile::print_stats, objfile::dump)
> (objfile::expand_symtabs_for_function)
> (objfile::expand_all_symtabs)
> (objfile::expand_symtabs_with_fullname)
> (objfile::map_matching_symbols)
> (objfile::expand_symtabs_matching)
> (objfile::find_pc_sect_compunit_symtab)
> (objfile::map_symbol_filenames)
> (objfile::find_compunit_symtab_by_address)
> (objfile::lookup_global_symbol_language): New methods.
> (debug_sym_quick_functions): Remove.
> (debug_sym_fns, install_symfile_debug_logging): Update.
> * source.c (forget_cached_source_info_for_objfile)
> (select_source_symtab): Update.
> * objfiles.h (struct objfile): Add methods corresponding to
> quick_symbol_functions.
> * objfiles.c (objfile::has_partial_symbols): Move to
> symfile-debug.c.
> * linespec.c (iterate_over_all_matching_symtabs): Update.
> * cp-support.c (add_symbol_overload_list_qualified): Update.
> * ada-lang.c (add_nonlocal_symbols): Update.
A bit late, but: wouldn't it be better to have the objfile methods
implemented in objfiles.c, and just export the symfile_debug variable?
We already have some _debug variables exported, this wouldn't be a
problem.
Simon
next prev parent reply other threads:[~2021-03-22 13:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-28 20:37 [PATCH 00/26] Allow multiple "partial" symtab readers per objfile Tom Tromey
2021-02-28 20:37 ` [PATCH 01/26] Move some DWARF code out of symfile.h Tom Tromey
2021-02-28 20:37 ` [PATCH 02/26] Introduce dwarf2/public.h Tom Tromey
2021-02-28 20:37 ` [PATCH 03/26] Change objfile_has_partial_symbols to a method Tom Tromey
2021-02-28 20:37 ` [PATCH 04/26] Change objfile::has_partial_symbols to return bool Tom Tromey
2021-02-28 20:37 ` [PATCH 05/26] Introduce method wrappers for quick_symbol_functions Tom Tromey
2021-03-22 13:52 ` Simon Marchi [this message]
2021-02-28 20:37 ` [PATCH 06/26] Move quick_symbol_functions to a new header Tom Tromey
2021-02-28 20:37 ` [PATCH 07/26] Move sym_fns::qf to objfile Tom Tromey
2021-02-28 20:37 ` [PATCH 08/26] Convert quick_symbol_functions to use methods Tom Tromey
2021-02-28 20:37 ` [PATCH 09/26] Move psymbol_map out of objfile Tom Tromey
2021-02-28 20:37 ` [PATCH 10/26] Change how some psymbol readers access the psymtab storage Tom Tromey
2021-02-28 20:37 ` [PATCH 11/26] Do not pass objfile to psymtab_discarder Tom Tromey
2021-02-28 20:37 ` [PATCH 12/26] Set per_bfd->partial_symtabs earlier Tom Tromey
2021-02-28 20:37 ` [PATCH 13/26] Change how DWARF indices use addrmap Tom Tromey
2021-02-28 20:37 ` [PATCH 14/26] Move psymtab statistics printing to psymtab.c Tom Tromey
2021-02-28 20:37 ` [PATCH 15/26] Change how DWARF index writer finds address map Tom Tromey
2021-02-28 20:37 ` [PATCH 16/26] Reference psymtabs via per_bfd in DWARF reader Tom Tromey
2021-02-28 20:37 ` [PATCH 17/26] Attach partial symtab storage to psymbol_functions Tom Tromey
2021-02-28 20:37 ` [PATCH 18/26] Rearrange psymtab_storage construction Tom Tromey
2021-02-28 20:37 ` [PATCH 19/26] Remove sym_fns::sym_read_psymbols Tom Tromey
2021-02-28 20:37 ` [PATCH 20/26] Introduce objfile::require_partial_symbols Tom Tromey
2021-02-28 20:37 ` [PATCH 21/26] Add partial_symtabs parameter to psymtab construction functions Tom Tromey
2021-02-28 20:37 ` [PATCH 22/26] Remove last objfile partial_symtab references from psymtab.c Tom Tromey
2021-02-28 20:38 ` [PATCH 23/26] Change count_psyms to be a method on psymbol_functions Tom Tromey
2021-02-28 20:38 ` [PATCH 24/26] Remove objfile::psymtabs Tom Tromey
2021-02-28 20:38 ` [PATCH 25/26] Switch objfile to hold a list of psymbol readers Tom Tromey
2021-02-28 20:38 ` [PATCH 26/26] Allow multiple partial symbol readers per objfile Tom Tromey
2021-03-20 23:33 ` [PATCH 00/26] Allow multiple "partial" symtab " Tom Tromey
2021-03-22 14:13 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2b09f7c-9f19-ae5a-a627-24ba3da6609b@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).