From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <research_trasio@irq.a4lg.com>
Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0])
	by sourceware.org (Postfix) with ESMTPS id 26E0D382EA14
	for <gdb-patches@sourceware.org>; Thu, 27 Oct 2022 02:40:27 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 26E0D382EA14
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=irq.a4lg.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=irq.a4lg.com
Received: from [127.0.0.1] (localhost [127.0.0.1])
	by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 26969300089;
	Thu, 27 Oct 2022 02:40:25 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irq.a4lg.com;
	s=2017s01; t=1666838425;
	bh=gUlDYUT4U08s0qNjnIg7IJinpOPMUiq7fp4wGpPF9kw=;
	h=Message-ID:Date:Mime-Version:Subject:To:References:From:
	 In-Reply-To:Content-Type:Content-Transfer-Encoding;
	b=B7zBiObIlEKBEdYyoXvfcqLYXDHa7JN7Za/4PIWXH67lAn6byqemnt9JN9dhTFy9n
	 fKpYivSZRZcUnoNZQGeFzAEzOLMm/bwxnN1062sN3vb22uQYtbsnzNECgoUGvYBgkZ
	 YEv1y6rE54shtvJhjV0B7Wgr54kXGKnosnjrp9TM=
Message-ID: <b31b6551-c88f-eb09-37bd-e1e84be96243@irq.a4lg.com>
Date: Thu, 27 Oct 2022 11:40:22 +0900
Mime-Version: 1.0
Subject: Re: [PATCH 22/40] sim/m32r: Fixes to Linux emulator
Content-Language: en-US
To: Mike Frysinger <vapier@gentoo.org>, gdb-patches@sourceware.org
References: <cover.1666258361.git.research_trasio@irq.a4lg.com>
 <a3693e7a058878c5a64f39ce0e58c7a2605b3a07.1666258361.git.research_trasio@irq.a4lg.com>
 <Y1VWOXxLeSC/uzkf@vapier>
From: Tsukasa OI <research_trasio@irq.a4lg.com>
In-Reply-To: <Y1VWOXxLeSC/uzkf@vapier>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

On 2022/10/23 23:56, Mike Frysinger wrote:
> On 20 Oct 2022 09:32, Tsukasa OI wrote:
>> 1.  Some header files were missing
> 
> this looks fine
> 
>> 2.  syslog function must be called as a syscall rather than POSIX syslog
>>     because we are emulating Linux system calls on the Linux host.
> 
> i don't think that is accurate.  if that were true, every other call in here
> would be using syscall() instead of calling the C library functions.

Note that this part is a Linux to Linux syscall translator (though I
consider this whole idea unsafe).  Yes, it uses many C library functions
but I consider this is because they are (almost/completely) compatible
with underlying syscalls.

However, this isn't the case for syslog.  POSIX syslog (C library
function on <syslog.h>) and Linux syslog (syscall) have very different
semantics and Linux syslog should be used here.

Probably using glibc wrapper klogctl (<sys/klog.h>) might be a solution
(see man page syslog.2).  I would like to hear your thoughts.

Best regards,
Tsukasa

> 
>> 3.  ftime function is deprecated but used intentionally.
>>     We have to disable deprecated function warning.
> 
> this looks fine
> -mike