From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 8B2FB396E850 for ; Thu, 20 May 2021 16:12:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8B2FB396E850 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 14KGCdoS030183 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 May 2021 12:12:43 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 14KGCdoS030183 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C0F7E1E813; Thu, 20 May 2021 12:12:38 -0400 (EDT) Subject: Re: [PATCHv2] Add optional styled argument to gdb.execute To: Hannes Domani , "gdb-patches@sourceware.org" References: <20210519172649.2935-1-ssbssa.ref@yahoo.de> <20210519172649.2935-1-ssbssa@yahoo.de> <1166216993.4273524.1621525359183@mail.yahoo.com> From: Simon Marchi Message-ID: Date: Thu, 20 May 2021 12:12:38 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1166216993.4273524.1621525359183@mail.yahoo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 20 May 2021 16:12:39 +0000 X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 May 2021 16:12:45 -0000 On 2021-05-20 11:42 a.m., Hannes Domani wrote: > When I call gdb.execute() with to_string=False, the output to stdout is colored, > so do you mean styled=False should disable the colors? Yes. Well, I'm asking whether we might want that in the future (to be able to control styling when using gdb.execute with to_string=False). If we might want that in the future, I think it would be natural to use the "styled" parameter for this. And so I ask whether a simple True/False boolean will be enough for this, given that True/False would (presumably) force the styling to on or off. Will there be a need for a third (default) value to say "do whatever the default is"? Simon