From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80059.outbound.protection.outlook.com [40.107.8.59]) by sourceware.org (Postfix) with ESMTPS id C2DE43858D38 for ; Fri, 23 Sep 2022 17:03:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C2DE43858D38 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Z32yjDMnC1vSwsAAG07P06hbDElDROfNogNVqyQIuJ1RBQV4Q0XlbEqRH4iQWPasze1xM5QsvSH6lVw4WDjdN/albo0EJHGcVSXe9y9tCuLZebMMRbMqe+lViDt0qVyAX/cRo+IlkS9ZZkclQU3YZQkd7P/cVK5OkuAqeXs+EuNacdBHmdXfVSYpn/TYviIQu08sZagVhEIZCCGw13I3TuchZyMd8edZfHcAFwCc8cZxeOqVxAY9UwtUWKv+MVXAk070YLEcBfgeQdmefD1NjQGIODUQDp6i1cLtiIUMMth9Ek4InWyYCl+LduXM1j1Dxj9FCbc/bMatQyBkQjClmA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wuiMkyMekaAIDby5wW6sAUIjXoUrgLvK1fnj4UC7sjQ=; b=af6sVo27PqPYL6ytFHKe6mnoSiRimObsYqaxBNuG/rDhUz19pqkz6O1ccg+Zl2VfRuujFSOweKFzNIj7jOk0H5qYEUTJqwNc2hrh8mW34CZXMEPlPDwLCkBMdO/rq4csEXxyhNuNYNLopexy9sX578p99FGb9f07m5aPyNhraj47tHOHL6IoZpK1ji2QpJMS16P9+YLuVZJLob/VTvVZVCl7StTNcU3Oz3cgNy8iaDes2/GjoIl2IaDTPcTXujjmc4AP9Iw/KEB3fk5P9doFl5ZyEjO/GEdGl3V+uRiC/eINB9dEDyG7L9+rwX34YCATFch8eiHAE9lJTj7m9cPcYQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DB6P18901CA0021.EURP189.PROD.OUTLOOK.COM (2603:10a6:4:16::31) by AS8PR08MB7322.eurprd08.prod.outlook.com (2603:10a6:20b:441::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.19; Fri, 23 Sep 2022 17:03:12 +0000 Received: from DBAEUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:16:cafe::80) by DB6P18901CA0021.outlook.office365.com (2603:10a6:4:16::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20 via Frontend Transport; Fri, 23 Sep 2022 17:03:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT064.mail.protection.outlook.com (100.127.143.3) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Fri, 23 Sep 2022 17:03:12 +0000 Received: ("Tessian outbound 9236804a5e9b:v124"); Fri, 23 Sep 2022 17:03:12 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 8d3612cb872bf2fb X-CR-MTA-TID: 64aa7808 Received: from b66e100f0ddb.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 66FDB723-1461-4728-AC9D-4C0C6298D8B3.1; Fri, 23 Sep 2022 17:02:28 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b66e100f0ddb.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 23 Sep 2022 17:02:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h1S+NhwRj6PGuSyaT7ezhTWgu7UkjYFfWk/qn9pHaRdbm8IcfmD9QyVTyLsEMdd4excyG3a0KIqzJ74pWda2/ZOdY9iQfY5p12hkvTJDxBku4HMdgFeXwuieXvsxTpe5xwu9mRol3WgcHhMlucCKk9e2igkhMoQ+qA/4N7elO5qL75DpS/SAcxv0HKN3K+7lMyU9VxB5mY+vfsn7+8F6dg5cLKlGTszi6+yXQ0ldOcsirAAgE2JraE1yIB/c/toxVa0Iit9R8X/DVcDYsw3Q4AFKCO0UhHAX/rF82NxorRYfn5No4gRrWxLtJ/8aKCFw60S55Y5mDc4tEwTo8+w5aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wuiMkyMekaAIDby5wW6sAUIjXoUrgLvK1fnj4UC7sjQ=; b=XVO01iNRKLQY8Xcsp7RucjG7ljQITjJXiZ5kiiCyfy59d1xpQUTT4GQVbYT+heg7TVq8lx2pD30eeun/vGWXuXQGTk15IBak7uN/aHp2mKDr47Nl5TktExAdJRzxfwEhxOfW0n1hlj4RA21C/rwl89OikhUnNbSOt7sqS6+8jOjzn83+noQz/WAc9/Ef7EQ2zaL8PpOIBzGay4sStkh5RUqUBUs0T6pd+EymvGfTgeJ+Sk6p7nDNdP3JIUSmljwpOn7z+k7tjucvsiotB3e7bWPAeZ4ai2kDgJENwnn6b7xh3MVZurabJCagXiUAwk8wcqzIlmCreJ1yHizCUATvRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by PAXPR08MB6383.eurprd08.prod.outlook.com (2603:10a6:102:155::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20; Fri, 23 Sep 2022 17:02:26 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c5f9:a25b:a5f2:6094]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c5f9:a25b:a5f2:6094%5]) with mapi id 15.20.5654.016; Fri, 23 Sep 2022 17:02:26 +0000 Message-ID: Date: Fri, 23 Sep 2022 18:02:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 0/3] Fix gdb.gdb/python-helper.exp + cleanups Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20220923141801.1106678-1-simon.marchi@polymtl.ca> From: Luis Machado In-Reply-To: <20220923141801.1106678-1-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0235.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:b::31) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|PAXPR08MB6383:EE_|DBAEUR03FT064:EE_|AS8PR08MB7322:EE_ X-MS-Office365-Filtering-Correlation-Id: 53235a62-0f54-4ff3-d7c0-08da9d857f7d x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9FisxlDkfR6C4YJg4D1DJLL2vsAseqk6gzqylc7eIQOWx3CLObrJH6qTV/OLCEjEJtS1q9x9ULjtjamfpVUtFazGdm96R0ANFTv0NuzZPPWklIOdcflEvZ3+g8w5mfbgmUEucPY34xoksLhxsSJ+s26EXq2cdLHW+qkP+V5Vkv8WVEO1DIGNt9liQNVIbyjMYsh6VD/7DyP0K/l40RS7T6UuHtIBDfQ7MX/h0lj+3BwlzcD8hXdaBKhPUSgrRAY5Q58js9b+gNtLLwqbPouCXegmMkAz4F1c+Hm1pXlCGUS/6/SVUq/WwVMwdCFN5iMxiRfIZIjDeoGf2f5MuDrI9OLER2b8+eHAbl/nri9daZ5zEF4YmipRC67fBg1Gw/4H3Dn3RSXomYNp0MLNoAtXgAZHaGodxoq1fWnyRC2p2SeBaHJ8nwfgdV3qIbxobYu/bxAT24/tKzJ6CZCX1xkGu55hwU9OhsWLbdCZpGOCDuVKSAtbaaimD+GMBizDD3in8hDWJK0NUp8R1AbPm3Hr9MIJssk7wZqdheHQqYPWUU7JNwz3wtEGmp6JoOw322OxXoPdFhaBW8Kd677K1cCWMqzb6cMBC03rE1YfGZEliX3WrapDTiK57q0M8ga2nA1o4QZlBxkaAb9rTI9VdqZfXxgX5ACDjWYdpAzxfaf4/79aE/2TB6qEP5LvfBtO0EU0R58wFe2YMSXTmxfHc2erQ190Pi7Hbd8dSPk0S5uC4oBUTLp+ljjfBDX9e6UTC/2GLIjw5/hx7hnuqYjb1cWEeZk4yiRx8ZvbqDHJL5WN66D6MAh2yya4KgO1dhrAIrcL X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(346002)(376002)(136003)(366004)(396003)(451199015)(26005)(6512007)(36756003)(2906002)(6506007)(53546011)(2616005)(31696002)(86362001)(186003)(66946007)(66476007)(66556008)(83380400001)(84970400001)(8936002)(41300700001)(316002)(5660300002)(8676002)(38100700002)(44832011)(478600001)(6486002)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6383 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 96304063-3394-41f1-2254-08da9d8563e1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UicN5Qw9ynSxXC/M7SPMypGdOqCxBbAGysKBe9jEhLX9jma0DNvO8oHhpciNwNnh9onhfwNXm2F1T9bfFnZ3eor+rFowAwEnIfqUXbPG9HmRIW0aHOjaSZvVNzGOJkN/O1b6qQH9oNOEJlkzBgtXgSmo4Zqb78llYXMCIPj/pCnFrdSdwR1tiKMJ2NCt5yU99Uf2tnwr7xCp/5ob/1zzV+H1xCqsQwLonNWDRwvEcwI9Gt7zmWVp5obqvnpXgwS/ORLmrpGYOrphDo0OFxsmiAkKeW/j8LfXuU6EIMewPoDZQONw36zV/gEINTZvyvxE0L1XbWO5PCtaDLdYvyrYvtRNzcuViNsytCdwOYAiQ6a4MtV5QN1kks5+RzZ14g/iIlcC0daNp+NoebXWBQWPLb2X6e1vtrhO4CnrGfNrib6A9BCG/d9mvPa0JcusAFtH/mO4hFF4gFTAXXXPpby+isz1OjhnPxOJ5hx9gTSoLGKi5uBL5Dxy24kjioe/pGkNXncRvk/3iPvMP8Akkmh0G8nXX/B7GOJAQ8EGiUGY91kMb3VPLeP5OSz+PpdK8E2pvuw7o1uKb3eLN8H9VfbZj1JMsXDMJfErve3JqpwUqkNfgbEvd4FL8Bn46x3pXC0+NJwQ+ZRgMRpsKHgxRwPk2XYIBBzmQA17M99A1YvX1oEJhuVqaKYADu1TLwEp98Y49tCArnB/md14ExBhuPEfk8pATnag5Urk5DsYXt7pU7Yb00wf9hSgWyKm4LgLBPR9/hemXvMYFnB2t+F0amhUVwewE2UmzIhixR4PAiYi7VQOhO+3r08Y6zSDEkCR2ZM89ZWustqT6MtDVe+xB+zKow== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230022)(4636009)(136003)(396003)(346002)(376002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(83380400001)(31686004)(84970400001)(26005)(53546011)(6512007)(6506007)(5660300002)(40460700003)(8936002)(41300700001)(36756003)(44832011)(70586007)(2906002)(47076005)(6486002)(316002)(478600001)(8676002)(70206006)(82310400005)(2616005)(40480700001)(186003)(31696002)(336012)(86362001)(36860700001)(81166007)(356005)(82740400003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 17:03:12.1355 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 53235a62-0f54-4ff3-d7c0-08da9d857f7d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7322 X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Sep 2022 17:03:26 -0000 On 9/23/22 15:17, Simon Marchi via Gdb-patches wrote: > My patches that touched TYPE_LENGTH and TYPE_TARGET_TYPE caused > regressions in gdb.gdb/python-helper.exp. I forgot to update > gdb-gdb.py.in, as always. > > It looks like my CI doesn't run the test properly. Because inserting the > first breakpoint times out, do_self_tests skips the test. I also had > troubles running the test locally due to these timeouts. So the first > two patches address problems related to that, and the third one is the > actual fix. > > Simon Marchi (3): > gdb/testsuite: bump duration for the whole test in do_self_tests > gdb/testsuite: use gdb_test in gdb.gdb/python-helper.exp > gdb/testsuite: update field names in gdb-gdb.py.in > > gdb/gdb-gdb.py.in | 4 +- > gdb/testsuite/gdb.gdb/python-helper.exp | 88 +++++-------------------- > gdb/testsuite/lib/gdb.exp | 8 +-- > gdb/testsuite/lib/selftest-support.exp | 36 +++------- > 4 files changed, 31 insertions(+), 105 deletions(-) > > > base-commit: 8e037eae6823caf5b9cb5b4feb3de838abb25956 Thanks for the series. I tested this on my end and it seems to work nicely. The only hiccup I noticed is when GDB runs into a SIGSEGV due to the guile interpreter hitting GC_find_limit_with_bound. I'm not sure why this happens. Maybe it is a problem with guile and armhf. I don't think it is a flaw with the patch though. We'd have to go out of our way to handle something like this in the testcase. So this series LGTM.