From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 89DFF3856DD2 for ; Wed, 25 May 2022 19:20:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 89DFF3856DD2 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-141-G_Q-FmY7MzKq561dw2eVcw-1; Wed, 25 May 2022 15:20:55 -0400 X-MC-Unique: G_Q-FmY7MzKq561dw2eVcw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 752C5800B21; Wed, 25 May 2022 19:20:55 +0000 (UTC) Received: from [10.97.116.24] (ovpn-116-24.gru2.redhat.com [10.97.116.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2D8892166B29; Wed, 25 May 2022 19:20:51 +0000 (UTC) Message-ID: Date: Wed, 25 May 2022 16:20:49 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v5 0/8] gdb: split array and string limiting options To: "Maciej W. Rozycki" , gdb-patches@sourceware.org Cc: Simon Sobisch , Tom Tromey , Andrew Burgess References: From: Bruno Larsen In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2022 19:21:01 -0000 Hi Maciej, I've taken a look at the whole series and only had comments for patch 5, all others seem ok to me. However, I can't approve patches, so here's hoping a maintainer gives you some feedback! Cheers! Bruno Larsen On 3/30/22 07:23, Maciej W. Rozycki wrote: > Hi, > > Sadly I have received no feedback for v4 of the series other than the > docs (thank you, Eli!), so here is v5 with the documentation parts updated > only for Andrew's original proposal to split the `set/show print elements' > options into two, so that there are separate `set/show print characters' > options to control how many characters of a string are printed. > > Following earlier discussion for compatibility with existing setups I > have implemented a mechanism to make the `set print characters' setting > follow that of `set print elements' by default. Consequently what was a > single change has now grown into a patch series. > > In this series I fix some preexisting issues in the area first, implement > the general framework for extra literals used with integer settings second > and then add the original change for `set print characters' from Andrew, > adjusted accordingly, followed by a testsuite update as a separate change. > This is so as to ensure the semantics of the existing `set print elements' > knob hasn't changed in the default `set print characters' state (a small > update for the test suite is nevertheless included with the `set print > characters' command proper, because inevitably the relevant commands that > list commands now print additional entries, plus there's been a minimal > test case update included for the verification of setting defaults). > > Since I have noticed some v4 hunks to apply with significant line number > changes (meaning larger code rearrangements) and also Python 2 support to > have been removed (my original builds used it) I have re-regression-tested > the changes (with the build switched to Python 3), again with a native > `x86_64-linux-gnu' configuration. I have also visually examined the > result of the updated changes to the GDB manual in the info and PDF > formats. > > See individual change descriptions for details. > > OK to apply? > > Maciej >