From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40971 invoked by alias); 16 Oct 2017 21:37:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40955 invoked by uid 89); 16 Oct 2017 21:37:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=realworld, real-world, Hx-languages-length:897 X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Oct 2017 21:37:00 +0000 Received: from ESESSHC005.ericsson.se (Unknown_Domain [153.88.183.33]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id B6.05.07039.97625E95; Mon, 16 Oct 2017 23:36:58 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.33) with Microsoft SMTP Server (TLS) id 14.3.352.0; Mon, 16 Oct 2017 23:36:57 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.49.59] (192.75.88.130) by DB4PR07MB316.eurprd07.prod.outlook.com (2a01:111:e400:982f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.5; Mon, 16 Oct 2017 21:36:56 +0000 Subject: Re: [RFA 4/6] Simple cleanup removals in remote.c To: Tom Tromey CC: References: <20171016030427.21349-1-tom@tromey.com> <20171016030427.21349-5-tom@tromey.com> <07804bc3-a6c5-2c0f-5730-5dd12fccafbe@ericsson.com> <87fuaipzgg.fsf@tromey.com> From: Simon Marchi Message-ID: Date: Mon, 16 Oct 2017 21:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <87fuaipzgg.fsf@tromey.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DM5PR19CA0015.namprd19.prod.outlook.com (2603:10b6:3:151::25) To DB4PR07MB316.eurprd07.prod.outlook.com (2a01:111:e400:982f::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9170be7f-1de4-42bf-3e1f-08d514de067c X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:DB4PR07MB316; X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB316;3:0YX8vciAcM1oEH0E4ODsu1mBmoZlt6xqRIEiGWGZ/S84C5hime6LjwIujKLzwM3oEdCz/0lnGIJFAp0jOj+r3MDWMci08SHpeLH1EkwmVHclQ3FPTOYK8SrBpnjWyZkXp81DAuC+dNkOOHZCuosNqXK8VC7/2bqTOVKMSGn3VIsjOaXfHTv0/vHt+mDAv7M+gUpEh2Dn7qMUCDKde7eUE+mPpxzVi1TvoHCoCNHs+zjGDaerMjRXea8G/rXTktEN;25:OqGzAXvKyoOO0jjiFZw5rtA6fVa113vBcU0Uk9iFX6fn2cQ73pN91RcvGmLohOm7LfNvs936sTFQtZcsrVcuPd3BKCSgCUytYXlf9X2aKmPtquYb2pimJXwV5UEhUCmajZlJ7rW8l5ZGghq57bqNFWJh75cxjVKDHTEZmfohUnft8ETId6eCteMGqBS+DpaakmEEb69WppqGQz9D5kEdRmOOKOVLk5ZPLyysMUH+vztUQ4kyJ/VaVN5iFeWowe0Pw8a6Bzwfn1VSItTtu6Ol1vFw9ggb/zSZ+/FGtmYZBCEUFKX53EO5Om8H9CfgjnVC9ilejee9Qzeux1eeQtiPSQ==;31:dxeBcU2GLlI0X+qy7bILYoOFzjuHvQ9Xva4DxSRigSQCS1nrm7evyb29RMKR5H5qCQkVWd5AympVPUKblEQre1yJa65eJdAXB5anikG3I6GWOhyi1LpRBdd2zttRtojL2ll7e6aDEBBHyRiVXT/WpHtBCBSxImuV8No1kqVQ+sbsOG7Yrrt2f4S0CSYUhTxHEwyG4+r2mvkkqq76cKt122dmTM5c1TWdADcGHG8n9FQ= X-MS-TrafficTypeDiagnostic: DB4PR07MB316: X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB316;20:oF1JDCNY1DMM/tb9kOSATJx5B8g7T64EhrANUUSGipCXVY5NBM/KVrpiiCGE2zjQBl64IInxo1kjrAoB2zbl0sqQu7q5J34Zszuo89lo13SGX38rhixb6GjCn7r2MSyR8JzhlMsmCBcem8QrA1mYmZLPBESsDsUVoKqem4pi2p5Xy0r9LDwrQPHVBLQrsXI51bbRKaCxhYmoXyPIEXwE7R557bMU3qPT5LI/uLGRTP3GcVZQWlby5Atq6QS5bkfkssoI7rqmiRRxQdZyEhYlxWgNTsCFxQwVgvGvouBOaeifW+CyBsF+qi6kBNM2toY5Qgk00C6/MOgENC3F580cqOTHlDaV20UC0ZJrRTh0fm/JSpeir+k2HwDN0QHkbDljzGJGqZ5N35JL/tCuAJJV6GqEefP2JBxzwb3vnCnco12euGLORv+Vadb9dO8uUj1zPYV9TmWYVt5mGhcY1MT3BPwBQiLSxEF04/kLYHAhclbBZLvJbhVUFqmyWhxyYz/6;4:basITFdJNZyNyqCz5/kkEPcqh/JAq+5aHcm0l25X0XMikUrIGEuz3scM4ZBx6BTW3Mjhlhrmb5UX9JsrCaZrQjnx6nky3vsPUXv/ivMrNxIcBqvjWqLHbDIddJ2n+eKTkF5LfwwzyKjo9L4Ymlr2aYDZUi/1uGXLQszYK6/5X5ZyZTvp8FDkYZzvc1eixpz8A68WH6U5WuW+3w8eWk6m2dZNb3v4ZFl/q97+5Cy+iSe5nfKSwwm2ppHqBznoprhRElsfD+hj6N5sc9sFU36aypcDPxcwriiRYobIjdKZji0= X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123558100)(20161123564025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB4PR07MB316;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB4PR07MB316; X-Forefront-PRVS: 0462918D61 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(346002)(376002)(39860400002)(377454003)(24454002)(189002)(377424004)(199003)(65806001)(64126003)(105586002)(54356999)(6486002)(2906002)(189998001)(16526018)(65956001)(36756003)(4001150100001)(49976008)(23676002)(6116002)(478600001)(53936002)(53546010)(97736004)(66066001)(50986999)(76176999)(31696002)(31686004)(3846002)(47776003)(305945005)(7736002)(2950100002)(6916009)(83506001)(58126008)(316002)(16576012)(101416001)(6246003)(25786009)(229853002)(33646002)(230700001)(93886005)(81166006)(68736007)(50466002)(5660300001)(4326008)(86362001)(81156014)(8676002)(6666003)(8936002)(106356001)(65826007)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR07MB316;H:[142.133.49.59];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjRQUjA3TUIzMTY7MjM6ekVoNnlKbHVpdGw5d3QvenNxelNDVERmeE5h?= =?utf-8?B?dW00WGlJdDMzNm9jMSs3bERUSkw0Uk1XWmpZQ1RxeENrRlJaUTcvZ0VSaC9W?= =?utf-8?B?cW14cjNNeEYxVzQ1TlljMGhRNnZqeXBzQzFCVzlEQkQ4VmtINUNlNHIybVEv?= =?utf-8?B?S1ZnOERVQjBFS0pjRmJGOG5RaE5TN0lRQ1Ryb1VGcDNlRFpYZVBJYURrNVpy?= =?utf-8?B?WHJvTkxwRVlTVkVPVFhwdTJON3NUQ3VNU0FKU3l6SHNsUWtWeEJCRDFFU1Bx?= =?utf-8?B?OG1uSVZlVEtOd2xNSVV6MjNRcWt1L2tPc3lIMjA3c3I2VzlqU0ROVXNWanp5?= =?utf-8?B?K3JCcjd4aG8xL3NwaHF4YTdDVFdhanJNZkprV1c5cTd4LzNvNVBhcklKcXFi?= =?utf-8?B?U0dUVXJuRjRKcFNrMzhkeVhiYWt4V1QxZW0zcnlqVWp3V3hnYTNUdXdMNnpK?= =?utf-8?B?L0NLdFJyMXJ3TlR4aHNWSjZVNnA3UDlsMnBhSWRra0R2dDJKZlJabVVGZ2p3?= =?utf-8?B?T1JNM044azI2VzB0b2E2MGZYN1pWTjg2UkltQUJIWGVPMmlGeE1OUUthTDYv?= =?utf-8?B?Z2hTZnlaQXI3Rm1OclcxRkczcVZDd2lXY1R6aDU1ZllrV2wvR0NqbTBLUVRP?= =?utf-8?B?YTAycEtQbzE5THBXbUpiSFl3OWY4WmNHTTJEN21Xcyt6YkdpcnNlZCtIR0ZN?= =?utf-8?B?T0hPenkxMDFUWG5UbHhSSnNURjA0QS9FVklXUU5GUW90NjA2RE5EWUpKcmx0?= =?utf-8?B?enQ2MCtLZWdXRWxGWndYSm9pNFVsRytaK1dhNGNVekEyTnhBQUJzWmVSS0Qw?= =?utf-8?B?MWNIU3pyUlJOMjlKM1FwaS9Obk5YSmU4MWR4OGwvK3k3YnB4dzlmQXdqeDNT?= =?utf-8?B?WXhXdDVWUjVHQU96NDMzemVXTi9ZVGJhVU1HNDBTNDdRZkNXQ1ZDYkY0Yzgy?= =?utf-8?B?cEtWRmNrQnY3YU1KTUdFZ2NpUWhnYm5qczNWT2phMTdrQnFFbU15TEh1NHpD?= =?utf-8?B?VVVSdFh5TUgxVmw1K0RtZ2I4ZnoxSWJiWGdwbGJORUhJRG9ETnFBOTRVcmJB?= =?utf-8?B?enVuWlhUQVdMZW5JZ1ZDaEdpS0lWZjhUTTZDWlRVRlRvTUQxNHBGL3I0ZjFv?= =?utf-8?B?d1k5bERFc2RVTitualZMcStUbklxbTRqcFNuY2kwUWxxNVpTUVFQYktMY0Yv?= =?utf-8?B?ZmlZRnVtUVB1S1FoUXZhYWNpTHBRL3RaSUwxQm04TkUxZmFldkhQTzZYaWJt?= =?utf-8?B?WXNiaTlJQ1M0SDlXdHBTVTFESENzWlhMRGEwS2Vua3VJbmhQc1VtaC8rdmt2?= =?utf-8?B?ZlFFa2NNV1hsblBKTGhQVDB1TGJiY2dETXV1OWJVR1c4RkQyYWtCbURvRkpa?= =?utf-8?B?bDZSWk5QVk4yM0tQUDVjd2JYWndCMDdSaU1PNWlvVGVTUk5sTGRjNjhLelcw?= =?utf-8?B?M0ZKNGZtdGt3Z0FxL2tSVGEvTlNXMnBPRHVsWDIzVnkrMkhnTWFmQUpoZkRy?= =?utf-8?B?NTNhRENoL3pESzBMM2E0NTVyQnlzK2g4KzRCTm5sTi96bjhZUzZzNHJXcTBJ?= =?utf-8?B?SXI3YWthejJYSE0rMzVJdGNzSVpMQ0xIMHQyZ1ZPWU9jVDgyREU5ZHl6cGxr?= =?utf-8?B?VCtCeHdwajV4Y3hIMmhGWmE0QnkxQTRRekNJdjZrWHU1VnZJU3pGVEk3SEpo?= =?utf-8?B?QmNIcUUyWklrNU5TdXJET0tPbzV2S3dEY0dOZjNVUE10NEEyM2lRVDhaL1lS?= =?utf-8?B?blcwN05qc3pQMnFGVnJ0ek81VDAvUjB3Q3pBTk9ncUJWWlBUdDNRSExBWS85?= =?utf-8?B?WjF1cTdoUTlaOHdnUm43WjhwTE9VUWRBS01jNFMvVmNXNzVqQmY5N1RxdmRm?= =?utf-8?B?RGs2SElHaHNBZ2h6WU9kZDhXWmkzcllFV21qVExJV2RZNDJBbEd1LzhoY2d0?= =?utf-8?B?UnVJQUh1Tmc5ekFMWHhYTGRXcVN6UE9IZGE1QmN5YnhBaG5DdXJTUkNyMG9h?= =?utf-8?Q?O7HWg?= X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB316;6:RE6o7gUxysGzQpfPgjBdt5yuZGA+9pUZppFaeQvrUrzgB3jPllNtR0yXyWn6VhOTgJn1sVP4FBdsZraMz8ASEC6KVXg5dU/OAmuYqsiSq/DBYKALvdrV+gH2ERwB55jP+Jw8TTRgETpV1XBuztXOCAoKIZW/VeCfWfo2SFHF34BWNXIT2KRGwEDOa0vQ30mA6VffFj8f3e77yQIzMQSslMG4sP3ATNOM4cQl+6trwYKWtfJ5ySgyJ6pu74mgDoahRzCe8ZwKhaJA4Tk0qmswWbsp7PAPDQrb5SqvHweEqNAiE78YvMxsi7AN9u1YdcwZ/CFOG5MFQVt1A3/9EpiEMw==;5:ITvvhGXxd3r1rsoJgCF09qwUswXsl9eE+oexmdoiCAmp3OovlaVBbgFUmRt0cCILeOKIaYxk/yHkqkX3bz70GksXTj5jl/IM028zbAfBxcmuh7NPbU1S9ibCoV49cf5PPZbAYz1joN1VW9OjXTFv1Q==;24:LACNn9O+Gly3C8cyqY/XPPCIXZbUu3NmUOrFYvMw/gh2pBA3UBDD0oZa4CI1RAjN/XDDuyBJKMd2Ie4Qg1npZbEv6io8riNXKOeGYg6+UpA=;7:Et0N308i6m4RuAlqc+AGXI78Rne785Yy95aqFntyf5pRlUuOQW/ivDOqtEA1CRK1GQWnzqhlvCLjOGXw9gUsaCtDJxej6gwdzpC0ZBCCexk7HAFoQOe343Gn2K/2n/NGM7ntoetSavJw6Ij5yaBcaBToWi/pFhPQfPNwTyrkTWkIcqACJmcNcbYS25efDwI0NvCzxeC2hXjVl50rdQYlP78Rq98q7oatK20UUNf3tJo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2017 21:36:56.1112 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR07MB316 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00475.txt.bz2 On 2017-10-16 05:14 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> For this one, wouldn't it be easier to just go with a string? Something like: > > It's easier but less efficient. > I wasn't sure if it mattered so I erred on the side of efficiency. > > Tom > I suppose you are talking about the += string_printf ()? It's true that it's not the most efficient, because the formatting is done in a separate buffer (an std::string) and then copied, instead of directly in-place. At least, there's likely no dynamic memory allocation, because the string fits in std::string's local buffer. So since there's likely no real-world impact, I would've erred on the other side. In any case, I don't really mind, your version is good too and eliminates the clean up, which is the main point. Simon