Re: [PATCH] gdbsupport: implement move constructor and assignment operator in auto_obstack

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2022-04-14 11:22, Pedro Alves wrote:
> On 2022-04-14 16:12, Simon Marchi wrote:
>>> The patch looks fine if we really want to make auto_obstack movable, but,
>>> stepping back a bit, does cooked_index really need or want to be movable?
>>> I did this, here:
>>>
>>> diff --git c/gdb/dwarf2/cooked-index.h w/gdb/dwarf2/cooked-index.h
>>> index 661664d9f84..e3d8b5a59b7 100644
>>> --- c/gdb/dwarf2/cooked-index.h
>>> +++ w/gdb/dwarf2/cooked-index.h
>>> @@ -169,9 +169,9 @@ class cooked_index
>>>  {
>>>  public:
>>>    cooked_index () = default;
>>> -  explicit cooked_index (cooked_index &&other) = default;
>>> +  explicit cooked_index (cooked_index &&other) = delete;
>>>    DISABLE_COPY_AND_ASSIGN (cooked_index);
>>> -  cooked_index &operator= (cooked_index &&other) = default;
>>> +  cooked_index &operator= (cooked_index &&other) = delete;
>>>
>>> and gdb still built.
>>
>> Hmm, I saw that do an std::move of a cooked_index_vector, so I thought
>> we did move cooked_indexes.  But actually it is a vector of
>> unique_ptr<cooked_index>.  And I guess that since auto_obstack is
>> non-copyable and non-movable, it wouldn't build today if we really tried
>> to copy or move a cooked_index.
>>
>> We can just delete those lines then (instead of making them explicitly
>> deleted), just having DISABLE_COPY_AND_ASSIGN is enough.
> 
> Please go ahead.

Done, thanks.

simon