From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Add some parallel_for_each tests
Date: Sun, 29 Aug 2021 15:58:34 -0400 [thread overview]
Message-ID: <b42355e3-cab7-31e5-2c95-d402d73c79ad@polymtl.ca> (raw)
In-Reply-To: <20210828191838.1552741-1-tom@tromey.com>
On 2021-08-28 3:18 p.m., Tom Tromey wrote:
> This adds a few tests of parallel_for_each, primarily testing that
> different settings for the number of threads will work. This helps
> address an issue that Tom de Vries pointed out in the DWARF scanner
> rewrite series -- that a change to parallel_for_each introduced a
> regression here.
Can you say a few words on what was the bug? I'm reading the test, and
since there are no comments it's unclear what behavior you are testing
specifically (other than "parallel_for_each" in general).
Simon
next prev parent reply other threads:[~2021-08-29 19:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 19:18 Tom Tromey
2021-08-29 19:58 ` Simon Marchi [this message]
2021-08-30 2:24 ` Tom Tromey
2021-08-30 13:29 ` Simon Marchi
2021-08-30 13:44 ` Tom Tromey
2021-08-30 15:45 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b42355e3-cab7-31e5-2c95-d402d73c79ad@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).