From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69374 invoked by alias); 17 Oct 2017 10:01:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69361 invoked by uid 89); 17 Oct 2017 10:01:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=lift X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Oct 2017 10:01:48 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 630C54E334; Tue, 17 Oct 2017 10:01:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 630C54E334 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 26F8E5E249; Tue, 17 Oct 2017 10:01:43 +0000 (UTC) Subject: Re: [PATCH 1/2] GDB test suite: Add helper for locating core files To: Andreas Arnez , Kevin Buettner References: <1505760152-28775-1-git-send-email-arnez@linux.vnet.ibm.com> <1505760152-28775-2-git-send-email-arnez@linux.vnet.ibm.com> <20171007094545.1bba5c51@pinnacle.lan> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Tue, 17 Oct 2017 10:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00499.txt.bz2 On 10/09/2017 07:46 PM, Andreas Arnez wrote: > On Sat, Oct 07 2017, Kevin Buettner wrote: > > [...] > >> E.g. when I test your patch on my x86-64 linux box using the >> following command... >> >> make check RUNTESTFLAGS="--target_board=native-gdbserver" >> >> ...I see 32 fewer passes than before and also one more known failure. >> >> Here are the passes that no longer occur when using your patch: > > [...] > >> Instead, several warnings are now printed instead: >> >> WARNING: Can not generate core dump on remote target. > > These warnings are newly introduced by the patch. They are meant to > improve diagnostics when someone attempts to run the tests on a "real" > remote target. I wanted to clearly document the fact that this is > unsupported (and always was). Also, by documenting this restriction, > maybe someone feels encouraged to lift it ;-) Wouldn't an UNTESTED or UNSUPPORTED be better? It's what we tend to do with other cases of unsupported/untested tests. Those convey what happened to the testscase, and are accounted for and an untested/unsupported count is shown at the end of a test run, while a count of warnings isn't. Thanks, Pedro Alves