From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A8C143858D20 for ; Wed, 31 May 2023 15:27:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A8C143858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685546861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sgYOQf7FnWnJeBglFA23XjAjMQKZovvdGFWd0hOiDaM=; b=Zh4wYnZuOtAgR1JouXOHwGEWOTs/9026Byomdz+UNr0ab2dKvvc7qBj/+JakeNuK8ofFpx IBDDsi4m73JQRadIAuwC3Rwh202f2urpGjfawWjHx6V01cypmAXR97M+yoCd/Xs3MU7WIF cTl9w5DVeyUNtBKD8sD2rJCOrVgNyco= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-454-lBsBjXIlOzikJsEzj_onIQ-1; Wed, 31 May 2023 11:27:40 -0400 X-MC-Unique: lBsBjXIlOzikJsEzj_onIQ-1 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-3f6b3a5a4e8so41056031cf.1 for ; Wed, 31 May 2023 08:27:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685546859; x=1688138859; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sgYOQf7FnWnJeBglFA23XjAjMQKZovvdGFWd0hOiDaM=; b=Cdot0q2EXNY4wF5oSULWdjkLrj7Qqr9vqEREgMURqRSWdNKmdmDdzdtcIkIq2gNmMe oxFdgw6i11nK1LUtgytmtOjOlJUSvF4MPTDubDLQwOloC5h4b5+Uq21TYam9BjnmLPF3 whF9HAlCa1nP8WWRycguGm1dhJ8mkZwyqPFXX0LoXQ0DPXySaHPLr0mevbsgPqyx1PwE bxBgpsflUgvU7Fgv8Eq/sT2tdT27NQj6pcnAFKHyNkD36Ei4LFTeyTR29zHZhkOvHn+6 MfPP/T86fqpF7FiopIFQPh3wBpTiYRT9qjNiXAjPH5/IiGVsmcK5/MV/qOjdjYZX2lZT Ocyg== X-Gm-Message-State: AC+VfDzO0OBT4PIQn7EhHjK2vahl5+8nXo1sLIjj6rc1mrH0lyavU6vW qR3oYMOuV0BSdA36cVkBI0O5btkn7RQUkw7ugUKFgHRZmAQyRw3ynS4UcJtForumk8dDYn8HMz4 XhteQxxXeXAX8w8/kODOtLg== X-Received: by 2002:a05:622a:20d:b0:3e6:4fab:478e with SMTP id b13-20020a05622a020d00b003e64fab478emr7047227qtx.33.1685546859649; Wed, 31 May 2023 08:27:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6YSgl4Y/7TtcUtg09MElmr3k8bQmdBFZHagcuGglLFr4MGqD+NoGXrkqp06Ih0xMu7NlYbWg== X-Received: by 2002:a05:622a:20d:b0:3e6:4fab:478e with SMTP id b13-20020a05622a020d00b003e64fab478emr7047209qtx.33.1685546859260; Wed, 31 May 2023 08:27:39 -0700 (PDT) Received: from [192.168.0.129] (ip-94-112-225-44.bb.vodafone.cz. [94.112.225.44]) by smtp.gmail.com with ESMTPSA id bt6-20020ac86906000000b003ef59e2b9a6sm6059372qtb.78.2023.05.31.08.27.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 08:27:39 -0700 (PDT) Message-ID: Date: Wed, 31 May 2023 17:27:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/3] [gdb/tui] Keep inferior output in cmd window with ^L To: Tom de Vries , gdb-patches@sourceware.org Cc: Tom Tromey References: <20230530105324.23089-1-tdevries@suse.de> <20230530105324.23089-2-tdevries@suse.de> <335f3833-a4ac-e85a-63ac-5212931cc206@redhat.com> From: Bruno Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 31/05/2023 17:24, Tom de Vries wrote: > On 5/31/23 16:27, Bruno Larsen wrote: >> On 31/05/2023 16:19, Tom de Vries wrote: >>> On 5/31/23 15:35, Bruno Larsen wrote: >>>> I can confirm that this fixes the issue you mentioned when the >>>> terminal scrolls. The problem is that now, if the output doesn't >>>> cause the screen to scroll, it doesn't show up on screen at all. >>> >>> Is it possible that you're talking about a pre-existing issue? >>> >>> That is, we have: >>> ... >>> (gdb) next >>> ... >>> and after we have very, very briefly: >>> ... >>> (gdb) next >>> hello >>> ... >>> before the prompt overwrites it: >>> ... >>> (gdb) next >>> (gdb) >>> ... >>> >>> I get this behaviour with and without the patch series. AFAIU, the >>> only way to deal with this (that doesn't go all the way into >>> introducing pseudo-terminals) is by introducing a separate cmd and >>> output window in TUI.  Alternatively, we can move the prompt to the >>> bottom of the command window, I've spent a day or so trying to make >>> that work, but abandoned that. >>> >>> If this is not the behaviour you're talking about, please describe a >>> way of reproducing what you observe. >> >> Huh... I think I remember this not happening last time I tried using >> the TUI, which would have been almost 2 years ago. I wonder if I am >> misremembering, if this use case never came up or if it is an actual >> regression... > Reproduced with (using in-repo readline instead of system readline, to > eliminate a constant system readline as source of non-regression): > - gdb-13-branch > - gdb-12-branch > - gdb-11-branch > - gdb-10-branch > - gdb-9-branch > - gdb-8.3-branch > - gdb-8.2-branch > - gdb-8.1-branch (*) > - gdb-8.0-branch (*) (**) > > So, if there is a regression, we're not talking about a recent one > (8.0.1 released 2017-09-05). > > Thanks, > - Tom > > (*) Using backport of commit 5a6c3296a7a ("gdb: Fix ia64 defining > TRAP_HWBKPT before including gdb_wait.h") to fix build. > (**) Without libipt to fix build. > Thanks for checking so far! it would definitely not have been earlier than 2017, so I most likely am just misremembering. -- Cheers, Bruno