From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6894 invoked by alias); 26 Mar 2018 14:26:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6885 invoked by uid 89); 26 Mar 2018 14:26:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=grateful, Hx-languages-length:1299, wish X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Mar 2018 14:26:45 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 76AAA401DEDA; Mon, 26 Mar 2018 14:26:44 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id D5A942026E03; Mon, 26 Mar 2018 14:26:43 +0000 (UTC) Subject: Re: PING^2: [RFA/RFC] fix PR gdb/22670 (pb looking up some symbols when they have a linkage name) To: Joel Brobecker , gdb-patches@sourceware.org References: <832dbb30-7c2b-40ed-c03c-654bd1e2ea32@redhat.com> <20180117091332.z7bqu4aljudq33sw@adacore.com> <20180126035055.vbjtowj6q5ftbwiz@adacore.com> <21bfbb6a-bb10-812b-c34a-d367321e8d5e@redhat.com> <20180129103841.kdkomcjbuwiat5b4@adacore.com> <250976c6-6e7a-6a8e-b9f2-a57f5b92b965@redhat.com> <20180130035612.xghiskhiweftijxi@adacore.com> <20180205095659.y5jzjj2e5bx6pjyf@adacore.com> <20180209090919.lmwjll72hccopjsk@adacore.com> <20180221030210.xzthyal2cysn5s72@adacore.com> <20180319212158.narawyklbdhitd6i@adacore.com> From: Pedro Alves Message-ID: Date: Mon, 26 Mar 2018 14:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180319212158.narawyklbdhitd6i@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-03/txt/msg00529.txt.bz2 Hi Joel, On 03/19/2018 09:21 PM, Joel Brobecker wrote: > On Wed, Feb 21, 2018 at 07:02:11AM +0400, Joel Brobecker wrote: >>>> All in all, I think a better solution would be to put that information >>>> directly in the language_defn itself, via a new "attribute". >>>> Something like a... >>> >>> I ended up choosing this approach. lookup names is still a bit >>> foggy for me, so the comments I wrote and/or the name of the >>> new language_defn attribute might be a bit off. As always, I am >>> grateful for suggestions :). I looked again at this today, and I couldn't think of a better option right now. So I think you should go ahead and push this in. Note that this C++ mangled form like in "symada__cS", is not actually how C++ symbols are mangled nowadays. The modern Itanium mangling scheme has linkage names that always start with "_Z". In this case, "void symada(char, signed)" mangles as "_Z6symadaci". It's possible that we no longer need to support that older (and ambiguous with Ada and other languages) mangling scheme for C++, I don't know. I wish Ada linkage names also had some kind of leading prefix, but that can't happen without an ABI break, of course... Thanks, Pedro Alves