From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103062 invoked by alias); 8 Mar 2017 17:03:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102925 invoked by uid 89); 8 Mar 2017 17:03:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy=H*M:95fd, *c X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Mar 2017 17:03:55 +0000 Received: from ESESSHC010.ericsson.se (Unknown_Domain [153.88.183.48]) by (Symantec Mail Security) with SMTP id D0.C0.18508.97930C85; Wed, 8 Mar 2017 18:03:54 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.48) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 8 Mar 2017 18:03:11 +0100 Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=ericsson.com; Received: from [142.133.50.177] (192.75.88.130) by AM4PR07MB1716.eurprd07.prod.outlook.com (10.166.133.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.961.8; Wed, 8 Mar 2017 17:03:05 +0000 Subject: Re: [PATCH 0/7] Pass ptid to target_ops register methods To: References: <20170308164140.7281-1-simon.marchi@ericsson.com> From: Simon Marchi Message-ID: Date: Wed, 08 Mar 2017 17:03:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170308164140.7281-1-simon.marchi@ericsson.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN6PR03CA0055.namprd03.prod.outlook.com (10.173.137.17) To AM4PR07MB1716.eurprd07.prod.outlook.com (10.166.133.24) X-MS-Office365-Filtering-Correlation-Id: e55fea06-d2a6-4fed-81dd-08d46644fd66 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:AM4PR07MB1716; X-Microsoft-Exchange-Diagnostics: 1;AM4PR07MB1716;3:v5m1zJvG5TveGUKPxxZDTBiYUBqWKumRxOLV2YCLMUNFY1YHEx/3CWwgzZEz3bvLSoFKOJWKqopvN3fJcyf4iMcptRnA2WwL9YHCHVGjiLTg0TmHBDXOiBwMYv6+H/1rw0a35aV1z/shqtZlj839JH3phA9HHXJXPR0B/MP33lGJv/E666Q3aGK0bipzkIzI2mahn6Vj5Gky8BoS/zCco2whOdTc477hVTUSeZ1Akd95JoPUpDyrn72tXCV1sjdbNayd8Tj5UrpQfwYka2WlKQ==;25:aho70zbxHaes6IfLFmwjcFLGOMrEKiRuU4gydqGJJoyCwxlwvS3Q9DsA67WXF6/kE2mFC9cEslOS/8diK91QybGxS0Uy5hHiE+/2Lz5pXkF6YGJlW+gjeT5fdf3vIou7KUSvCZvisYgBToWp28YoJQ8gq1CV8IwLRA5gdjBN642JioRjqIg2TpOFc3AfBRmZ5kKIkXi8LFsC7BeKQO56bOrkpdTBxAeuiOP3mmoK4LPYz6lcgi/gsKT/7EA9u+QMs2PaLJaxCRY+crXXCUkAftSuAPIsSPxxzJJupKMnMX2CIeQSz+7sDI7eiorzZp7UDDYZP2yLgAeN2zeTUucJMS4qo3TyoRhqIbSg+WnSkjXVLpo6FqOf4QDmiNVHN/E/8xsBQ+QKOAoueCN722A9zVjpiBVSUIJOVI7KLwOc/ygUR1Ft5P8urJl3hbVQL7xpKqicZT0RRajrI7vB7XAabQ== X-Microsoft-Exchange-Diagnostics: 1;AM4PR07MB1716;31:BYpapYgG5Mu7VZ7qjc+tZDMrPHkWkQ3zL5oF9jhEo2CNvtEZoDFSHlLBbIaN1cnY1FkIlOmxtSam1Sqz3ACjhE5GAZCuHBsNTxY50CIxP6e2CjVX0ycEak9oKrrn5Q7dk1HNkkIr606n7alh0jFyK+G1/vu5f5uhSVhCsviS+fr1J5buOG4TnNtgb44wsYW24HdtOEB3xZZVf8Ydg6qAYuIRc2jXOYumrFZfh89dkSm0ZlNSw0GYBBF4YgFVIXRrrkLiBNCVntoZTtcJ+PN705xChE3LnHSRIAliO25/VNs=;20:63yC423uFKj4lDIQj/097IBJs06H2Qqf/sGca7IkbYZHolHasV6Il8gO2XhiBexEv1DRwDJfBOQMXvgAH+mzUQ/X/WD+nPM6+A4Ggo/T2Rnz9beOOqaFW79eCQwImAApa6xIinfjSGkZiuOLFk9YAcnLkJsj8LrDb7vNPLOefCGcKciqFFCk2sB2Dwrvj7NRXYiicOAjA0fVoioVmtb0KAv0UIOersUGiWLf4WC4YcQ2K2HiuMg4gH3s0mXUlFOOivoQc8NNqixT05Fs+vznivDlXqbJWq2FdzuwM5x/a2CWQ2k6fExknjCIgfj5mAOWJWQRAkHFM6kjTcOv/nqQ+BAtMyiH0gbublFk87LbMUOGHgwd1Bwud2nMyP3PdCXOdu01iiTOvGWMNNw9IFKn3Zou5nwOGCN71zWlUAl/lrp8XxhlFhIWZeiwFARGfTFYsToezH9ylm8fV2fcaaagE06bD+4oL7HN8rr1kZZrch2lxLs3MVr2UaWOYlaCC6aP X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123558025)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148);SRVR:AM4PR07MB1716;BCL:0;PCL:0;RULEID:;SRVR:AM4PR07MB1716; X-Microsoft-Exchange-Diagnostics: 1;AM4PR07MB1716;4:CGk4dzO3FFDCcW1jBjFUY4v6dUBK6iPUeh3m36igfvP47rXQouRYpp1ION/2uoBSvhCghUiIF8aWWsvStRd1GMVqQZtDNO0xSKlSuDoSk7CSXlMXf7ccis+cnI3ZTdSDYE0xJSsFUy+Kx8QjIz1lVPtgsRzSGm2k4gL5S+6201D7VsmkSpb3s0yksC/0zDsqTsyjvKuu9PUUBW9WZFhdaWnlrPQF4PNtpeCTx9L27gspwWUAbNQMe02toAmIdOJk/g0kPody3fgGEZPEOOd9fT2SQqUNuW+NtZT2e09OoJVZQqDdhTo+x1cdiReBpwfTwlEqN9BwK/N3F8KbGaH6os3nGXmFLyuIo4lCgSvpTDCsAleWzoOeboJlCX7PSn4ywQ7qlTfuerTefZzzdjo/JeMqpduzv7oYbD7NGu0kLnax3etVeDQ+Rjk5sDyItGz+wbQqmzXhhFlhDvBIG625ttrdk79Z2huvDdsuU5BALXI95lJ7M4auysN0r9uQCASN7BylXmlEnBQjxw1b05mpBM89Vg3qHrq9wU9Mf4E5DxNEs/yWgQUfJDtuXV01dgz2sJbWHE2WkQDyZdOYFaw3ggrmQqtlqbvbcU85+6bSA+s= X-Forefront-PRVS: 02408926C4 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(39450400003)(377454003)(24454002)(377424004)(230700001)(53936002)(6246003)(76176999)(50986999)(25786008)(110136004)(54356999)(33646002)(65806001)(31696002)(6486002)(38730400002)(90366009)(66066001)(86362001)(47776003)(4001350100001)(2906002)(189998001)(23746002)(42186005)(31686004)(7736002)(6666003)(2351001)(229853002)(5660300001)(65956001)(2950100002)(6116002)(3846002)(305945005)(36756003)(8676002)(83506001)(81166006)(65826007)(53546006)(50466002)(64126003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR07MB1716;H:[142.133.50.177];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM4PR07MB1716;23:LFavlMjYa2pyQWp/HSY7Ju9nLSl4/IS+sXvHy?= =?Windows-1252?Q?lVYejTFI3smcnfVU20gi3hM1LMgP5MXLt83KjN/fB9sDsA0hlanQs21U?= =?Windows-1252?Q?Z+Pu+qroU/kRU1/yj9oZLTNtgCNTBkXV41LxAIpP3sySkoKfpdK5VXy7?= =?Windows-1252?Q?AEpUncB4wYKldhtZbYenJ+SnSjxtnbk+r/irYfiD0TyFpHJCrd5ZyAqB?= =?Windows-1252?Q?8fmhQpohEr4Q8Jl78LANvGCBKvbv/Gd6YwRorej5br/QkgII77sVadCq?= =?Windows-1252?Q?hRvUNEDZ+qWZA0vlE04MwpSswP14ah3z7NlIA2HznC2dBJ1cCDrN1/W/?= =?Windows-1252?Q?tHZjUE9QVBsvhQePrA1WY4JO0xNwT1ElzM4Pw+1frhw2qck9TKNRPG2m?= =?Windows-1252?Q?+2yIghti+Q0To8dyvzsXt7+DF18uOTD3sXIQah7SNhUsDO20BW2i9O9+?= =?Windows-1252?Q?1WRhQPNErwMNjJKnJtLmsq6eSfGv7G7ofwO1P6VOE+ELrnvERx97leoH?= =?Windows-1252?Q?y3rY7fhj/9rVstznq7iUNKbvwu5xV4Y12tsIabIwrSVKU+soEjP++BQj?= =?Windows-1252?Q?7b2kfkcMt0oWLBOAl8Cz3PjY7RGzFIYLBiZykPWmfcbCu9QZFhCwZrdx?= =?Windows-1252?Q?MLJT7ka3jvcxgerNKLfpwR6Dw8KioF4tBHFySvTkXcWiAtdmPMH5yL3r?= =?Windows-1252?Q?w3DXBU2IMWurCHFjc82IO9/BjibRBjwAAXBff+xqfM4eiaIommRUV/xZ?= =?Windows-1252?Q?gbdU7dOYcxjPCXvYp2k+L10gE2QC58JbvkhT8aDueUEXW6hcmDt7A06T?= =?Windows-1252?Q?l7yCsoQsswIXn+Pjj2kx7dJLfZsedoxEign6WRroa25YKGewgRJCYLoA?= =?Windows-1252?Q?DRxlNOMRgw3x8BgcL4M319CuoYCyhl4EBvsQ9kCqBzBcOGptkH+dVMfC?= =?Windows-1252?Q?0XCP7Yso+qKhb+LqFTUblSexXVetEMj45YJYDediNMcCyt20bRtqMYnM?= =?Windows-1252?Q?lmxNDPxXhd0SS3OU4aLsQB602rH/rn5rG22ng5hwomW9dxf/qjPv/1MC?= =?Windows-1252?Q?aQuGaPe/4JuhXwGgnSp0wpXxj5cBYcp6e3W7L3lc+AOxwtEygm2iSgRp?= =?Windows-1252?Q?qCVYl9MSAIXPN+5PGzJv+pZi7PO63aJvUrzew5gSKyLUQi87JJqwTOy7?= =?Windows-1252?Q?8DWbDeNLaFQtloLQIl09enyAgdpgl+VoPqcKshI3gdI4QuxmL+n5nhub?= =?Windows-1252?Q?8fw/4asiAYVjyz4MXAK/9XlMje37X9heSgJicE=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM4PR07MB1716;6:kmIlUuXDrr4a08csenphAYwp/Va31gnJj/XKaQ8DnMl+COGGXmzsU5bgeUrPNJ4T5MJdjf7VBIqBpzsUmQTMgB1byF1T3xDMI+27M6OPRSKknxO30xT2llvWi9KbxIYkUrSrH7E+CwF9iONuRRYMnkTsRs+3qR36u8gakt5MwSDtr0laeRUEm66KRL/6HaHu1vnERbYs3Q4NME5UE003GtpAt+n/LGnqQ1ZrBHEGss/EKIQIq6haSFEcKSkUn/RJky5RuJzmfKdo9NF8EBLKRN8YN4tSskTPmx7KWFa2B2iJmEaqEmw3JnDntUQlQX/DBxk8ouhBHLnbsmIGkzJ/BOjbedQUW+rLo8/xDkXw/8mFhv6flKNzww0nKjss3jv5eaA/d4Hx/0mAa4pJosnrLw==;5:fFDdH99vonqqWhj0n4WLG/78PVtnK4tjWvjlR3LYc7vkVkWca4+mYPDa5DANu7XcVBDVyE7d5OK0jaxFm99ySI+4WPm+lU+uZT8h16TssF17ssxRpu7sGwnkp/xjU4pYGvP3pccY/ezfL1geeY9AIdmfGre3gqFhSdnRZoxYNv0=;24:A8LDHHThv0sFp1/he74HuymrmJqCY2pHTbN0A6fb/hvgjD/MUSdYmo2IYyYh4UdDG9I48Q8/9GMwD5sz1mAmaNRdzKrNqXBlijt4wvqRfOk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM4PR07MB1716;7:uWWPGHzTCJndhJEADeSCWLOwqp3fFAb26aZnUt6UHxDjDAqbitPSyh08f34ziPS0kn7n992/uPeUHm9WzSrS8ANaC0zk9ePFHtPamgj1KYNhxbumuWDrnV/+lxkHx0gI2W4kd/Klmxxdbtd4vS9zXz/6uc/MA7wwvPVMiFCZpk0sxD3EaVahp88fn4uOualZKBkdKTil/z+1LY7KxkHBWLp/6NaqCQ3fo1IdFSEQpRqI4rFJQaEZGdeMS5EKWUKgOtnRg1znKCdXn3aqYZ3pnPvP/ucOAYe25JVHjwc8zrZu+lYex1DZ7onmMhpwvQnzFBWeZCF4jPn3NTBo6wxLnA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2017 17:03:05.7807 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR07MB1716 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00108.txt.bz2 On 17-03-08 11:41 AM, Simon Marchi wrote: > GDB uses global variables a lot to indirectly pass information about the debug > context between functions. This patch series tries to reduce this practice a > tiny bit by adding a ptid parameter to the register access methods of the > target_ops interface. This removes a lot of direct references to inferior_ptid > in low level code. Instead, the callers of to_fetch_registers / > to_store_registers / to_prepare_to_store provide the ptid on which to operate. > > One of the goals is to reduce the number of times we need to save and restore > inferior_ptid. It should also make it easier to track down the context of why > we are reading/writing registers of a certain thread by looking at the stack. > > The buildbot shows good results x86 (32 and 64) and PowerPC. s390 has some > regressions, but I think it's unrelated: > > new FAIL: gdb.python/py-mi-events.exp: verify python support > new FAIL: gdb.python/py-mi-events.exp: check if python 2.4 > PASS -> FAIL: gdb.threads/schedlock.exp: schedlock=off: cmd=next: call_function=0: other threads ran - unlocked > > I built-tested a few other platforms: > > - mips64el/linux > - m68k/linux > - powerpc/linux > - powerpc/aix > - arm/linux > - aarch64/linux > - s390x/linux > - x86-64/windows (a x86_64-w64-mingw32 toolchain) > > Here are the platforms I didn't test at all: > > - anything BSD > - OS X > > I tried to identify all the locations impacted by this change and update them > accordingly, but it's almost certain that I forgot or messed up some, sorry in > advance. Oh, and to give an idea of the impact on the number of references to inferior_ptid, here are some non-scientific numbers. Before: gdb $ grep '[^_]inferior_ptid' *.c | wc -l 973 After: gdb $ grep '[^_]inferior_ptid' *.c | wc -l 765