From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by sourceware.org (Postfix) with ESMTPS id 088CC3857C6E for ; Wed, 6 Jul 2022 19:47:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 088CC3857C6E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f54.google.com with SMTP id v16so12018147wrd.13 for ; Wed, 06 Jul 2022 12:47:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7ayyHXYQcN+5Tl1wrBVEWfWH5eTX2EAUvNxZXtGEr00=; b=1tdeJ+NG0fUYsaQzKkl+LHv0fngdTT2PQLj/3bS+/ryDvM4bKCGV2TPo7HsTNKWvMX wQVs1ymtZzP+jPm98ZbKrjxlvlhexrFwgDYVGw6gcupEpRFVN6KXo30ZVT1qYlnU92g0 jRBa65huvZGOYoOxiEw1RF6lvq66POufPDyuOjIGcoavDopJ33wn5nYdIG3LXBnzp6t5 RNTc4PdGdN/aUYlVxzmokEyxYurAMvp8H4/WzqlUyc492o6y3aoxML8F+JBoJwcAjyLs uQtnShfpXYXAUVfRRF/24JRA8KUG2mbRTlG/lvNz2KuseHASjB7w/mXIoJyMDt6I7F8T mOqA== X-Gm-Message-State: AJIora+nqvqv8YX2LQE+M6cWPKns+B28I5AG+4RSuT/DAlp7c0Esmur2 TUg8IFkUm561Np320istasTl/hqZbm4= X-Google-Smtp-Source: AGRyM1tNUViQj8LfIw+FJkfeFV0WYImA06rHs026wDNMRMED2AYxJOaC57qNngpfRXlxEyex7ZwwXw== X-Received: by 2002:a05:6000:1686:b0:21d:6e46:2fa with SMTP id y6-20020a056000168600b0021d6e4602famr13324510wrd.691.1657136851299; Wed, 06 Jul 2022 12:47:31 -0700 (PDT) Received: from ?IPv6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id n18-20020a5d6612000000b0021bbf6687b1sm12232851wru.81.2022.07.06.12.47.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jul 2022 12:47:29 -0700 (PDT) Subject: Re: [PING] [PATCH] gdb: Remove duplicate "gdb Summary" in the test output To: Tiezhu Yang , gdb-patches@sourceware.org References: <1f72f23c-0355-6684-b3b5-d23a5e37777c@loongson.cn> From: Pedro Alves Message-ID: Date: Wed, 6 Jul 2022 20:47:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1f72f23c-0355-6684-b3b5-d23a5e37777c@loongson.cn> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jul 2022 19:47:34 -0000 On 2022-07-06 1:52 a.m., Tiezhu Yang wrote: > Hi, > > Any comments for this patch? > Are you OK with this change? > > [PATCH] gdb: Remove duplicate "gdb Summary" in the test output > https://sourceware.org/pipermail/gdb-patches/2022-June/190335.html > > It seems that this issue is introduced by commit e83907ff5ffb ("Include count of unexpected core files in gdb.sum summary"). We can't really just remove the printing the tail gdb.sum, as that would lose the printing of unexpected core files. The commit log of e83907ff5ffb explains: (...) In the end, I settled on the script approach for serial mode too, which requires making the "check-single" rule print the tail end of the gdb.sum file, with a side effect being that if you look at the terminal after a run (instead of at the gdb.sum file), you'll see the "gdb Summary" section twice, once without the unexpected core lines printed, and then another with. IMO, this isn't an issue; when testing in parallel mode, if you look at the terminal after "make -jN check", you'll also see multiple "gdb Summary" sections printed. If people find this confusing, one idea would be to print some separator, like below. We'd print it in both serial and parallel modes. (... snip ...) === gdb Summary === # of expected passes 115 /home/pedro/rocm/gdb/build/gdb/gdb version 13.0.50.20220706-git -nw -nx -iex "set height 0" -iex "set width 0" -data-directory /home/pedro/rocm/gdb/build/gdb/testsuite/../data-directory ------------------ Final results ------------------ === gdb Summary === # of expected passes 115 /home/pedro/rocm/gdb/build/gdb/gdb version 13.0.50.20220706-git -nw -nx -iex "set height 0" -iex "set width 0" -data-directory /home/pedro/rocm/gdb/build/gdb/testsuite/../data-directory make[2]: Leaving directory '/home/pedro/rocm/gdb/build/gdb/testsuite' make[1]: Leaving directory '/home/pedro/rocm/gdb/build/gdb/testsuite'