From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 54D55388204B for ; Thu, 13 Jun 2024 10:29:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 54D55388204B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 54D55388204B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718274594; cv=none; b=XaEAggtKQGEK14bmkjfORVxWz5/mS9BmMOHVEuM8dHkRpxOXO7fTSZm8JIAlcrHtsOelvZyroN8eVZXJktTENR4chRJ7w9k0FFdSAwl4SkBRU8wF/pIZk/X+LIT6G//agUlF+7uSGyGHqWDlKEaHvYMxYMSb13VkxmolJzo3m3k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718274594; c=relaxed/simple; bh=mIu9AvpFfWrSApao0Rt8GcUgmzguey5XdSyLzu7fe2A=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=TLwPaRXq8ayGSLv9helXdixAtzDmGpdHdzJtVMH4B9J9ut192zRURpfu5Ozua8L8PHN8bqGPjnKdTXtVNdFDbs/MOUO94VqvzBpzeWIXkqvrjI5F+OqrFUife5sIV43282gyx0LQ+k3N2Q/OzxhVyHit6W2nBKgmcIbFkrPb9pQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718274590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uk3X80l+7OEDPk83CA/coIPK6ikuCkpPzGukNbuiBz4=; b=Z7BmSdMwi/345vMMw6UEv42Ncq83MAUGddxSXQXL9yyPVZuPk1yS56PRry+AHv+UnhWDrv BNGen095HVQ5S0jAfF70x9DyeuSgEs8mq5UeuEqcdLmer7SxXmyUkhM6PaTkATV089NloD +k8YXX3+HSq3PBY8kE1fhTGGPXGEnuI= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-NtgAbC47PE2VtbzEmJTJrg-1; Thu, 13 Jun 2024 06:29:48 -0400 X-MC-Unique: NtgAbC47PE2VtbzEmJTJrg-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-52c8a4ef5e5so773828e87.1 for ; Thu, 13 Jun 2024 03:29:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718274586; x=1718879386; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uk3X80l+7OEDPk83CA/coIPK6ikuCkpPzGukNbuiBz4=; b=Ixjy2iNZdrO4JbJnJxtHw+NryRa/80ySQGj3SVtgPjmcTVM0DHCbgi4Gsd/VcQ7iQ6 B//4/kz7FtX5Mv15nQTz2mHwhQbCXRvyCvdoLcuQgcgm2UlDn3RNlP575BcCLP/GTfqW RB8wUkQGmuzwlac8YT42D4oaoe/pUe74pAFjz6IJ1Kn3VbebXYy+yWVFQwqd6ferwQgE Al3G7AJ+OYlITAaK1DsWhRLi/C3MhjQGzpK/JkmE29HzFGGm63BTKjVb6QzRSwOvXUfZ FJLdID0XtJ+2vnX2+f1O3N/D/hMi1SvFGTgW1Vvgo0kkKAuLcqp2C/IVFaYNKaFtzseu jKIQ== X-Gm-Message-State: AOJu0YwxjW7j3Mt4PHhutzshYhI1aBILef1j8MNhMNRjcAyAy4ZeclJf Lw/9u01BCkyVrXGj+6YmKrtzY0ZDUXX0fAmAo48aEi1LN0DN7Wn3rkqdSiWlvSE2d4Ky6EPy0ij ZAgZYdnVlyOwHNWw89wFlynu/+c+fzcDY9CUWCFn6DGNlhA+s9xx0ZafJzGGTa+iSnxvMDzkXo6 RppoAdaO+GD/3P8WbhbCeIk+Eo66EC9SnP9uprrzVoaVc= X-Received: by 2002:a05:6512:31cc:b0:52c:98d2:2419 with SMTP id 2adb3069b0e04-52c9a3fddc5mr3977427e87.49.1718274585931; Thu, 13 Jun 2024 03:29:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEr7c196zzsBN/xHy23cZ3XKlzPQOlxEdIpA1pU8BRyIQ3BpPMNTN5xA3bjfZE7ugrRQvmt8Q== X-Received: by 2002:a05:6512:31cc:b0:52c:98d2:2419 with SMTP id 2adb3069b0e04-52c9a3fddc5mr3977394e87.49.1718274585259; Thu, 13 Jun 2024 03:29:45 -0700 (PDT) Received: from localhost ([62.31.95.162]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-422f641a666sm18787345e9.45.2024.06.13.03.29.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 03:29:44 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 1/4] gdb: add target_fileio_stat, but no implementations yet Date: Thu, 13 Jun 2024 11:29:37 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: In a later commit I want target_fileio_stat, that is a call that operates on a filename rather than an open file descriptor as target_fileio_fstat does. This commit adds the initial framework for target_fileio_stat, I've added the top level target function and the virtual target_ops methods in the target_ops base class. At this point no actual targets override target_ops::fileio_stat, so any attempts to call this function will return ENOSYS error code. --- gdb/target.c | 31 +++++++++++++++++++++++++++++++ gdb/target.h | 16 ++++++++++++++++ 2 files changed, 47 insertions(+) diff --git a/gdb/target.c b/gdb/target.c index 1b5aa11ed6f..26e9bb0146d 100644 --- a/gdb/target.c +++ b/gdb/target.c @@ -3198,6 +3198,14 @@ target_ops::fileio_fstat (int fd, struct stat *sb, fileio_error *target_errno) return -1; } +int +target_ops::fileio_stat (struct inferior *inf, const char *filename, + struct stat *sb, fileio_error *target_errno) +{ + *target_errno = FILEIO_ENOSYS; + return -1; +} + int target_ops::fileio_close (int fd, fileio_error *target_errno) { @@ -3317,6 +3325,29 @@ target_fileio_fstat (int fd, struct stat *sb, fileio_error *target_errno) /* See target.h. */ +int +target_fileio_stat (struct inferior *inf, const char *filename, + struct stat *sb, fileio_error *target_errno) +{ + for (target_ops *t = default_fileio_target (); t != NULL; t = t->beneath ()) + { + int ret = t->fileio_stat (inf, filename, sb, target_errno); + + if (ret == -1 && *target_errno == FILEIO_ENOSYS) + continue; + + target_debug_printf_nofunc ("target_fileio_stat (%s) = %d (%d)", + filename, ret, + ret != -1 ? 0 : *target_errno); + return ret; + } + + *target_errno = FILEIO_ENOSYS; + return -1; +} + +/* See target.h. */ + int target_fileio_close (int fd, fileio_error *target_errno) { diff --git a/gdb/target.h b/gdb/target.h index 81de4a678c3..f754f4abd53 100644 --- a/gdb/target.h +++ b/gdb/target.h @@ -1011,6 +1011,14 @@ struct target_ops *TARGET_ERRNO). */ virtual int fileio_fstat (int fd, struct stat *sb, fileio_error *target_errno); + /* Get information about the file FILENAME and put it in SB. Look for + FILENAME in the filesystem as seen by INF. If INF is NULL, use the + filesystem seen by the debugger (GDB or, for remote targets, the + remote stub). Return 0 on success, or -1 if an error occurs (and + set *TARGET_ERRNO). */ + virtual int fileio_stat (struct inferior *inf, const char *filename, + struct stat *sb, fileio_error *target_errno); + /* Close FD on the target. Return 0, or -1 if an error occurs (and set *TARGET_ERRNO). */ virtual int fileio_close (int fd, fileio_error *target_errno); @@ -2220,6 +2228,14 @@ extern int target_fileio_pread (int fd, gdb_byte *read_buf, int len, extern int target_fileio_fstat (int fd, struct stat *sb, fileio_error *target_errno); +/* Get information about the file at FILENAME on the target and put it in + SB. Look in the filesystem as seen by INF. If INF is NULL, use the + filesystem seen by the debugger (GDB or, for remote targets, the remote + stub). Return 0 on success, or -1 if an error occurs (and set + *TARGET_ERRNO). */ +extern int target_fileio_stat (struct inferior *inf, const char *filename, + struct stat *sb, fileio_error *target_errno); + /* Close FD on the target. Return 0, or -1 if an error occurs (and set *TARGET_ERRNO). */ extern int target_fileio_close (int fd, fileio_error *target_errno); -- 2.25.4