From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 134F83858CDA for ; Mon, 18 Jul 2022 03:40:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 134F83858CDA Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1E9043714F; Mon, 18 Jul 2022 03:40:41 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0777813A83; Mon, 18 Jul 2022 03:40:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ZvC/ADnW1GJ/KgAAMHmgww (envelope-from ); Mon, 18 Jul 2022 03:40:41 +0000 Content-Type: multipart/mixed; boundary="------------b59UKFLBXI30CZAeiBC4vdKM" Message-ID: Date: Mon, 18 Jul 2022 05:40:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [RFC][gdbsupport] Add PARALLEL_FOR_EACH_DEBUG Content-Language: en-US To: Tom Tromey , Tom de Vries via Gdb-patches References: <20220714221829.GA31924@delia.home> <8735f2nqto.fsf@tromey.com> From: Tom de Vries In-Reply-To: <8735f2nqto.fsf@tromey.com> X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2022 03:40:44 -0000 This is a multi-part message in MIME format. --------------b59UKFLBXI30CZAeiBC4vdKM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/15/22 21:01, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries via Gdb-patches writes: > > Tom> +#define PARALLEL_FOR_EACH_DEBUG 0 > > Probably needs a short comment. > Done. Also changed this into a const variable. > Tom> +#if PARALLEL_FOR_EACH_DEBUG > Tom> + fprintf (stderr, "Parallel for: n_elements: %zu\n", n_elements); > Tom> + fprintf (stderr, "Parallel for: minimum elements per thread: %u\n", n); > > I'm meh on this kind of logging but if it helped you it seems fine. > I've reworked the output to the slightly more clear: ... Parallel for: n_elements: 7271 Parallel for: minimum elements per thread: 10 Parallel for: elts_per_thread: 1817 Parallel for: elements on worker thread 0 : 1817 Parallel for: elements on worker thread 1 : 1817 Parallel for: elements on worker thread 2 : 1817 Parallel for: elements on worker thread 3 : 0 Parallel for: elements on main thread : 1820 ... It was a surprise for me to find that worker thread 3 is idle, so I think the information is useful enough. Committed as attached. Thanks, - Tom --------------b59UKFLBXI30CZAeiBC4vdKM Content-Type: text/x-patch; charset=UTF-8; name="0001-gdbsupport-Add-parallel_for_each_debug.patch" Content-Disposition: attachment; filename="0001-gdbsupport-Add-parallel_for_each_debug.patch" Content-Transfer-Encoding: base64 W2dkYnN1cHBvcnRdIEFkZCBwYXJhbGxlbF9mb3JfZWFjaF9kZWJ1ZwoKQWRkIGEgcGFyYWxs ZWxfZm9yX2VhY2hfZGVidWcgdmFyaWFibGUsIHNldCB0byBmYWxzZSBieSBkZWZhdWx0LgoK V2l0aCBhbiBhLm91dCBjb21waWxlZCBmcm9tIGhlbGxvIHdvcmxkLCB3ZSBnZXQgd2l0aApw YXJhbGxlbF9mb3JfZWFjaF9kZWJ1ZyA9PSB0cnVlOgouLi4KJCBnZGIgLXEgLWJhdGNoIGEu b3V0IC1leCBzdGFydAogIC4uLgpQYXJhbGxlbCBmb3I6IG5fZWxlbWVudHM6IDcyNzEKUGFy YWxsZWwgZm9yOiBtaW5pbXVtIGVsZW1lbnRzIHBlciB0aHJlYWQ6IDEwClBhcmFsbGVsIGZv cjogZWx0c19wZXJfdGhyZWFkOiAxODE3ClBhcmFsbGVsIGZvcjogZWxlbWVudHMgb24gd29y a2VyIHRocmVhZCAwICAgICAgIDogMTgxNwpQYXJhbGxlbCBmb3I6IGVsZW1lbnRzIG9uIHdv cmtlciB0aHJlYWQgMSAgICAgICA6IDE4MTcKUGFyYWxsZWwgZm9yOiBlbGVtZW50cyBvbiB3 b3JrZXIgdGhyZWFkIDIgICAgICAgOiAxODE3ClBhcmFsbGVsIGZvcjogZWxlbWVudHMgb24g d29ya2VyIHRocmVhZCAzICAgICAgIDogMApQYXJhbGxlbCBmb3I6IGVsZW1lbnRzIG9uIG1h aW4gdGhyZWFkICAgICAgICAgICA6IDE4MjAKClRlbXBvcmFyeSBicmVha3BvaW50IDEsIG1h aW4gKCkgYXQgL2hvbWUvdnJpZXMvaGVsbG8uYzo2CjYgICAgICAgICBwcmludGYgKCJoZWxs b1xuIik7Ci4uLgoKVGVzdGVkIG9uIHg4Nl82NC1saW51eC4KCi0tLQogZ2Ric3VwcG9ydC9w YXJhbGxlbC1mb3IuaCB8IDI0ICsrKysrKysrKysrKysrKysrKysrKysrLQogMSBmaWxlIGNo YW5nZWQsIDIzIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9n ZGJzdXBwb3J0L3BhcmFsbGVsLWZvci5oIGIvZ2Ric3VwcG9ydC9wYXJhbGxlbC1mb3IuaApp bmRleCBhNjE0ZmMzNTc2Ni4uY2ZlOGE2ZTRmMDkgMTAwNjQ0Ci0tLSBhL2dkYnN1cHBvcnQv cGFyYWxsZWwtZm9yLmgKKysrIGIvZ2Ric3VwcG9ydC9wYXJhbGxlbC1mb3IuaApAQCAtMTM5 LDcgKzEzOSwxMiBAQCBwYXJhbGxlbF9mb3JfZWFjaCAodW5zaWduZWQgbiwgUmFuZG9tSXQg Zmlyc3QsIFJhbmRvbUl0IGxhc3QsCiAgIHVzaW5nIHJlc3VsdF90eXBlCiAgICAgPSB0eXBl bmFtZSBzdGQ6OnJlc3VsdF9vZjxSYW5nZUZ1bmN0aW9uIChSYW5kb21JdCwgUmFuZG9tSXQp Pjo6dHlwZTsKIAotICBzaXplX3Qgbl90aHJlYWRzID0gdGhyZWFkX3Bvb2w6OmdfdGhyZWFk X3Bvb2wtPnRocmVhZF9jb3VudCAoKTsKKyAgLyogSWYgZW5hYmxlZCwgcHJpbnQgZGVidWcg aW5mbyBhYm91dCBob3cgdGhlIHdvcmsgaXMgZGlzdHJpYnV0ZWQgYWNyb3NzCisgICAgIHRo ZSB0aHJlYWRzLiAgKi8KKyAgY29uc3QgaW50IHBhcmFsbGVsX2Zvcl9lYWNoX2RlYnVnID0g ZmFsc2U7CisKKyAgc2l6ZV90IG5fd29ya2VyX3RocmVhZHMgPSB0aHJlYWRfcG9vbDo6Z190 aHJlYWRfcG9vbC0+dGhyZWFkX2NvdW50ICgpOworICBzaXplX3Qgbl90aHJlYWRzID0gbl93 b3JrZXJfdGhyZWFkczsKICAgc2l6ZV90IG5fZWxlbWVudHMgPSBsYXN0IC0gZmlyc3Q7CiAg IHNpemVfdCBlbHRzX3Blcl90aHJlYWQgPSAwOwogICBpZiAobl90aHJlYWRzID4gMSkKQEAg LTE1NSw5ICsxNjAsMTkgQEAgcGFyYWxsZWxfZm9yX2VhY2ggKHVuc2lnbmVkIG4sIFJhbmRv bUl0IGZpcnN0LCBSYW5kb21JdCBsYXN0LAogICBzaXplX3QgY291bnQgPSBuX3RocmVhZHMg PT0gMCA/IDAgOiBuX3RocmVhZHMgLSAxOwogICBnZGI6OmRldGFpbDo6cGFyX2Zvcl9hY2N1 bXVsYXRvcjxyZXN1bHRfdHlwZT4gcmVzdWx0cyAoY291bnQpOwogCisgIGlmIChwYXJhbGxl bF9mb3JfZWFjaF9kZWJ1ZykKKyAgICB7CisgICAgICBkZWJ1Z19wcmludGYgKF8oIlBhcmFs bGVsIGZvcjogbl9lbGVtZW50czogJXp1XG4iKSwgbl9lbGVtZW50cyk7CisgICAgICBkZWJ1 Z19wcmludGYgKF8oIlBhcmFsbGVsIGZvcjogbWluaW11bSBlbGVtZW50cyBwZXIgdGhyZWFk OiAldVxuIiksIG4pOworICAgICAgZGVidWdfcHJpbnRmIChfKCJQYXJhbGxlbCBmb3I6IGVs dHNfcGVyX3RocmVhZDogJXp1XG4iKSwgZWx0c19wZXJfdGhyZWFkKTsKKyAgICB9CisKICAg Zm9yIChpbnQgaSA9IDA7IGkgPCBjb3VudDsgKytpKQogICAgIHsKICAgICAgIFJhbmRvbUl0 IGVuZCA9IGZpcnN0ICsgZWx0c19wZXJfdGhyZWFkOworICAgICAgaWYgKHBhcmFsbGVsX2Zv cl9lYWNoX2RlYnVnKQorCWRlYnVnX3ByaW50ZiAoXygiUGFyYWxsZWwgZm9yOiBlbGVtZW50 cyBvbiB3b3JrZXIgdGhyZWFkICVpXHQ6ICV6dVxuIiksCisJCSAgICAgIGksIChzaXplX3Qp KGVuZCAtIGZpcnN0KSk7CiAgICAgICByZXN1bHRzLnBvc3QgKGksIFs9XSAoKQogICAgICAg ICB7CiAJICByZXR1cm4gY2FsbGJhY2sgKGZpcnN0LCBlbmQpOwpAQCAtMTY1LDcgKzE4MCwx NCBAQCBwYXJhbGxlbF9mb3JfZWFjaCAodW5zaWduZWQgbiwgUmFuZG9tSXQgZmlyc3QsIFJh bmRvbUl0IGxhc3QsCiAgICAgICBmaXJzdCA9IGVuZDsKICAgICB9CiAKKyAgZm9yIChpbnQg aSA9IGNvdW50OyBpIDwgbl93b3JrZXJfdGhyZWFkczsgKytpKQorICAgIGlmIChwYXJhbGxl bF9mb3JfZWFjaF9kZWJ1ZykKKyAgICAgIGRlYnVnX3ByaW50ZiAoXygiUGFyYWxsZWwgZm9y OiBlbGVtZW50cyBvbiB3b3JrZXIgdGhyZWFkICVpXHQ6IDBcbiIpLCBpKTsKKwogICAvKiBQ cm9jZXNzIGFsbCB0aGUgcmVtYWluaW5nIGVsZW1lbnRzIGluIHRoZSBtYWluIHRocmVhZC4g ICovCisgIGlmIChwYXJhbGxlbF9mb3JfZWFjaF9kZWJ1ZykKKyAgICBkZWJ1Z19wcmludGYg KF8oIlBhcmFsbGVsIGZvcjogZWxlbWVudHMgb24gbWFpbiB0aHJlYWRcdFx0OiAlenVcbiIp LAorCQkgIChzaXplX3QpKGxhc3QgLSBmaXJzdCkpOwogICByZXR1cm4gcmVzdWx0cy5maW5p c2ggKFs9XSAoKQogICAgIHsKICAgICAgIHJldHVybiBjYWxsYmFjayAoZmlyc3QsIGxhc3Qp Owo= --------------b59UKFLBXI30CZAeiBC4vdKM--