From: Pedro Alves <pedro@palves.net>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/8] gdb/linux-nat: remove check based on current_inferior in linux_handle_extended_wait
Date: Thu, 31 Mar 2022 17:12:15 +0100 [thread overview]
Message-ID: <b4cde23e-9f61-44b3-0b52-9aa754fb1b47@palves.net> (raw)
In-Reply-To: <20220117162742.524350-3-simon.marchi@polymtl.ca>
On 2022-01-17 16:27, Simon Marchi via Gdb-patches wrote:
> diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
> index b926fb5eba9e..7de4da03a34f 100644
> --- a/gdb/linux-nat.c
> +++ b/gdb/linux-nat.c
> @@ -2096,20 +2096,11 @@ linux_handle_extended_wait (struct lwp_info *lp, int status)
>
> if (event == PTRACE_EVENT_VFORK_DONE)
> {
> - if (current_inferior ()->waiting_for_vfork_done)
> - {
> - linux_nat_debug_printf
> - ("Got expected PTRACE_EVENT_VFORK_DONE from LWP %ld: stopping",
> - lp->ptid.lwp ());
> -
> - ourstatus->set_vfork_done ();
> - return 0;
> - }
> -
> linux_nat_debug_printf
> - ("Got PTRACE_EVENT_VFORK_DONE from LWP %ld: ignoring", lp->ptid.lwp ());
> -
> - return 1;
> + ("Got expected PTRACE_EVENT_VFORK_DONE from LWP %ld",
> + lp->ptid.lwp ());
Please drop the "expected" from the log, as we're not checking
waiting_for_vfork_done anymore.
> + /* Child */
> + _exit(12);
Space before parens.
Otherwise OK. Thanks.
next prev parent reply other threads:[~2022-03-31 16:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 16:27 [PATCH 0/8] Some fixes for handling vfork by multi-threaded programs Simon Marchi
2022-01-17 16:27 ` [PATCH 1/8] gdb/infrun: add reason parameter to stop_all_threads Simon Marchi
2022-03-31 15:05 ` Pedro Alves
2022-03-31 15:35 ` Simon Marchi
2022-01-17 16:27 ` [PATCH 2/8] gdb/linux-nat: remove check based on current_inferior in linux_handle_extended_wait Simon Marchi
2022-03-31 16:12 ` Pedro Alves [this message]
2022-03-31 17:06 ` Simon Marchi
2022-01-17 16:27 ` [PATCH 3/8] gdb: replace inferior::waiting_for_vfork_done with inferior::thread_waiting_for_vfork_done Simon Marchi
2022-03-31 18:17 ` Pedro Alves
2022-04-01 14:25 ` Simon Marchi
2022-01-17 16:27 ` [PATCH 4/8] gdb/infrun: add inferior parameters to stop_all_threads and restart_threads Simon Marchi
2022-03-31 18:17 ` Pedro Alves
2022-01-17 16:27 ` [PATCH 5/8] gdb/infrun: add logging statement to do_target_resume Simon Marchi
2022-03-31 18:18 ` Pedro Alves
2022-01-17 16:27 ` [PATCH 6/8] gdb: fix handling of vfork by multi-threaded program (follow-fork-mode=parent, detach-on-fork=on) Simon Marchi
2022-03-31 18:21 ` Pedro Alves
2022-04-01 17:28 ` Simon Marchi
2022-01-17 16:27 ` [PATCH 7/8] gdbserver: report correct status in thread stop race condition Simon Marchi
2022-03-31 18:21 ` Pedro Alves
2022-01-17 16:27 ` [PATCH 8/8] gdb: resume ongoing step after handling fork or vfork Simon Marchi
2022-03-31 18:22 ` Pedro Alves
2022-03-31 18:28 ` Pedro Alves
2022-04-01 18:42 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4cde23e-9f61-44b3-0b52-9aa754fb1b47@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).