From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by sourceware.org (Postfix) with ESMTPS id 27DBE3858D3C for ; Thu, 31 Mar 2022 16:12:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 27DBE3858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f49.google.com with SMTP id n35so90787wms.5 for ; Thu, 31 Mar 2022 09:12:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=yy0AUvS4dLygBEYYZuhQU7VjxOC2KvRnyGTNoudYgzA=; b=2nzXzXirbUJ4xETkVk+sOT4U+pF/+lK5x2iLyDL6pFXg0ib+Fk35HEOo4zW9L/ohPG 8Vnx0bccTUs6TY5R1W0Gh32+XsFEJfuvAEvcPBb1IXsizn93HSJ8yjz+fjBFHNm2N2zO T3up55cpvsh67PliZQtIxRrm0TxcVRNCQrsNv0fBFUlz4FNlKO5hgvODo+26MpTVe7ov /LHaYHCrKnGVhMOWqFaApOdNKamV2cxURQavDuKYAhPNUJCRv0bq0bFWGktuPpU0zS8T aj1NFdeF6E7fC6HUKfc3VIuxTUz6/SruWFAAWU2NNS5zJ79JO4dVUhtoZPlfpT7+Jjtg GXuA== X-Gm-Message-State: AOAM530dVgS1wEM+gmCoIT91+Ruc17w3Z2xz5UrIPXkdFynKY9HG5jkn 47xqt843SDsIQeah6FE+6qw= X-Google-Smtp-Source: ABdhPJx5OgwQFObZru4ZFovwwpxhC3aIeFpq3+DJmm0dOeRw0oenZvUvmgJ3pjM0SyS2CLhQmIuTBw== X-Received: by 2002:a05:600c:1e0d:b0:38c:bb0c:e01 with SMTP id ay13-20020a05600c1e0d00b0038cbb0c0e01mr5270466wmb.115.1648743137865; Thu, 31 Mar 2022 09:12:17 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id f1-20020a1c6a01000000b0038c9f6a3634sm7568375wmc.7.2022.03.31.09.12.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Mar 2022 09:12:16 -0700 (PDT) Message-ID: Date: Thu, 31 Mar 2022 17:12:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 2/8] gdb/linux-nat: remove check based on current_inferior in linux_handle_extended_wait Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20220117162742.524350-1-simon.marchi@polymtl.ca> <20220117162742.524350-3-simon.marchi@polymtl.ca> From: Pedro Alves In-Reply-To: <20220117162742.524350-3-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2022 16:12:20 -0000 On 2022-01-17 16:27, Simon Marchi via Gdb-patches wrote: > diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c > index b926fb5eba9e..7de4da03a34f 100644 > --- a/gdb/linux-nat.c > +++ b/gdb/linux-nat.c > @@ -2096,20 +2096,11 @@ linux_handle_extended_wait (struct lwp_info *lp, int status) > > if (event == PTRACE_EVENT_VFORK_DONE) > { > - if (current_inferior ()->waiting_for_vfork_done) > - { > - linux_nat_debug_printf > - ("Got expected PTRACE_EVENT_VFORK_DONE from LWP %ld: stopping", > - lp->ptid.lwp ()); > - > - ourstatus->set_vfork_done (); > - return 0; > - } > - > linux_nat_debug_printf > - ("Got PTRACE_EVENT_VFORK_DONE from LWP %ld: ignoring", lp->ptid.lwp ()); > - > - return 1; > + ("Got expected PTRACE_EVENT_VFORK_DONE from LWP %ld", > + lp->ptid.lwp ()); Please drop the "expected" from the log, as we're not checking waiting_for_vfork_done anymore. > + /* Child */ > + _exit(12); Space before parens. Otherwise OK. Thanks.