Re: [PATCH 1/5] Add regcache_map_supplies helper routine.

[Pedro Alves <pedro@palves.net>]

On 2021-07-12 2:13 p.m., John Baldwin wrote:
> On 7/10/21 12:25 PM, Pedro Alves wrote:
>> On 2021-05-28 9:26 p.m., John Baldwin wrote:
>>
>>> diff --git a/gdb/regcache.h b/gdb/regcache.h
>>> index ee254f381f4..a1f63d40253 100644
>>> --- a/gdb/regcache.h
>>> +++ b/gdb/regcache.h
>>> @@ -150,6 +150,13 @@ extern void regcache_collect_regset (const struct regset *regset,
>>>                        int regnum, void *buf, size_t size);
>>>     +/* Return true if a set of registers (whose layout is described by
>>> +   MAP) contains the value of the register numbered REGNUM.  */
>>
>> I assume SIZE is the register's size?  From the description of regcache_map, some of the
>> map entries have sizes smaller than the corresponding register's size.  How do
>> they interact?  IOW, please document SIZE.  :-)
> 
> Ah, will do.  In this case SIZE is the size of the entire register set, the same as
> the size passed to regcache::collect_regset and regcache::supply_regset that this
> is intended to be paired with, e.g. for a native target fetch_registers:
> 
>   struct reg regs;
> 
>   if (regnum == -1
>      || regcache_map_supplies (map, regnum, gdbarch, sizeof (regs))
>     {
>       /* populate 'regs' */
> 
>       regcache->supply_regset (regset, regnum, &regs, sizeof (regs));
>     }
> 
> I've modified the comment to:
> 
> /* Return true if a set of registers contains the value of the
>    register numbered REGNUM.  The size of the set of registers is
>    given in SIZE, and the layout of the set of registers is described
>    by MAP.  */
> 

Works for me, thanks!