From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-146788-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12016 invoked by alias); 24 Apr 2018 16:43:56 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 11999 invoked by uid 89); 24 Apr 2018 16:43:55 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Apr 2018 16:43:54 +0000
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 23D07401DEAA;	Tue, 24 Apr 2018 16:43:53 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id A58D57C53;	Tue, 24 Apr 2018 16:43:52 +0000 (UTC)
Subject: Re: [RFA 7/8] Allow breakpoint commands to be set from Python
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <20180419191539.661-1-tom@tromey.com> <20180419191539.661-8-tom@tromey.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <b52d96eb-1803-a56a-6e41-f9b4a13e8e7b@redhat.com>
Date: Tue, 24 Apr 2018 16:43:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180419191539.661-8-tom@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-04/txt/msg00480.txt.bz2

On 04/19/2018 08:15 PM, Tom Tromey wrote:

> +/* Set the commands attached to a breakpoint.  Returns 0 on success.
> +   Returns -1 on error, with a python exception set.  */
> +static int
> +bppy_set_commands (PyObject *self, PyObject *newvalue, void *closure)
> +{
> +  gdbpy_breakpoint_object *self_bp = (gdbpy_breakpoint_object *) self;
> +  struct breakpoint *bp = self_bp->bp;
> +  struct gdb_exception except = exception_none;
> +
> +  BPPY_SET_REQUIRE_VALID (self_bp);
> +
> +  gdb::unique_xmalloc_ptr<char> commands
> +    (python_string_to_host_string (newvalue));
> +  if (commands == nullptr)
> +    return -1;
> +
> +  TRY
> +    {
> +      bool first = true;
> +      char *save_ptr = nullptr;
> +      gdb::function_view<const char * ()> reader
> +	= [&] ()

Like in the other patch, binding to a temporary.  Use "auto".

Otherwise looks fine to me.

> +	  {
> +	    const char *result = strtok_r (first ? commands.get () : nullptr,
> +					   "\n", &save_ptr);
> +	    first = false;
> +	    return result;
> +	  };
> +
> +      counted_command_line lines = read_command_lines_1 (reader, 1, nullptr);
> +      breakpoint_set_commands (self_bp->bp, std::move (lines));
> +    }
> +  CATCH (ex, RETURN_MASK_ALL)
> +    {
> +      except = ex;
> +    }
> +  END_CATCH
> +

Thanks,
Pedro Alves