From: Tom de Vries <tdevries@suse.de>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: [PING][gdb/testsuite] Add gdb-caching-proc.exp testcase
Date: Mon, 05 Nov 2018 09:05:00 -0000 [thread overview]
Message-ID: <b55568e2-b45f-37cb-97b0-b6c72fe9b191@suse.de> (raw)
In-Reply-To: <20181009134747.GA1742@delia>
On 10/9/18 3:47 PM, Tom de Vries wrote:
> On Tue, Oct 09, 2018 at 01:58:26PM +0100, Pedro Alves wrote:
>> Can you please
>> submit the gdb-caching-proc.exp separately, with its own rationale?
>>
>
> Hi,
>
> When caching a proc using gdb_caching_proc, it will become less likely to
> be executed, and consequently it's going to be harder to detect that the
> proc is racy. OTOH, in general the proc is easy to rerun. So, add a
> test-case to run all uncached gdb_caching_procs a number of times and detect
> inconsistent results.
>
> The purpose of caching is to reduce runtime, so rerunning is somewhat
> counter-productive in that aspect, but it's better than uncached, because the
> number of reruns is constant-bounded, and the increase in runtime is bound to
> this test-case, and can be disabled on slow targets.
>
> Tested on x86_64-linux.
>
> OK for trunk?
>
Ping.
Thanks,
- Tom
> [gdb/testsuite] Add gdb-caching-proc.exp testcase
>
> 2018-10-09 Tom de Vries <tdevries@suse.de>
>
> * gdb.base/gdb-caching-proc.exp: New file.
>
> ---
> gdb/testsuite/gdb.base/gdb-caching-proc.exp | 111 ++++++++++++++++++++++++++++
> 1 file changed, 111 insertions(+)
>
> diff --git a/gdb/testsuite/gdb.base/gdb-caching-proc.exp b/gdb/testsuite/gdb.base/gdb-caching-proc.exp
> new file mode 100644
> index 0000000000..87c20fc574
> --- /dev/null
> +++ b/gdb/testsuite/gdb.base/gdb-caching-proc.exp
> @@ -0,0 +1,111 @@
> +# Copyright 2018 Free Software Foundation, Inc.
> +
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program. If not, see <http://www.gnu.org/licenses/>.
> +
> +# When caching a proc using gdb_caching_proc, it will become less likely to
> +# be executed, and consequently it's going to be harder to detect that the
> +# proc is racy. OTOH, in general the proc is easy to rerun. So, run all
> +# uncached gdb_caching_procs a number of times and detect inconsistent results.
> +# The purpose of caching is to reduce runtime, so rerunning is somewhat
> +# counter-productive in that aspect, but it's better than uncached, because the
> +# number of reruns is constant-bounded, and the increase in runtime is bound to
> +# this test-case, and could be disabled on slow targets.
> +
> +# Test gdb_caching_proc NAME
> +proc test_proc { name } {
> + set real_name gdb_real__$name
> +
> + set first [$real_name]
> + lappend resultlist $first
> +
> + # Ten repetitions was enough to trigger target_supports_scheduler_locking,
> + # and costs about 20 seconds on an i7-6600U.
> + set repeat 10
> +
> + set resultlist [list]
> + set racy 0
> + for {set i 0} {$i < $repeat} {incr i} {
> + set rerun [$real_name]
> + lappend resultlist $rerun
> + if { $rerun != $first } {
> + set racy 1
> + }
> + }
> +
> + if { $racy == 0 } {
> + pass "$name consistency"
> + } else {
> + fail "$name consistency"
> + verbose -log "$name: $resultlist"
> + }
> +}
> +
> +# Test gdb_caching_procs in FILE
> +proc test_file { file } {
> + upvar obj obj
> + set procnames [list]
> +
> + set fp [open $file]
> + while { [gets $fp line] >= 0 } {
> + if [regexp -- "^gdb_caching_proc \[ \t\]*(\[^ \t\]*)" $line \
> + match procname] {
> + lappend procnames $procname
> + }
> + }
> + close $fp
> +
> + if { [llength $procnames] == 0 } {
> + return
> + }
> +
> + if { [file tail $file] == "gdb.exp" } {
> + # Already loaded
> + } else {
> + load_lib [file tail $file]
> + }
> +
> + foreach procname $procnames {
> + switch $procname {
> + "is_address_zero_readable" { set setup_gdb 1 }
> + "target_is_gdbserver" { set setup_gdb 1 }
> + default {set setup_gdb 0 }
> + }
> +
> + if { $setup_gdb } {
> + clean_restart $obj
> + }
> +
> + test_proc $procname
> +
> + if { $setup_gdb } {
> + gdb_exit
> + }
> + }
> +}
> +
> +# Init
> +set me "gdb_caching_proc"
> +set src { int main() { return 0; } }
> +if { ![gdb_simple_compile $me $src executable] } {
> + return 0
> +}
> +
> +# Test gdb_caching_procs in gdb/testsuite/lib/*.exp
> +set files [eval glob -types f $srcdir/lib/*.exp]
> +foreach file $files {
> + test_file $file
> +}
> +
> +# Cleanup
> +remote_file build delete $obj
>
next prev parent reply other threads:[~2018-11-05 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 17:40 [PATCH][gdb/testsuite] Fix target_supports_scheduler_locking raciness Tom de Vries
2018-10-09 12:58 ` Pedro Alves
2018-10-09 13:47 ` [gdb/testsuite] Add gdb-caching-proc.exp testcase Tom de Vries
2018-11-05 9:05 ` Tom de Vries [this message]
2018-11-30 19:49 ` Tom Tromey
2018-12-01 8:04 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b55568e2-b45f-37cb-97b0-b6c72fe9b191@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).