From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id E38AD385843F for ; Mon, 8 Nov 2021 17:41:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E38AD385843F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0CB6E1ECEB; Mon, 8 Nov 2021 12:41:25 -0500 (EST) Subject: Re: [PATCH v2 00/32] Rewrite the DWARF "partial" reader To: Tom Tromey , gdb-patches@sourceware.org References: <20211104180907.2360627-1-tom@tromey.com> From: Simon Marchi Message-ID: Date: Mon, 8 Nov 2021 12:41:24 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211104180907.2360627-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Nov 2021 17:41:27 -0000 On 2021-11-04 2:08 p.m., Tom Tromey wrote: > Here is v2 of my series to rewrit the DWARF partial symbol reader. > > You can find v1 here: > > https://sourceware.org/pipermail/gdb-patches/2021-August/181624.html > > This update addresses all the review comments. I believe it fixes all > the problems that Tom de Vries found. > > I regression tested this on x86-64 Fedora 34. > > Let me know what you think. > > Tom > > Hi Tom, I did go through the series, I don't have any objection, and don't have much constructive comments, because I'm not that aware of how things work currently with partial symtabs. What I think I understand is that with the new indexer, we gather essentially the same information that we gather today with partial symbols (just the information needed for doing lookups and expanding symtabs), but store it in a data structure that is better designed, letting us do more in parallel. Does that sounds right? If not, can you explain what's the main difference? What sounds nice with partial symtabs is that they are re-used by different debug formats, so each format doesn't need to implement its own data structures to manage symtab lookups and expansion. How much is that new DWARF indexer really DWARF-specific (the part that parses the DWARF obviously is, but the part that holds names and stuff)? Could it one day be used by other debug formats? Simon Simon