From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by sourceware.org (Postfix) with ESMTPS id 6EACC385840D for ; Tue, 23 Apr 2024 19:41:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6EACC385840D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6EACC385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713901264; cv=none; b=DB/5CQUDcOOe74ovMl846gfwjzYVDG1ShSrXZCToxXRIAvG++B3tqzCeCwxP6U1nM/H28A6NYet23Q/hhkhoKyrJed9793r4y3QtO+Y6CzHCBMKhP1SMiDyhnE3rYdPREzEEs9Jq0wQqjN9xbM5rgmuANRaehegdAu5FWEbxvW0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713901264; c=relaxed/simple; bh=GUWL7CAKtjsQh0pB+iRy48oWzvU5Q5xsmERE8Okslhk=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=fiJLG28C89Tg7FbDx4uHjnoaMs2iZjkE8a6Gab/dZUOG1bZ+j88RuRkgQXZ41p75+E9+cvZ1e3c5PwxdhaZIoP/d08SKBO+ZSVSG9KRz1lpwBZEci7LL8SPeQrXxkBdSHzkCtBC0XZEKszfZfwfWVeYZDMV3FuuDOQrZBGtl36U= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-41a5b68ed5cso27478385e9.2 for ; Tue, 23 Apr 2024 12:41:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713901260; x=1714506060; h=content-transfer-encoding:in-reply-to:content-language:from :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O3S/3qOaV8I/xeP0lsO/J2a7ln0kqvHKel79KqBOX6k=; b=YHU7scajM9H+wgvXkaI/007Mro/SDtlFsl6SXilphyUbMz3+xs8BZOh09hekyaJY2s v11lZQ3bAX1tIf0aygwHo4xa8Oc9SBchbCa3060AuiFAFi8DqamgOBEJnXPhYez7hKjg Xq4RlQymrehF4CG769bQ9opRX2RUcgruL+AkwKU+DcTgp2d/5YZy9sBXFWxH5eEvsIQw PKn1F3d7lPo7iqKEXxiNPv713jK9e5S6ml05jkfGt3OeLCaWZsZ3kcKvx9S2uOuH5yg3 5tx2gLmGjKacr7N2divhasGDw2V6/w4lF0j8lr9HJKojuukVCJD5uR/ZvD16EMUbam0i vM8Q== X-Forwarded-Encrypted: i=1; AJvYcCXs0o1gC0bwI6pmZMmWdYwGyS+s3fJTMbJS/pG0hzmhkPX1Popd7P4kv8VX/LXEwpF9zdZMi+hI6oQk3kBR1hrWokEaHi0s3xBrcA== X-Gm-Message-State: AOJu0Yw06YkqteUOWDZKuBVzK3b9vxjfvuvomYnAY/GbDou7Cc2e7zNo g11fWmCrzrkaig576A5VnY4BX+Yz3VzMxo+DWoyg33UnKgrn9+t0MNmyvw== X-Google-Smtp-Source: AGHT+IE3Qjz2fdQ1/5GlVyNLWqCHXcObxR8OWN2H+0Jzt/N1wiwlsa74u4zjoj/1iVybDIMzc4urrA== X-Received: by 2002:a05:600c:3ba9:b0:41a:9c24:8d7 with SMTP id n41-20020a05600c3ba900b0041a9c2408d7mr265411wms.30.1713901260091; Tue, 23 Apr 2024 12:41:00 -0700 (PDT) Received: from ?IPV6:2001:8a0:f93d:b900:4f86:481:20cb:27d? ([2001:8a0:f93d:b900:4f86:481:20cb:27d]) by smtp.gmail.com with ESMTPSA id n2-20020adfe342000000b00343eac2acc4sm15293265wrj.111.2024.04.23.12.40.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Apr 2024 12:40:59 -0700 (PDT) Message-ID: Date: Tue, 23 Apr 2024 20:40:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/7] gdb: move store/extract integer functions to extract-store-integer.{c, h} To: Simon Marchi , Simon Marchi , gdb-patches@sourceware.org References: <20240422201157.46375-1-simon.marchi@efficios.com> <20240422201157.46375-5-simon.marchi@efficios.com> From: Pedro Alves Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-04-23 20:10, Simon Marchi wrote: > > > On 2024-04-23 14:03, Pedro Alves wrote: >> On 2024-04-22 21:10, Simon Marchi wrote: >> >>> diff --git a/gdb/extract-store-integer.c b/gdb/extract-store-integer.c >>> new file mode 100644 >>> index 000000000000..a3b7e40d6424 >>> --- /dev/null >>> +++ b/gdb/extract-store-integer.c >>> @@ -0,0 +1,308 @@ >>> +/* Copyright (C) 2024 Free Software Foundation, Inc. >>> + >> >> The code moved here isn't new. (Copyright covers contents, not files.) >> > > How would you go about finding the correct start year? I can just use > the same year as defs.h (1986-2024), but that may not be correct either > for that particular content. > Preserving the original dates is the easiest. Either that or some git blaming. Grepping the old ChangeLog files will also often give you the right dates, if there's a "(foo_function): New."