From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: Remove a few more cleanups: solib and openp
Date: Wed, 14 Feb 2018 13:55:00 -0000 [thread overview]
Message-ID: <b5a027cd-7bc6-be7c-f3c6-ff0e0077750a@redhat.com> (raw)
In-Reply-To: <20180213233907.11259-1-tom@tromey.com>
On 02/13/2018 11:39 PM, Tom Tromey wrote:
> This series removes a few cleanups by using unique_xmalloc_ptr. This
> also helps clarify the ownership rules of a few APIs. This series
> also includes a couple of minor (non-cleanup-related) code clarity
> improvements in related areas: moving some declarations out of defs.h,
> and a constification.
>
> Regression tested by the buildbot.
Nice! LGTM. Please push.
I was wondering whether you'd write patch #1 the other day you
touched some of that code. :-) On that patch, you may want to remove
the "The returned pathname is malloc'ed and must be freed by the caller."
remarks from the intro comments of (at least) solib_find_1,
exec_file_find and solib_find (in solib.c).
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-02-14 13:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 23:39 Tom Tromey
2018-02-13 23:39 ` [RFA 2/4] Move some declarations to source.h Tom Tromey
2018-02-13 23:39 ` [RFA 3/4] Change openp et al to use a unique_xmalloc_ptr Tom Tromey
2018-02-13 23:39 ` [RFA 1/4] Return unique_xmalloc_ptr from some solib.c functions Tom Tromey
2018-02-13 23:39 ` [RFA 4/4] Constify target_so_ops::bfd_open Tom Tromey
2018-02-14 13:55 ` Pedro Alves [this message]
2018-02-14 15:03 ` Remove a few more cleanups: solib and openp Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5a027cd-7bc6-be7c-f3c6-ff0e0077750a@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).